<div dir="ltr">Gah, I really thought this woudl work. I will revert again.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 27, 2016 at 11:48 AM Tamas Berghammer <<a href="mailto:tberghammer@google.com">tberghammer@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Zach,<div><br></div><div>I think this CL (or one of your other recent related CL) caused some regression on the Linux builder. You can see the failed build here: <a href="http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10736" target="_blank">http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10736</a></div><div><br></div><div>Can you take a look (if you need help or you think it isn't caused by one of your CL then I can look into it tomorrow)?</div><div><br></div><div>Thanks,</div><div>Tamas</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 27, 2016 at 7:04 PM Zachary Turner via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br>
Date: Wed Jan 27 13:00:51 2016<br>
New Revision: 258969<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=258969&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=258969&view=rev</a><br>
Log:<br>
Resubmit r258759 with proper unicode handling.<br>
<br>
Instead of opening the file in unicode mode, we need only encode<br>
data which potentially has non-ASCII characters as UTF8 before<br>
writing. This should work across both Python versions, and is<br>
also far simpler than anything else discussed.<br>
<br>
Modified:<br>
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char1632_t/TestChar1632T.py<br>
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py<br>
<br>
Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char1632_t/TestChar1632T.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char1632_t/TestChar1632T.py?rev=258969&r1=258968&r2=258969&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char1632_t/TestChar1632T.py?rev=258969&r1=258968&r2=258969&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char1632_t/TestChar1632T.py (original)<br>
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char1632_t/TestChar1632T.py Wed Jan 27 13:00:51 2016<br>
@@ -25,7 +25,6 @@ class Char1632TestCase(TestBase):<br>
line_number(self.source, '// breakpoint2') ]<br>
<br>
@expectedFailureIcc # ICC (13.1) does not emit the DW_TAG_base_type for char16_t and char32_t.<br>
- @expectedFailureWindows("<a href="http://llvm.org/pr24489" rel="noreferrer" target="_blank">llvm.org/pr24489</a>: Name lookup not working correctly on Windows")<br>
def test(self):<br>
"""Test that the C++11 support for char16_t and char32_t works correctly."""<br>
self.build()<br>
<br>
Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=258969&r1=258968&r2=258969&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=258969&r1=258968&r2=258969&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py (original)<br>
+++ lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Wed Jan 27 13:00:51 2016<br>
@@ -262,7 +262,7 @@ class recording(SixStringIO):<br>
if self.trace:<br>
print(self.getvalue(), file=sys.stderr)<br>
if self.session:<br>
- print(self.getvalue(), file=self.session)<br>
+ print(self.getvalue().encode(), file=self.session)<br>
self.close()<br>
<br>
@add_metaclass(abc.ABCMeta)<br>
@@ -1843,7 +1843,7 @@ class Base(unittest2.TestCase):<br>
if not self.__unexpected__ and not self.__skipped__:<br>
for test, traceback in pairs:<br>
if test is self:<br>
- print(traceback, file=self.session)<br>
+ print(traceback.encode(), file=self.session)<br>
<br>
# put footer (timestamp/rerun instructions) into session<br>
testMethod = getattr(self, self._testMethodName)<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>
</blockquote></div>