<div dir="ltr">Should be fine. I probably don't need to try out the patch, it looks good as is (and I'm not in a state where I can try it for a while)</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 19, 2016 at 2:22 PM Davide Italiano <<a href="mailto:davide@freebsd.org">davide@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Jan 19, 2016 at 2:11 PM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br>
> What about this:<br>
><br>
> switch (m_private_state.GetValue())<br>
> {<br>
> case eStateConnected:<br>
> case eStateAttaching:<br>
> case eStateLaunching:<br>
> case eStateStopped:<br>
> case eStateRunning:<br>
> case eStateStepping:<br>
> case eStateCrashed:<br>
> case eStateSuspended:<br>
> return true;<br>
><br>
> default:<br>
> return false;<br>
> }<br>
><br>
<br>
Yes, that should work, I modified the other one in the same way<br>
<a href="https://people.freebsd.org/~davide/llvm/lldb_uncoveredswitch.diff" rel="noreferrer" target="_blank">https://people.freebsd.org/~davide/llvm/lldb_uncoveredswitch.diff</a><br>
Can you please take a look at the patch before I commit? (and also<br>
ensure it doesn't re-introduce warning with your compiler?)<br>
<br>
Thanks!<br>
<br>
--<br>
Davide<br>
<br>
><br>
> On Tue, Jan 19, 2016 at 2:10 PM Davide Italiano <<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>> wrote:<br>
>><br>
>> On Tue, Jan 19, 2016 at 2:08 PM, Davide Italiano <<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>><br>
>> wrote:<br>
>> > On Tue, Jan 19, 2016 at 2:05 PM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>><br>
>> > wrote:<br>
>> >> This is needed in order to prevent MSVC from warning about this case.<br>
>> >> I<br>
>> >> explicitly added these last week. Can I ask that you revert this<br>
>> >> change?<br>
>> >><br>
>><br>
>> In particular:<br>
>><br>
>> ../tools/lldb/source/Target/Process.cpp:1507:9: warning: default label in<br>
>> switch<br>
>> which covers all enumeration values [-Wcovered-switch-default]<br>
>> default:<br>
>> ^<br>
>><br>
>><br>
>> ><br>
>> > Well, this broke the build with -Werror which is my default, that's<br>
>> > why I made the change.<br>
>> > Is there a way we can make everybody happy you can think of?<br>
>> ><br>
>> >> On Tue, Jan 19, 2016 at 2:03 PM Davide Italiano via lldb-commits<br>
>> >> <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br>
>> >>><br>
>> >>> Author: davide<br>
>> >>> Date: Tue Jan 19 15:59:12 2016<br>
>> >>> New Revision: 258199<br>
>> >>><br>
>> >>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=258199&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=258199&view=rev</a><br>
>> >>> Log:<br>
>> >>> [Process] Remove dead code. All the switch cases are already covered.<br>
>> >>><br>
>> >>> Modified:<br>
>> >>> lldb/trunk/source/Expression/ExpressionSourceCode.cpp<br>
>> >>> lldb/trunk/source/Target/Process.cpp<br>
>> >>><br>
>> >>> Modified: lldb/trunk/source/Expression/ExpressionSourceCode.cpp<br>
>> >>> URL:<br>
>> >>><br>
>> >>> <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ExpressionSourceCode.cpp?rev=258199&r1=258198&r2=258199&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ExpressionSourceCode.cpp?rev=258199&r1=258198&r2=258199&view=diff</a><br>
>> >>><br>
>> >>><br>
>> >>> ==============================================================================<br>
>> >>> --- lldb/trunk/source/Expression/ExpressionSourceCode.cpp (original)<br>
>> >>> +++ lldb/trunk/source/Expression/ExpressionSourceCode.cpp Tue Jan 19<br>
>> >>> 15:59:12 2016<br>
>> >>> @@ -118,8 +118,6 @@ public:<br>
>> >>> return false;<br>
>> >>> else<br>
>> >>> return true;<br>
>> >>> - default:<br>
>> >>> - return false;<br>
>> >>> }<br>
>> >>> }<br>
>> >>><br>
>> >>><br>
>> >>> Modified: lldb/trunk/source/Target/Process.cpp<br>
>> >>> URL:<br>
>> >>><br>
>> >>> <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Process.cpp?rev=258199&r1=258198&r2=258199&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Process.cpp?rev=258199&r1=258198&r2=258199&view=diff</a><br>
>> >>><br>
>> >>><br>
>> >>> ==============================================================================<br>
>> >>> --- lldb/trunk/source/Target/Process.cpp (original)<br>
>> >>> +++ lldb/trunk/source/Target/Process.cpp Tue Jan 19 15:59:12 2016<br>
>> >>> @@ -1504,8 +1504,6 @@ Process::IsAlive ()<br>
>> >>> case eStateCrashed:<br>
>> >>> case eStateSuspended:<br>
>> >>> return true;<br>
>> >>> - default:<br>
>> >>> - return false;<br>
>> >>> }<br>
>> >>> }<br>
>> >>><br>
>> >>><br>
>> >>><br>
>> >>> _______________________________________________<br>
>> >>> lldb-commits mailing list<br>
>> >>> <a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
>> >>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
>> ><br>
>> ><br>
>> ><br>
>> > --<br>
>> > Davide<br>
>> ><br>
>> > "There are no solved problems; there are only problems that are more<br>
>> > or less solved" -- Henri Poincare<br>
>><br>
>><br>
>><br>
>> --<br>
>> Davide<br>
>><br>
>> "There are no solved problems; there are only problems that are more<br>
>> or less solved" -- Henri Poincare<br>
<br>
<br>
<br>
--<br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<br>
</blockquote></div>