<div dir="ltr">I XFAIL-ed the test for Linux to get the build bot green again and filed a bug at <a href="https://llvm.org/bugs/show_bug.cgi?id=26139">https://llvm.org/bugs/show_bug.cgi?id=26139</a></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jan 14, 2016 at 2:18 AM Ying Chen via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Please see attached log file.<div><br></div><div>Thanks,</div><div>Ying</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 13, 2016 at 5:39 PM, Enrico Granata <span dir="ltr"><<a href="mailto:egranata@apple.com" target="_blank">egranata@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>From the buildbot log it’s quite hard to tell what could be going on</div><div><br></div><div>Is there any chance you guys could run the test by hand with the “-t -v” flags to the dotest.py driver and attach the output of the run?</div><div><br></div><div>That might help figure out where the issue lies</div><div><div><br><div><blockquote type="cite"><div>On Jan 13, 2016, at 5:35 PM, Ying Chen <<a href="mailto:chying@google.com" target="_blank">chying@google.com</a>> wrote:</div><br><div><div dir="ltr">Hello Enrico,<div><br></div><div>The new test has been failing on Ubuntu buildbot. But it's passing on some offline Ubuntu machines, I don't understand what caused the difference.</div><div>Could you please help to take a look?</div><div><br></div><div><a href="http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10299" target="_blank">http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10299</a><br></div><div><br></div><div>Thanks,</div><div>Ying</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 13, 2016 at 11:32 AM, Enrico Granata via lldb-commits <span dir="ltr"><<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span><blockquote type="cite"><div>On Jan 13, 2016, at 11:26 AM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:</div><br><div><div dir="ltr">Thanks! btw would having the command write its output to a file instead of stdout solve the pexpect problme as well?</div><br></div></blockquote><div><br></div></span><div>That’s possible - but I would need to play with it a little bit to convince myself that it really is a faithful reproduction of my original issue</div><div>It’ll take me a little while to get to it - stay tuned.</div><div><div><br><blockquote type="cite"><div><div class="gmail_quote"><div dir="ltr">On Wed, Jan 13, 2016 at 11:22 AM Enrico Granata <<a href="mailto:egranata@apple.com" target="_blank">egranata@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><blockquote type="cite"><div>On Jan 13, 2016, at 10:34 AM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:</div><br><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 13, 2016 at 10:25 AM Enrico Granata <<a href="mailto:egranata@apple.com" target="_blank">egranata@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><blockquote type="cite"><div>On Jan 13, 2016, at 10:21 AM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:</div><br><div><div dir="ltr"><div><br></div><div>On Wed, Jan 13, 2016 at 10:15 AM Enrico Granata via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br></div><div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">+<br>+class CommandScriptImmediateOutputTestCase (PExpectTest):<br></blockquote>Does the bug that you were trying to fix occur only when using the command_script.py file from the lldb command line? If you load it from within lldb via an LLDB command, does the problem still occur? If the problem you are fixing is not specific to the LLDB command line, I would prefer if you write this not as a pexpect test.</div></div></div></div></blockquote><div><br></div></div></div><div style="word-wrap:break-word"><div><div>I would love to not touch pexpect :-) But in this case, I can’t see a way around it. I am trying to detect whether some text is “physically” printed to stdout. And pexpect seems the most obvious straightforward way to get that to happen. Note that, in this bug, the result object is filled in correctly even if nothing gets printed, so looking at the result won’t quite cut it - it really needs to detect output to stdout.</div></div></div></blockquote><div>You're calling result.SetImmediateOutputFile(sys.__stdout__). Wouldn't it work to use a file on the file system here, and then you open that file and look at it after running the commands? It wouldn't work in remote cases, but it already doesn't work on remote cases anyway (as you point out below)</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br><blockquote type="cite"><div><div dir="ltr"><div><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">+<br>+ mydir = TestBase.compute_mydir(__file__)<br>+<br>+ def setUp(self):<br>+ # Call super's setUp().<br>+ PExpectTest.setUp(self)<br>+<br>+ @skipIfRemote # test not remote-ready<span> </span><a href="http://llvm.org/pr24813" rel="noreferrer" target="_blank">llvm.org/pr24813</a><br>+ @expectedFlakeyFreeBSD("<a href="http://llvm.org/pr25172" rel="noreferrer" target="_blank">llvm.org/pr25172</a><span> </span>fails rarely on the buildbot")<br>+ @expectedFlakeyLinux("<a href="http://llvm.org/pr25172" rel="noreferrer" target="_blank">llvm.org/pr25172</a>")<br></blockquote><div>Are these necessary? The windows one is necessary (but not if you change this to not being a pexpect test as I've requested above), but why are the other ones necessary?</div></div></div></div></div></blockquote></div></div><div style="word-wrap:break-word"><div></div><div><br></div>Do we support remote pexpect? As for FreeBSD and Linux, they might not be necessary, but I’d rather much remove them (or let the relevant platform owners) remove them in a separate commit<br><div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br></div></div></div></blockquote><div>No remote pexpect, so the @skipIfRemote probably needs to be there. But I think everyone should be checking in tests enabled by default in the widest set of environments possible that you aren't completely sure are broken. It should be up to the platform holders to disable broken tests, not to enable working tests. Because it's much easier to notice a broken test going in than it is to notice a working test went in disabled (because who's going to think to test it out?).</div></div></div></div></blockquote></div><div><br></div></div><div style="word-wrap:break-word">This is a fair point. I’ll enable those platforms in a subsequent commit ASAP</div><div style="word-wrap:break-word"><br><div>
<div style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br>Thanks,</div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><i>- Enrico</i><br>📩 egranata@<font color="#ff2600"></font>.com ☎️ 27683</div>
</div>
<br></div></blockquote></div>
</div></blockquote></div></div></div><div><div><br><div>
<div style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br>Thanks,</div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><i>- Enrico</i><br>📩 egranata@<font color="#ff2600"></font>.com ☎️ 27683</div>
</div>
<br></div></div></div><br>_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
<br></blockquote></div><br></div>
</div></blockquote></div><br><div>
<div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br>Thanks,</div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><i>- Enrico</i><br>📩 egranata@<font color="#ff2600"></font>.com ☎️ 27683</div>
</div>
<br></div></div></div></blockquote></div><br></div>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>