<div dir="ltr">Yep - sorry.  I had been talking to Greg about this and misunderstood his comment on it. My mistake entirely.  Kate and I just talked and she pointed me to your document, Jim.<div><br></div><div>The description was:</div><div>where we had a clearly adhered to standard, keep it.</div><div>whee we didn't, we adopted LLVM.</div><div><br></div><div>Sorry for rehashing!</div><div><br></div><div>-Todd</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 11, 2015 at 2:12 PM, Jim Ingham <span dir="ltr"><<a href="mailto:jingham@apple.com" target="_blank">jingham@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span class=""><blockquote type="cite"><div>On Dec 11, 2015, at 2:01 PM, Todd Fiala via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:</div><br><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Dec 11, 2015 at 1:59 PM, Zachary Turner<span> </span><span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span><span> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span><div dir="ltr">On Fri, Dec 11, 2015 at 1:55 PM Todd Fiala via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hey Eugene and Greg,<div><br></div><div>I thought we were doing spaces before the open parens in places like this:</div><div><br></div><div></div></div><div dir="ltr"><div><span style="font-size:13px">-    BreakpointResolverSP resolver_sp(new BreakpointResolverFileLine (NULL,</span><br style="font-size:13px"></div></div><div dir="ltr"><div><span style="font-size:13px">...</span></div><div><span style="font-size:13px">+    BreakpointResolverSP resolver_sp(new BreakpointResolverFileLine(</span><span style="font-size:13px">nullptr,</span><br style="font-size:13px"></div><div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">(see the removal of the space after BreakpointResolverFileLine from the clang-tidy settings I presume).</span></div><div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">Did I misunderstand that?</span></div></div></blockquote><div><br></div></span><div>This was officially removed from the coding standard some months ago,</div></div></div></blockquote><div><br></div><div>Okay.  Are we 100% in sync with LLVM coding standard guidelines?  If so I can just look there to see what we're supposed to be doing.</div></div></div></div></div></blockquote><div><br></div></span><div>No, the differences between the lldb and llvm coding standards are documented in:</div><div><br></div><div><a href="http://lldb.llvm.org/lldb-coding-conventions.html" target="_blank">http://lldb.llvm.org/lldb-coding-conventions.html</a></div><span class="HOEnZb"><font color="#888888"><div><br></div><div>Jim</div><br></font></span><blockquote type="cite"><div><span class=""><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div>but not everyone has adopted this unfortunately.  See r228860.  It pains me to no end that we differ from LLVM, because it leads to exactly these type of problems where people aren't sure what the exact set of rules are.</div></div></div></blockquote></div><br><br clear="all"><div><br></div>--<span> </span><br><div><div dir="ltr">-Todd</div></div></div></div></span><span class=""><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">_______________________________________________</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">lldb-commits mailing list</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="mailto:lldb-commits@lists.llvm.org" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">lldb-commits@lists.llvm.org</a><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a></span></div></blockquote></div><br></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">-Todd</div></div>
</div>