<div dir="ltr">FWIW we bumped up the default OS X timeout from 4 to 6 minutes to address the same kind of thing, and that got rid of almost all of the timeouts we see here on 4-core machines running the test suite.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 11, 2015 at 9:24 AM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">(And by ridiculous, I mean the idea of having something time out, and having that be an expected condition just to keep the test red, is a heavy indication that something else needs to change --- feels like a bandaid on top of a bad patch job --- something I think we want to address at a more holistic level, which hopefully the low load test pass will help. I think increasing the timeout would be a better way to handle that in the short term).</div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Fri, Dec 11, 2015 at 9:22 AM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I think this (the expected timeout) will go away once I'm done with the low-load, single-worker follow up pass, fwiw. If that is not the case, we should be disabling tests that intermittently timeout for reasons other than high load.</div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Fri, Dec 11, 2015 at 9:21 AM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">"Expected timeout" - that concept is ridiculous.<div><br></div><div>Why not increase the timeout?</div><div><br></div><div>-Todd</div></div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Fri, Dec 11, 2015 at 3:06 AM, Pavel Labath via lldb-commits <span dir="ltr"><<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: labath<br>
Date: Fri Dec 11 05:05:24 2015<br>
New Revision: 255335<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=255335&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=255335&view=rev</a><br>
Log:<br>
Revert "Turn on new test summary results by default."<br>
<br>
The new test summary formatter does not honor the "expected timeout" markings, which makes our<br>
buildbots all red. I'm switching it off by default until we figure out a way to make this work.<br>
<br>
Modified:<br>
lldb/trunk/packages/Python/lldbsuite/test/dotest.py<br>
lldb/trunk/packages/Python/lldbsuite/test/result_formatter.py<br>
<br>
Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest.py?rev=255335&r1=255334&r2=255335&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest.py?rev=255335&r1=255334&r2=255335&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/packages/Python/lldbsuite/test/dotest.py (original)<br>
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest.py Fri Dec 11 05:05:24 2015<br>
@@ -407,12 +407,6 @@ def parseOptionsAndInitTestdirs():<br>
if args.results_formatter_options:<br>
configuration.results_formatter_options = args.results_formatter_options<br>
<br>
- # Default to using the BasicResultsFormatter if no formatter is specified<br>
- # and we're not a test inferior.<br>
- if not args.inferior and configuration.results_formatter_name is None:<br>
- configuration.results_formatter_name = (<br>
- "lldbsuite.test.basic_results_formatter.BasicResultsFormatter")<br>
-<br>
if args.lldb_platform_name:<br>
configuration.lldb_platform_name = args.lldb_platform_name<br>
if args.lldb_platform_url:<br>
<br>
Modified: lldb/trunk/packages/Python/lldbsuite/test/result_formatter.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/result_formatter.py?rev=255335&r1=255334&r2=255335&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/result_formatter.py?rev=255335&r1=255334&r2=255335&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/packages/Python/lldbsuite/test/result_formatter.py (original)<br>
+++ lldb/trunk/packages/Python/lldbsuite/test/result_formatter.py Fri Dec 11 05:05:24 2015<br>
@@ -683,9 +683,8 @@ class ResultsFormatter(object):<br>
<br>
if event_type == "terminate":<br>
self.terminate_called = True<br>
- elif event_type in [<br>
- EventBuilder.TYPE_TEST_RESULT,<br>
- EventBuilder.TYPE_JOB_RESULT]:<br>
+ elif (event_type == EventBuilder.TYPE_TEST_RESULT or<br>
+ event_type == EventBuilder.TYPE_JOB_RESULT):<br>
# Keep track of event counts per test/job result status type.<br>
# The only job (i.e. inferior process) results that make it<br>
# here are ones that cannot be remapped to the most recently<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div><div dir="ltr">-Todd</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div><div dir="ltr">-Todd</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div><div dir="ltr">-Todd</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">-Todd</div></div>
</div>