<div dir="ltr">I do see the lldbsuite.lldb_root var but didn't see an lldbsuite.lldb_test_root var. I added one and switched over to it here:<div><br></div><div>r254894</div><div><br></div><div>Let me know if that covers what you were thinking. I'm happy to have a place to stick the var :-) I'm thinking I may have other places that construct that, I'll replace those as I find them.</div><div><br></div><div>-Todd</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Dec 6, 2015 at 10:02 PM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Oh I'll have a look, thanks.</div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Sun, Dec 6, 2015 at 7:51 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><div><div><div dir="ltr">On Sun, Dec 6, 2015 at 7:13 PM Todd Fiala via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: tfiala<br>
Date: Sun Dec 6 21:10:02 2015<br>
New Revision: 254890<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=254890&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=254890&view=rev</a><br>
Log:<br>
Move test summary counts to end; simplify issue detail line<br>
<br>
Test summary counts now show at the end, with issue details<br>
above.<br>
<br>
Issue details now print "ISSUE_TYPE: test method (relative path)".<br>
Relative paths are relative to the<br>
packages/Python/lldbsuite/test directory.<br>
<br>
Sample output:<br>
<br>
test/dotest.py --executable `pwd`/build/Debug/lldb --results-formatter lldbsuite.test.basic_results_formatter.BasicResultsFormatter --threads 12<br>
Testing: 415 test suites, 12 threads<br>
415 out of 415 test suites processed - TestLldbGdbServer.py<br>
Test Results<br>
Total Test Methods Run (excluding reruns): 2470<br>
Test Method rerun count: 0<br>
<br>
Details:<br>
UNEXPECTED SUCCESS: test_symbol_name_dsym (functionalities/completion/TestCompletion.py)<br>
UNEXPECTED SUCCESS: test_symbol_name_dwarf (functionalities/completion/TestCompletion.py)<br>
<br>
===================<br>
Test Result Summary<br>
===================<br>
Success: 1329<br>
Expected Failure: 79<br>
Failure: 0<br>
Error: 0<br>
Unexpected Success: 2<br>
Skip: 1060<br>
<br>
Modified:<br>
lldb/trunk/packages/Python/lldbsuite/test/basic_results_formatter.py<br>
<br>
Modified: lldb/trunk/packages/Python/lldbsuite/test/basic_results_formatter.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/basic_results_formatter.py?rev=254890&r1=254889&r2=254890&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/basic_results_formatter.py?rev=254890&r1=254889&r2=254890&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/packages/Python/lldbsuite/test/basic_results_formatter.py (original)<br>
+++ lldb/trunk/packages/Python/lldbsuite/test/basic_results_formatter.py Sun Dec 6 21:10:02 2015<br>
@@ -9,6 +9,11 @@ normal LLDB test run output when no othe<br>
"""<br>
from __future__ import print_function<br>
<br>
+# Python system includes<br>
+import os<br>
+<br>
+# Our imports<br>
+<br>
from . import test_results<br>
<br>
<br>
@@ -200,14 +205,18 @@ class BasicResultsFormatter(test_results<br>
print_matching_tests = category[2]<br>
detail_label = category[3]<br>
<br>
+ test_base_dir = os.path.realpath(os.path.dirname(__file__))<br></blockquote></div></div><div>This can also be done now with `lldbsuite.lldb_test_root`. Or something very similar, I might be off on the variable name, but the idea is the same. We should probably use that wherever possible although you don't have to change this if you don't want to, just keep it in mind for the future. The nice thing about it is that it allows you to easily move code around without breaking this. For example if you move this code to a formatters/ directory as we proposed, this line will break, but using `lldbsuite.test_root` won't.</div></div></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div><div dir="ltr">-Todd</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">-Todd</div></div>
</div>