<div dir="ltr">There's no simulator support outside of Darwin, so none of it should get used anyway.</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 4, 2015 at 6:08 PM, Jim Ingham <span dir="ltr"><<a href="mailto:jingham@apple.com" target="_blank">jingham@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">In this case it's even a little weirder, 'cause we compile a source file that contains a class declaration (since the #if defined is after the #include), but not the methods that aren't inlined.  Then presumably link in the .o file containing whatever was the result of that compilation.  That seems potentially harmful.<br>
<span class="HOEnZb"><font color="#888888"><br>
Jim<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
> On Nov 4, 2015, at 6:02 PM, Jason Molenda <<a href="mailto:jmolenda@apple.com">jmolenda@apple.com</a>> wrote:<br>
><br>
> You're making a valid point.  I was only noting that this is not the first instance where've conditionally compiled mac platform files.<br>
><br>
> J<br>
><br>
>> On Nov 4, 2015, at 6:00 PM, Jim Ingham <<a href="mailto:jingham@apple.com">jingham@apple.com</a>> wrote:<br>
>><br>
>> Why?<br>
>><br>
>> Jim<br>
>><br>
>>> On Nov 4, 2015, at 5:43 PM, Jason Molenda <<a href="mailto:jmolenda@apple.com">jmolenda@apple.com</a>> wrote:<br>
>>><br>
>>> We do the same thing in other MacOSX platform files where they depend on Apple specific libraries.<br>
>>><br>
>>><br>
>>>> On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br>
>>>><br>
>>>> Why are we trying to build this at all on Linux?  Seems odd to build an empty file rather than just not build it.<br>
>>>><br>
>>>> Jim<br>
>>>><br>
>>>>> On Nov 4, 2015, at 5:23 PM, Chaoren Lin via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br>
>>>>><br>
>>>>> Author: chaoren<br>
>>>>> Date: Wed Nov  4 19:23:19 2015<br>
>>>>> New Revision: 252124<br>
>>>>><br>
>>>>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=252124&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=252124&view=rev</a><br>
>>>>> Log:<br>
>>>>> Fix build on Linux.<br>
>>>>><br>
>>>>> Modified:<br>
>>>>> lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm<br>
>>>>><br>
>>>>> Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm<br>
>>>>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm?rev=252124&r1=252123&r2=252124&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm?rev=252124&r1=252123&r2=252124&view=diff</a><br>
>>>>> ==============================================================================<br>
>>>>> --- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm (original)<br>
>>>>> +++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm Wed Nov  4 19:23:19 2015<br>
>>>>> @@ -9,6 +9,8 @@<br>
>>>>><br>
>>>>> #include "PlatformiOSSimulatorCoreSimulatorSupport.h"<br>
>>>>><br>
>>>>> +#if defined (__APPLE__)  // This Plugin uses the Mac-specific source/Host/macosx/cfcpp utilities<br>
>>>>> +<br>
>>>>> // C Includes<br>
>>>>> // C++ Includes<br>
>>>>> // Other libraries and framework includes<br>
>>>>> @@ -771,3 +773,5 @@ CoreSimulatorSupport::DeviceSet::GetFanc<br>
>>>>><br>
>>>>> return dev;<br>
>>>>> }<br>
>>>>> +<br>
>>>>> +#endif // __APPLE__<br>
>>>>><br>
>>>>><br>
>>>>> _______________________________________________<br>
>>>>> lldb-commits mailing list<br>
>>>>> <a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
>>>>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> lldb-commits mailing list<br>
>>>> <a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
>>>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
>>><br>
>><br>
><br>
<br>
</div></div></blockquote></div><br></div>