<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 23, 2015, at 2:31 PM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">If you change "enum" to "enum class" I think it will work </div></div></blockquote><div><br class=""></div><div>Yes that would also work</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">(IANALL but I think it's even more correct). </div></div></blockquote><div><br class=""></div><div>IANALL either, but I beg to differ on that</div><div>The way I usually heard it explained is that C has different “namespaces” (*) where it puts structs, vs. enums, vs. typedefs, and that is why you need to classify names with the kind of type they are - or make typedefs for them</div><div>(*) not in the C++ sense of the term, in the sense of bucket where the compiler would go look for a type given a typename</div><div>In C++ all kinds of types all live in common buckets, so the classification is redundant, but allowed, because C</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""> But if what you've done works, then that should be fine.</div></div></blockquote><div><br class=""></div><div>I haven’t heard any more rumbling from the bot. I’ll take that as approval of my patch :-)</div><br class=""><blockquote type="cite" class=""><div class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, Sep 23, 2015 at 1:50 PM Enrico Granata via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: enrico<br class="">
Date: Wed Sep 23 15:49:15 2015<br class="">
New Revision: 248429<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=248429&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=248429&view=rev</a><br class="">
Log:<br class="">
The Visual Studio compiler does not like this C-ism when 'enum class'es are involved<br class="">
<br class="">
<br class="">
Modified:<br class="">
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h<br class="">
<br class="">
Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h?rev=248429&r1=248428&r2=248429&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h?rev=248429&r1=248428&r2=248429&view=diff</a><br class="">
==============================================================================<br class="">
--- lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h (original)<br class="">
+++ lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h Wed Sep 23 15:49:15 2015<br class="">
@@ -105,7 +105,7 @@ protected:<br class="">
static bool<br class="">
AppleIsModuleObjCLibrary (const lldb::ModuleSP &module_sp);<br class="">
<br class="">
- static enum ObjCRuntimeVersions<br class="">
+ static ObjCRuntimeVersions<br class="">
GetObjCVersion (Process *process, lldb::ModuleSP &objc_module_sp);<br class="">
<br class="">
void<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
lldb-commits mailing list<br class="">
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank" class="">lldb-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""><div class="">
<div class="" style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="Apple-interchange-newline">Thanks,</div><div class="" style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><i class="">- Enrico</i><br class="">📩 egranata@<font color="#ff2600" class=""></font>.com ☎️ 27683</div>
</div>
<br class=""></body></html>