<div dir="ltr">Ok, lgtm then</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 18, 2015 at 10:42 AM Oleksiy Vyalov <<a href="mailto:ovyalov@google.com">ovyalov@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ovyalov added inline comments.<br>
<br>
================<br>
Comment at: source/Host/windows/FileSystem.cpp:130<br>
@@ +129,3 @@<br>
+    HANDLE file_handle = ::CreateFile(file_spec.GetCString(),<br>
+                                      FILE_READ_ATTRIBUTES,<br>
+                                      FILE_SHARE_READ,<br>
----------------<br>
Thanks for suggestion - it does work. Fixed.<br>
<br>
================<br>
Comment at: source/Utility/ModuleCache.cpp:110<br>
@@ +109,3 @@<br>
+<br>
+    if (link_count > 2)  // module is referred by other hosts.<br>
+        return;<br>
----------------<br>
If link counter == 2, it's okay to delete a module because in this case a counter includes following files: $platform/.cache/$uuid  and its sysroot link.<br>
<br>
<br>
<a href="http://reviews.llvm.org/D12971" rel="noreferrer" target="_blank">http://reviews.llvm.org/D12971</a><br>
<br>
<br>
<br>
</blockquote></div>