<div dir="ltr">Is pexpect actually needed for this test?  If it is for some reason, then just looking at the test it seems like we only really care about testing auto completion right?  Could it just be a unit test?  I think we should make it an explicit goal to avoid pexpect tests unless the test specificially requires launching lldb from the command line.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 2, 2015 at 5:10 AM Pavel Labath via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: labath<br>
Date: Wed Sep  2 07:09:31 2015<br>
New Revision: 246644<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=246644&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=246644&view=rev</a><br>
Log:<br>
XFAIL new tests in TestCompletion on windows due to missing pexpect<br>
<br>
Modified:<br>
    lldb/trunk/test/functionalities/completion/TestCompletion.py<br>
<br>
Modified: lldb/trunk/test/functionalities/completion/TestCompletion.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/completion/TestCompletion.py?rev=246644&r1=246643&r2=246644&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/completion/TestCompletion.py?rev=246644&r1=246643&r2=246644&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/test/functionalities/completion/TestCompletion.py (original)<br>
+++ lldb/trunk/test/functionalities/completion/TestCompletion.py Wed Sep  2 07:09:31 2015<br>
@@ -219,6 +219,7 @@ class CommandLineCompletionTestCase(Test<br>
         """Test that 'target va' completes to 'target variable '."""<br>
         self.complete_from_to('target va', 'target variable ')<br>
<br>
+    @expectedFailureHostWindows("<a href="http://llvm.org/pr22274" rel="noreferrer" target="_blank">llvm.org/pr22274</a>: need a pexpect replacement for windows")<br>
     @skipUnlessDarwin<br>
     @dsym_test<br>
     def test_symbol_name_dsym(self):<br>
@@ -228,6 +229,7 @@ class CommandLineCompletionTestCase(Test<br>
                               'breakpoint set -n Foo::Bar(int,\\ int)',<br>
                               turn_off_re_match=True)<br>
<br>
+    @expectedFailureHostWindows("<a href="http://llvm.org/pr22274" rel="noreferrer" target="_blank">llvm.org/pr22274</a>: need a pexpect replacement for windows")<br>
     @dwarf_test<br>
     def test_symbol_name_dwarf(self):<br>
         self.buildDwarf()<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>