<div dir="ltr">> <span style="font-size:12.8000001907349px">Are we sure it can't happen through a transitive include?</span><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">In that case, whatever included it is breaking the <a href="http://lldb.llvm.org/SB-api-coding-rules.html">API Coding rules</a>.</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 11, 2015 at 7:12 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">True that it only needs to be included if it's part of the api.  Are we sure it can't happen through a transitive include?<div><br></div><div>As long as the user of liblldb doesn't see the declaration it shouldn't be a problem.</div></div><br><div class="gmail_quote"><div><div class="h5"><div dir="ltr">On Tue, Aug 11, 2015 at 6:54 PM Chaoren Lin via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">chaoren added a subscriber: chaoren.<br>
chaoren added a comment.<br>
<br>
Sorry! I'll fix this as soon as I get home.<br>
<br>
I have a question though, isn't this only a problem if whatever's linking<br>
against lldb includes this header? This isn't in the API, so that shouldn't<br>
happen. I also don't know if it's correct to label it LLDB_API when it's<br>
not actually part of the API.<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D11967" rel="noreferrer" target="_blank">http://reviews.llvm.org/D11967</a><br>
<br>
<br>
<br></div></div>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>
</blockquote></div><br></div>