<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jul 7, 2015 at 11:25 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="">On Tue, Apr 28, 2015 at 1:55 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br></span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><span>================<br>
Comment at: cmake/LLDBDependencies.cmake:100<br>
@@ +99,3 @@<br>
+if ( CMAKE_SYSTEM_NAME MATCHES "Darwin" )<br>
+  set(LLDB_VERS_GENERATED_FILE ${LLDB_BINARY_DIR}/source/LLDB_vers.c)<br>
+  add_custom_command(OUTPUT ${LLDB_VERS_GENERATED_FILE}<br>
----------------<br>
</span></span><span class=""><span>thakis wrote:<br>
> This doesn't look correct. Now every file that includes LLDBDependencies will have a custom command that builds tools/lldb/source/LLDB_vers.c. With ninja, this causes "ninja: warning: multiple rules generate tools/lldb/source/LLDB_vers.c. builds involving this target will not be correct; continuing anyway" for example (since there's more than one CMakeLists.txt that includes LLDBDependencies.txt).<br>
><br>
> Maybe this rule could stay where it was?<br>
</span></span>Ping? This is still broken 4 months later.<br></blockquote><div><br></div><div>One last ping. If I don't hear back I'll try to fix it myself. </div></div></div></div></blockquote></div><br></div><div class="gmail_extra">I think the right fix is to use add_custom_target for this file rather than add_custom_command.</div><div class="gmail_extra"><br></div><div class="gmail_extra"> - Bruce</div><div class="gmail_extra"><br></div></div>