<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 30, 2015, at 2:58 AM, Pavel Labath <<a href="mailto:labath@google.com" class="">labath@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I would prefer if we were going in the direction of decreasing the number of warnings rather than increasing it</div></div></blockquote><div><br class=""></div><div>Hard to disagree with that one.</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""> (right now, this is the only warning that I get for my build config). Having the default clause in there also sounds reasonable to me, so how about we find a way to suppress this warning without changing semantics?<div class="">option a: cast the switched value to int: this should get rid of the warning in this case..</div></div></div></blockquote><div><br class=""></div><div>If anything, this feels like a hack-around the warning. Given that there is at least a better option, I’d say “nay” personally</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="">option b: compile with -Wno-covered-switch-default: I personally think I could live just fine without this warning</div></div></div></blockquote><div><br class=""></div><div>This would be a good one, IMHO</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="">option c: ???</div><div class=""><br class=""></div></div></div></blockquote><div><br class=""></div><div>None from me. But if anyone has other ideas, now is a good time to share them</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="">pl</div><div class=""><br class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On 29 June 2015 at 23:47, Enrico Granata <span dir="ltr" class=""><<a href="mailto:egranata@apple.com" target="_blank" class="">egranata@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><br class=""><div class=""><span class=""><blockquote type="cite" class=""><div class="">On Jun 29, 2015, at 11:58 AM, Ed Maste <<a href="mailto:emaste@freebsd.org" target="_blank" class="">emaste@freebsd.org</a>> wrote:</div><br class=""><div class=""><div class="">On 29 June 2015 at 14:47, Enrico Granata <<a href="mailto:egranata@apple.com" target="_blank" class="">egranata@apple.com</a>> wrote:<br class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class="">I can see arguments for and against removing the default, but I think<br class="">removing it will cause a new warning to appear if Clang adds other new<br class="">kinds in the future.<br class=""></blockquote><br class="">Yes. And I am slightly more worried about the silent failure when that happens rather than the warning per se - which is why I am hesitant to just say “yes please remove"<br class=""></blockquote><br class="">I mean the warning will prompt us to go and add any new missing enum<br class="">values </div></div></blockquote><div class=""><br class=""></div></span><div class="">Until we’re busy and forget to do it and some builds end up with bugs because of silent fall-through at runtime :-)</div><span class=""><br class=""><blockquote type="cite" class=""><div class=""><div class="">if this happens -- especially if we enable -Werror :)<br class=""></div></div></blockquote><div class=""><br class=""></div></span><div class="">Which I suspect we’re not doing anytime soon</div><span class=""><br class=""><blockquote type="cite" class=""><div class=""><div class=""><br class="">I don't feel too strongly one way or the other, </div></div></blockquote><div class=""><br class=""></div></span><div class="">Likewise. I have a slight preference for keeping the default in there, but only so slight</div><span class=""><br class=""><blockquote type="cite" class=""><div class=""><div class="">but it seems we have<br class="">removed the defaults in all of these cases in the past.</div></div></blockquote></span></div><div class="">
<div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><br class="">Thanks,</div><span class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><i class="">- Enrico</i><br class="">📩 egranata@<font color="#ff2600" class=""></font>.com ☎️ 27683</div>
</span></div>
<br class=""></div><br class="">_______________________________________________<br class="">
lldb-commits mailing list<br class="">
<a href="mailto:lldb-commits@cs.uiuc.edu" class="">lldb-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br class="">
<br class=""></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""><div class="">
<div class="" style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="Apple-interchange-newline">Thanks,</div><div class="" style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><i class="">- Enrico</i><br class="">📩 egranata@<font color="#ff2600" class=""></font>.com ☎️ 27683</div>
</div>
<br class=""></body></html>