<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 24, 2015, at 6:08 PM, Siva Chandra <<a href="mailto:sivachandra@google.com" class="">sivachandra@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">On Wed, Jun 24, 2015 at 12:58 PM, Enrico Granata <<a href="mailto:egranata@apple.com" class="">egranata@apple.com</a>> wrote:<br class=""><blockquote type="cite" class=""><br class="">Try this:<br class="">Sending source/API/SBValue.cpp<br class="">Transmitting file data .<br class="">Committed revision 240578.<br class=""><br class="">It seems to fix your issue for me<br class=""></blockquote><br class="">Yes, it works. Thanks for looking into it promptly.<br class=""></div></div></blockquote><div><br class=""></div><div>Awesome!</div><div>I would like for your repro case to be added as a test case, so that we can catch any future regressions in this area</div><div>If you have a few spare minutes and want to handle that, great; if not I’ll gladly do it tomorrow morning.</div><br class=""><blockquote type="cite" class=""><div class=""><div class=""><br class="">The change makes me think that we always want non-dynamic,<br class="">non-synthetic ValueObject to back a SBValue object while the "flavor"<br class="">of the SBValue is per the user settings. </div></div></blockquote><div><br class=""></div><div>Yes, exactly.</div><div>The invariant is that ValueImpl stores a root ValueObjectSP that is neither dynamic nor synthetic</div><div>This is why I am hesitant to take your other patch - because, yes, it will fix the specific case, but I’d rather much ensure that ValueImpl does the right thing internally.</div><div>Now, it should Just Work in all cases - as the invariant is enforced at construction time.</div><div><br class=""></div><blockquote type="cite" class=""><div class=""><div class="">This seems meaningful now; if<br class="">we are holding on to a SBValue object and change settings, we want the<br class="">behavior of that SBValue object to change according to the settings.<br class=""></div></div></blockquote></div><div class=""><br class=""></div>Exactly. That’s the whole reason to have ValueImpl in the first place.<div class=""><div class="">
<div class="" style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="Apple-interchange-newline">Thanks,</div><div class="" style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><i class="">- Enrico</i><br class="">📩 egranata@<font color="#ff2600" class=""></font>.com ☎️ 27683</div>
</div>
<br class=""></div></body></html>