<div dir="ltr">Adding const modifier makes the class contract stricter and shouldn't break existing clients. <div>In order to make it backward compatible will revert the CL and add new const getters.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 24, 2015 at 9:54 AM, Jim Ingham <span dir="ltr"><<a href="mailto:jingham@apple.com" target="_blank">jingham@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Pavel is right. Our agreement was we wouldn't take anything AWAY from the SB API's. If you want to add a const version, you have to add one, not change an existing API.<br>
<span class="HOEnZb"><font color="#888888"><br>
Jim<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
> On Jun 24, 2015, at 12:43 AM, Pavel Labath <<a href="mailto:labath@google.com">labath@google.com</a>> wrote:<br>
><br>
> Hi,<br>
><br>
> how will this affect the stability of the SB interface? I had a<br>
> feeling we were trying to maintain backward compatibility<br>
> <<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lldb.llvm.org_SB-2Dapi-2Dcoding-2Drules.html&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=fmPIOoDucTBRBuPEvy3kCw1ZJ0MUGMoG4xYLS5QJZEI&s=ESrEuMs--nwdszSEFdPeYdvG-AuelBzqi3Mo1i1u2EA&e=" rel="noreferrer" target="_blank">http://lldb.llvm.org/SB-api-coding-rules.html</a>>? I think a more<br>
> backward compatible solution would be to introduce a new const method<br>
> if you need it and leave the old one intact.<br>
><br>
> pl<br>
><br>
> On 23 June 2015 at 19:21, Oleksiy Vyalov <<a href="mailto:ovyalov@google.com">ovyalov@google.com</a>> wrote:<br>
>> Author: ovyalov<br>
>> Date: Tue Jun 23 13:21:55 2015<br>
>> New Revision: 240435<br>
>><br>
>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D240435-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=fmPIOoDucTBRBuPEvy3kCw1ZJ0MUGMoG4xYLS5QJZEI&s=mw5Anms2EBAQGdSqzEaMgcbKClglhvLmwoiC7BP0ecU&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=240435&view=rev</a><br>
>> Log:<br>
>> Mark SBFrame::GetFunctionName and SBFrame::IsInlined as const.<br>
>><br>
>> Modified:<br>
>> lldb/trunk/include/lldb/API/SBFrame.h<br>
>> lldb/trunk/scripts/interface/SBFrame.i<br>
>> lldb/trunk/source/API/SBFrame.cpp<br>
>><br>
>> Modified: lldb/trunk/include/lldb/API/SBFrame.h<br>
>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_lldb_trunk_include_lldb_API_SBFrame.h-3Frev-3D240435-26r1-3D240434-26r2-3D240435-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=fmPIOoDucTBRBuPEvy3kCw1ZJ0MUGMoG4xYLS5QJZEI&s=Z58UYPMiLsj6uQtVa6CmQB4VNWd6sZdpic2fOfO382U&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBFrame.h?rev=240435&r1=240434&r2=240435&view=diff</a><br>
>> ==============================================================================<br>
>> --- lldb/trunk/include/lldb/API/SBFrame.h (original)<br>
>> +++ lldb/trunk/include/lldb/API/SBFrame.h Tue Jun 23 13:21:55 2015<br>
>> @@ -89,18 +89,18 @@ public:<br>
>> ///<br>
>> /// See also IsInlined().<br>
>> const char *<br>
>> - GetFunctionName();<br>
>> + GetFunctionName() const;<br>
>><br>
>> /// Return true if this frame represents an inlined function.<br>
>> ///<br>
>> /// See also GetFunctionName().<br>
>> bool<br>
>> - IsInlined();<br>
>> + IsInlined() const;<br>
>><br>
>> /// The version that doesn't supply a 'use_dynamic' value will use the<br>
>> /// target's default.<br>
>> lldb::SBValue<br>
>> - EvaluateExpression (const char *expr);<br>
>> + EvaluateExpression (const char *expr);<br>
>><br>
>> lldb::SBValue<br>
>> EvaluateExpression (const char *expr, lldb::DynamicValueType use_dynamic);<br>
>><br>
>> Modified: lldb/trunk/scripts/interface/SBFrame.i<br>
>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_lldb_trunk_scripts_interface_SBFrame.i-3Frev-3D240435-26r1-3D240434-26r2-3D240435-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=fmPIOoDucTBRBuPEvy3kCw1ZJ0MUGMoG4xYLS5QJZEI&s=ThYvzhWlzQgLQeEC-5afONXK_dQjdLixDUM-wRpt-DY&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/interface/SBFrame.i?rev=240435&r1=240434&r2=240435&view=diff</a><br>
>> ==============================================================================<br>
>> --- lldb/trunk/scripts/interface/SBFrame.i (original)<br>
>> +++ lldb/trunk/scripts/interface/SBFrame.i Tue Jun 23 13:21:55 2015<br>
>> @@ -126,7 +126,7 @@ public:<br>
>> /// See also IsInlined().<br>
>> ") GetFunctionName;<br>
>> const char *<br>
>> - GetFunctionName();<br>
>> + GetFunctionName() const;<br>
>><br>
>> %feature("docstring", "<br>
>> /// Return true if this frame represents an inlined function.<br>
>> @@ -134,7 +134,7 @@ public:<br>
>> /// See also GetFunctionName().<br>
>> ") IsInlined;<br>
>> bool<br>
>> - IsInlined();<br>
>> + IsInlined() const;<br>
>><br>
>> %feature("docstring", "<br>
>> /// The version that doesn't supply a 'use_dynamic' value will use the<br>
>><br>
>> Modified: lldb/trunk/source/API/SBFrame.cpp<br>
>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_lldb_trunk_source_API_SBFrame.cpp-3Frev-3D240435-26r1-3D240434-26r2-3D240435-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=fmPIOoDucTBRBuPEvy3kCw1ZJ0MUGMoG4xYLS5QJZEI&s=rbLmr0Z9xLooIRz2R8FuVT8fRRZbF3KhGQELyjelErI&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBFrame.cpp?rev=240435&r1=240434&r2=240435&view=diff</a><br>
>> ==============================================================================<br>
>> --- lldb/trunk/source/API/SBFrame.cpp (original)<br>
>> +++ lldb/trunk/source/API/SBFrame.cpp Tue Jun 23 13:21:55 2015<br>
>> @@ -1499,7 +1499,7 @@ SBFrame::EvaluateExpression (const char<br>
>> }<br>
>><br>
>> bool<br>
>> -SBFrame::IsInlined()<br>
>> +SBFrame::IsInlined() const<br>
>> {<br>
>> Log *log(GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));<br>
>> ExecutionContext exe_ctx(m_opaque_sp.get());<br>
>> @@ -1536,7 +1536,7 @@ SBFrame::IsInlined()<br>
>> }<br>
>><br>
>> const char *<br>
>> -SBFrame::GetFunctionName()<br>
>> +SBFrame::GetFunctionName() const<br>
>> {<br>
>> Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));<br>
>> const char *name = NULL;<br>
>><br>
>><br>
>> _______________________________________________<br>
>> lldb-commits mailing list<br>
>> <a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
> _______________________________________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><span style="color:rgb(85,85,85);font-family:sans-serif;line-height:20px;background-color:rgb(255,255,255);border-width:2px 0px 0px;border-style:solid;border-color:rgb(213,15,37);padding-top:2px;margin-top:2px">Oleksiy Vyalov |</span><span style="color:rgb(85,85,85);font-family:sans-serif;line-height:20px;background-color:rgb(255,255,255);border-width:2px 0px 0px;border-style:solid;border-color:rgb(51,105,232);padding-top:2px;margin-top:2px"> Software Engineer |</span><span style="color:rgb(85,85,85);font-family:sans-serif;line-height:20px;background-color:rgb(255,255,255);border-width:2px 0px 0px;border-style:solid;border-color:rgb(0,153,57);padding-top:2px;margin-top:2px"> <a href="mailto:ovyalov@google.com" target="_blank">ovyalov<font color="#1155cc">@google.com</font></a></span></div></div>
</div>