Looks good <br><div class="gmail_quote">On Thu, Jun 4, 2015 at 10:43 PM Chaoren Lin <<a href="mailto:chaorenl@google.com">chaorenl@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Formatting.<br>
<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10202&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=YfGaxqX13ZIKjVCzdwM9R1iwE3iLNqXStswugzLBxvA&s=9waYwoJESadm8AF9HiK1rvwl_TnLqAZ02vMKNTJQt9A&e=" target="_blank">http://reviews.llvm.org/D10202</a><br>
<br>
Files:<br>
  test/functionalities/tty/TestTerminal.py<br>
  test/macosx/universal/TestUniversal.py<br>
<br>
Index: test/functionalities/tty/TestTerminal.py<br>
===================================================================<br>
--- test/functionalities/tty/TestTerminal.py<br>
+++ test/functionalities/tty/TestTerminal.py<br>
@@ -20,7 +20,8 @@<br>
<br>
     # If the test is being run under sudo, the spawned terminal won't retain that elevated<br>
     # privilege so it can't open the socket to talk back to the test case<br>
-    @unittest2.skipUnless(os.geteuid() != 0, "test cannot be run as root")<br>
+    @unittest2.skipUnless(not hasattr(os, 'geteuid') or os.geteuid() != 0,<br>
+            "test cannot be run as root")<br>
<br>
     # Do we need to disable this test if the testsuite is being run on a remote system?<br>
     # This env var is only defined when the shell is running in a local mac terminal window<br>
Index: test/macosx/universal/TestUniversal.py<br>
===================================================================<br>
--- test/macosx/universal/TestUniversal.py<br>
+++ test/macosx/universal/TestUniversal.py<br>
@@ -18,7 +18,8 @@<br>
<br>
     @python_api_test<br>
     @skipUnlessDarwin<br>
-    @unittest2.skipUnless(os.uname()[4] in ['i386', 'x86_64'], "requires i386 or x86_64")<br>
+    @unittest2.skipUnless(hasattr(os, "uname") and os.uname()[4] in ['i386', 'x86_64'],<br>
+            "requires i386 or x86_64")<br>
     def test_sbdebugger_create_target_with_file_and_target_triple(self):<br>
         """Test the SBDebugger.CreateTargetWithFileAndTargetTriple() API."""<br>
         # Invoke the default build rule.<br>
@@ -36,7 +37,8 @@<br>
         self.assertTrue(process, PROCESS_IS_VALID)<br>
<br>
     @skipUnlessDarwin<br>
-    @unittest2.skipUnless(os.uname()[4] in ['i386', 'x86_64'], "requires i386 or x86_64")<br>
+    @unittest2.skipUnless(hasattr(os, "uname") and os.uname()[4] in ['i386', 'x86_64'],<br>
+            "requires i386 or x86_64")<br>
     def test_process_launch_for_universal(self):<br>
         """Test process launch of a universal binary."""<br>
         from lldbutil import print_registers<br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=YfGaxqX13ZIKjVCzdwM9R1iwE3iLNqXStswugzLBxvA&s=M2gGAHDVWQrq9oAAE8KlF588vVT2RzgJTiojwW8Md98&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</blockquote></div>