<p dir="ltr">It didn't suggest a -Wflag and my reading on this didn't produce one either.</p>
<p dir="ltr">I'm open to suggestions.<br>
</p>
<div class="gmail_quote">On May 27, 2015 2:27 AM, "Pavel Labath" <<a href="mailto:labath@google.com">labath@google.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Wouldn't it be better to disable the warning (-Wno-whatever) instead<br>
of littering the codebase with ifdefs?<br>
<br>
pl<br>
<br>
On 27 May 2015 at 05:54, Vince Harron <<a href="mailto:vince@nethacker.com">vince@nethacker.com</a>> wrote:<br>
> Author: vharron<br>
> Date: Tue May 26 23:54:36 2015<br>
> New Revision: 238283<br>
><br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D238283-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=C-BhxGfyxooK6GnmrbxAh5ygrwOSBnrpTFKUfPo4cmc&s=934tOyrRm_HTi0ePs8Ibm0DaoWKLOrmMkbitJjwwZis&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=238283&view=rev</a><br>
> Log:<br>
> Changed Flags::clang_type_resolve_state to unsigned for gcc<br>
><br>
> to work around a very noisy gcc warning<br>
><br>
><br>
> Modified:<br>
>     lldb/trunk/include/lldb/Symbol/Type.h<br>
><br>
> Modified: lldb/trunk/include/lldb/Symbol/Type.h<br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_lldb_trunk_include_lldb_Symbol_Type.h-3Frev-3D238283-26r1-3D238282-26r2-3D238283-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=C-BhxGfyxooK6GnmrbxAh5ygrwOSBnrpTFKUfPo4cmc&s=iy3vkLz3kqPSRRP-p9d1mz6Gh9w71ssFodjcAqQ4NwY&e=" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Symbol/Type.h?rev=238283&r1=238282&r2=238283&view=diff</a><br>
> ==============================================================================<br>
> --- lldb/trunk/include/lldb/Symbol/Type.h (original)<br>
> +++ lldb/trunk/include/lldb/Symbol/Type.h Tue May 26 23:54:36 2015<br>
> @@ -305,7 +305,12 @@ protected:<br>
>      ClangASTType m_clang_type;<br>
><br>
>      struct Flags {<br>
> +#ifdef __GNUC__<br>
> +        // using unsigned type here to work around a very noisy gcc warning<br>
> +        unsigned        clang_type_resolve_state : 2;<br>
> +#else<br>
>          ResolveState    clang_type_resolve_state : 2;<br>
> +#endif<br>
>          bool            is_complete_objc_class   : 1;<br>
>      } m_flags;<br>
><br>
><br>
><br>
> _______________________________________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>