<div dir="ltr">I think it makes sense to update 64 and 65 as well.</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 27, 2015 at 5:29 PM, Siva Chandra <span dir="ltr"><<a href="mailto:sivachandra@google.com" target="_blank">sivachandra@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">================<br>
Comment at: test/functionalities/data-formatter/data-formatter-stl/libcxx/unordered/TestDataFormatterUnordered.py:66<br>
@@ -65,5 +65,3 @@<br>
</span><span class="">         self.look_for_content_and_continue("mmap",['size=6 {','first = 3','second = "this"','first = 2','second = "hello"'])<br>
-        self.look_for_content_and_continue("iset",['size=5 {','[0] = 5','[2] = 3','[3] = 2'])<br>
-        self.look_for_content_and_continue("sset",['size=5 {','[0] = "is"','[1] = "world"','[4] = "hello"'])<br>
-        self.look_for_content_and_continue("imset",['size=6 {','[0] = 3','[1] = 3','[2] = 3','[4] = 2','[5] = 1'])<br>
-        self.look_for_content_and_continue("smset",['size=5 {','[0] = "is"','[1] = "is"','[2] = "world"','[3] = "world"'])<br>
+        self.look_for_content_and_continue("iset",['size=5 {','\[\d\] = 5','\[\d\] = 3','\[\d\] = 2'])<br>
+        self.look_for_content_and_continue("sset",['size=5 {','\[\d\] = "is"','\[\d\] = "world"','\[\d\] = "hello"'])<br>
</span>----------------<br>
<span class="">chaoren wrote:<br>
> Could you please add a space after each comma for readability? It'd be even nicer if they're all lined up.<br>
</span>I thought about it. If I add spaces here, would be odd if I do not add for lines 64 and 65. However, these lines are beyond the scope of this patch IMO.<br>
<br>
That said, anything for an LGTM: Should I only update 66-69, or all of 64-69?<br>
<div class="HOEnZb"><div class="h5"><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10078&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=VzIA7LkLKdKaEt7dsdFfTSjcJil7dBX3txJW_GUl6wM&s=sYi6Uwg8NxaarHacptnzaDu7EH86dpCI4Dc6oH96yAs&e=" target="_blank">http://reviews.llvm.org/D10078</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=VzIA7LkLKdKaEt7dsdFfTSjcJil7dBX3txJW_GUl6wM&s=rdViT-ep8Z5SFsm9PNZrcO6PYD904Xb2P1mky0SSkaM&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div></div></blockquote></div><br></div>