<div dir="ltr">Sorry for the break, thanks for the fix/lesson.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 21, 2015 at 1:16 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br>
Date: Thu May 21 15:16:02 2015<br>
New Revision: 237946<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D237946-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=2NxioyY0EoyF_pXDBrbC3IJOAuTsVnTa8KBWY2mxCWg&s=F8HvoSmvuZnhdgQar8Pfy8DiblW7QmEvEnc3lTHbXzw&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=237946&view=rev</a><br>
Log:<br>
Don't import module `lock` at global scope.<br>
<br>
`lock` depends on `fcntl`, which doesn't exist on Windows.  Until<br>
someone implements an equivalent locking mechanism on Windows, we<br>
can't have lock imported globally.<br>
<br>
Modified:<br>
    lldb/trunk/test/lldbtest.py<br>
<br>
Modified: lldb/trunk/test/lldbtest.py<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_lldb_trunk_test_lldbtest.py-3Frev-3D237946-26r1-3D237945-26r2-3D237946-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=2NxioyY0EoyF_pXDBrbC3IJOAuTsVnTa8KBWY2mxCWg&s=vNAAdHux-CokxBi3bYVzL9Wfqi9cRef-7sMhMB8T_lU&e=" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lldbtest.py?rev=237946&r1=237945&r2=237946&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/test/lldbtest.py (original)<br>
+++ lldb/trunk/test/lldbtest.py Thu May 21 15:16:02 2015<br>
@@ -33,7 +33,6 @@ $<br>
<br>
 import abc<br>
 import glob<br>
-import lock<br>
 import os, sys, traceback<br>
 import os.path<br>
 import re<br>
@@ -961,6 +960,7 @@ class Base(unittest2.TestCase):<br>
             os.chdir(os.path.join(os.environ["LLDB_TEST"], cls.mydir))<br>
<br>
         if debug_confirm_directory_exclusivity:<br>
+            import lock<br>
             cls.dir_lock = lock.Lock(os.path.join(full_dir, ".dirlock"))<br>
             try:<br>
                 cls.dir_lock.try_acquire()<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
</blockquote></div><br></div>