<div dir="ltr"><div>Hi Jason,</div><div><br></div><div>Unfortunately, this broke watchpoints on Linux.  (I just confirmed by building & testing both this revision and the previous.)</div><div><br></div><div>Do you have any guesses?  Would you like one of us to take a look?</div><div><br></div><div>How do you feel about reverting it to get the build green while it's being investigated?</div><div><br></div><div><a href="http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/2406">http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/2406</a></div><div><br></div><div>Vince</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 14, 2015 at 5:19 PM, Jason Molenda <span dir="ltr"><<a href="mailto:jmolenda@apple.com" target="_blank">jmolenda@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jmolenda<br>
Date: Thu May 14 19:19:28 2015<br>
New Revision: 237411<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=237411&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=237411&view=rev</a><br>
Log:<br>
The StopInfo base class has an m_description std::string.<br>
Remove the m_description ivar from the StopInfoBreakpoint<br>
and StopInfoWatchpoint subclasses of StopInfo.  Also,<br>
initialize the m_description ivar in the StopInfo ctor.<br>
<rdar://problem/20902950><br>
<br>
Modified:<br>
    lldb/trunk/source/Target/StopInfo.cpp<br>
<br>
Modified: lldb/trunk/source/Target/StopInfo.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StopInfo.cpp?rev=237411&r1=237410&r2=237411&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StopInfo.cpp?rev=237411&r1=237410&r2=237411&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/source/Target/StopInfo.cpp (original)<br>
+++ lldb/trunk/source/Target/StopInfo.cpp Thu May 14 19:19:28 2015<br>
@@ -40,6 +40,7 @@ StopInfo::StopInfo (Thread &thread, uint<br>
     m_stop_id (thread.GetProcess()->GetStopID()),<br>
     m_resume_id (thread.GetProcess()->GetResumeID()),<br>
     m_value (value),<br>
+    m_description (),<br>
     m_override_should_notify (eLazyBoolCalculate),<br>
     m_override_should_stop (eLazyBoolCalculate),<br>
     m_extended_info()<br>
@@ -112,7 +113,6 @@ class StopInfoBreakpoint : public StopIn<br>
 public:<br>
     StopInfoBreakpoint (Thread &thread, break_id_t break_id) :<br>
         StopInfo (thread, break_id),<br>
-        m_description(),<br>
         m_should_stop (false),<br>
         m_should_stop_is_valid (false),<br>
         m_should_perform_action (true),<br>
@@ -125,7 +125,6 @@ public:<br>
<br>
     StopInfoBreakpoint (Thread &thread, break_id_t break_id, bool should_stop) :<br>
         StopInfo (thread, break_id),<br>
-        m_description(),<br>
         m_should_stop (should_stop),<br>
         m_should_stop_is_valid (true),<br>
         m_should_perform_action (true),<br>
@@ -568,7 +567,6 @@ protected:<br>
     }<br>
<br>
 private:<br>
-    std::string m_description;<br>
     bool m_should_stop;<br>
     bool m_should_stop_is_valid;<br>
     bool m_should_perform_action; // Since we are trying to preserve the "state" of the system even if we run functions<br>
@@ -621,7 +619,6 @@ public:<br>
<br>
     StopInfoWatchpoint (Thread &thread, break_id_t watch_id) :<br>
         StopInfo(thread, watch_id),<br>
-        m_description(),<br>
         m_should_stop(false),<br>
         m_should_stop_is_valid(false)<br>
     {<br>
@@ -860,7 +857,6 @@ protected:<br>
     }<br>
<br>
 private:<br>
-    std::string m_description;<br>
     bool m_should_stop;<br>
     bool m_should_stop_is_valid;<br>
 };<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
</blockquote></div><br></div>