<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>LGTM<br><br><div style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); "><i>- Enrico</i></div><span style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); ">Sent from my iPhone</span></div><div><br>On May 7, 2015, at 8:15 AM, Pavel Labath <<a href="mailto:labath@google.com">labath@google.com</a>> wrote:<br><br></div><blockquote type="cite"><div><span>Hi granata.enrico, zturner,</span><br><span></span><br><span>This changes lldb_assert to accept bool expressions as the parameter, this is because some</span><br><span>objects (such as std::shared_ptr) are convertible to bool, but are not convertible to int, which</span><br><span>leads to surprising errors.</span><br><span></span><br><span><a href="http://reviews.llvm.org/D9565">http://reviews.llvm.org/D9565</a></span><br><span></span><br><span>Files:</span><br><span> include/lldb/Utility/LLDBAssert.h</span><br><span> source/Utility/LLDBAssert.cpp</span><br><span></span><br><span>Index: include/lldb/Utility/LLDBAssert.h</span><br><span>===================================================================</span><br><span>--- include/lldb/Utility/LLDBAssert.h</span><br><span>+++ include/lldb/Utility/LLDBAssert.h</span><br><span>@@ -20,7 +20,7 @@</span><br><span></span><br><span> namespace lldb_private {</span><br><span> void</span><br><span>- lldb_assert (int expression,</span><br><span>+ lldb_assert (bool expression,</span><br><span> const char* expr_text,</span><br><span> const char* func,</span><br><span> const char* file,</span><br><span>Index: source/Utility/LLDBAssert.cpp</span><br><span>===================================================================</span><br><span>--- source/Utility/LLDBAssert.cpp</span><br><span>+++ source/Utility/LLDBAssert.cpp</span><br><span>@@ -17,7 +17,7 @@</span><br><span> using namespace lldb_private;</span><br><span></span><br><span> void</span><br><span>-lldb_private::lldb_assert (int expression,</span><br><span>+lldb_private::lldb_assert (bool expression,</span><br><span> const char* expr_text,</span><br><span> const char* func,</span><br><span> const char* file,</span><br><span></span><br><span>EMAIL PREFERENCES</span><br><span> <a href="http://reviews.llvm.org/settings/panel/emailpreferences/">http://reviews.llvm.org/settings/panel/emailpreferences/</a></span><br></div></blockquote><blockquote type="cite"><div><D9565.25191.patch></div></blockquote></body></html>