<div dir="ltr">Thanks for the FYI, you beat me to landing the fix :-). In hindsight I see that simple patches which fix build breakages can be landed before review.<br></div><br><div class="gmail_quote">On Wed, Mar 18, 2015 at 4:46 PM Enrico Granata <<a href="mailto:egranata@apple.com">egranata@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>This should be already fixed - see:</div><div>Author: enrico<br>Date: Wed Mar 18 13:42:41 2015<br>New Revision: 232655<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=232655&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=232655&view=rev</a><br>Log:<br>Fix the Xcode build after the MIPS64 changes<br></div><br><div><blockquote type="cite"></blockquote></div></div><div style="word-wrap:break-word"><div><blockquote type="cite"><div>On Mar 18, 2015, at 10:42 AM, Robert Flack <<a href="mailto:flackr@gmail.com" target="_blank">flackr@gmail.com</a>> wrote:</div><br></blockquote></div></div><div style="word-wrap:break-word"><div><blockquote type="cite"><div>Hi clayborg,<br><br>Adds EmulateInstructionMIPS64 to the xcodeproj build so that it's found when linking.<br><br>REPOSITORY<br> rL LLVM<br><br><a href="http://reviews.llvm.org/D8420" target="_blank">http://reviews.llvm.org/D8420</a><br><br>Files:<br> lldb.xcodeproj/project.pbxproj<br><br>Index: lldb.xcodeproj/project.pbxproj<br>===================================================================<br>--- lldb.xcodeproj/project.pbxproj<br>+++ lldb.xcodeproj/project.pbxproj<br>@@ -920,6 +920,7 @@<br> B2B7CCF015D1C20F00EEFB57 /* WatchpointOptions.cpp in Sources */ = {isa = PBXBuildFile; fileRef = B2B7CCEF15D1C20F00EEFB57 <br> E769331C1A94D15400C73337 /* lldb-gdbserver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26D6F3F4183E7F9300194858 /* <br> E769331E1A94D18100C73337 /* lldb-server.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E769331D1A94D18100C73337 /* lld<br>+ E7FA0A8D1AB9EF1000626A5B /* EmulateInstructionMIPS64.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E7FA0A8A1AB9EF1000<br> ED88244E15114A9200BC98B9 /* Security.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = EDB919B414F6F10D008FF64B <br> ED88245015114CA200BC98B9 /* <a href="http://main.mm" target="_blank">main.mm</a> in Sources */ = {isa = PBXBuildFile; fileRef = ED88244F15114CA200BC98B9 /* <a href="http://main.mm" target="_blank">main.mm</a> */;<br> ED88245115114CA200BC98B9 /* <a href="http://main.mm" target="_blank">main.mm</a> in Sources */ = {isa = PBXBuildFile; fileRef = ED88244F15114CA200BC98B9 /* <a href="http://main.mm" target="_blank">main.mm</a> */;<br>@@ -2663,6 +2664,8 @@<br> B2B7CCEF15D1C20F00EEFB57 /* WatchpointOptions.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sour<br> B2D3033612EFA5C500F84EB3 /* InstructionUtils.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcec<br> E769331D1A94D18100C73337 /* lldb-server.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode<br>+ E7FA0A8A1AB9EF1000626A5B /* EmulateInstructionMIPS64.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType<br>+ E7FA0A8B1AB9EF1000626A5B /* EmulateInstructionMIPS64.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =<br> ED88244F15114CA200BC98B9 /* <a href="http://main.mm" target="_blank">main.mm</a> */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.obj<br> ED88245215114CFC00BC98B9 /* LauncherRootXPCService.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = <br> EDB919B214F6EC85008FF64B /* LauncherXPCService.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourc<br>@@ -4608,6 +4611,7 @@<br> 26D9FDCA12F785120003F2EE /* Instruction */ = {<br> isa = PBXGroup;<br> children = (<br>+ E7FA0A881AB9EF1000626A5B /* MIPS64 */,<br> 26D9FDCB12F785270003F2EE /* ARM */,<br> 264A12F91372522000875C42 /* ARM64 */,<br> );<br>@@ -5122,6 +5126,15 @@<br> name = "lldb-server";<br> sourceTree = "<group>";<br> };<br>+ E7FA0A881AB9EF1000626A5B /* MIPS64 */ = {<br>+ isa = PBXGroup;<br>+ children = (<br>+ E7FA0A8A1AB9EF1000626A5B /* EmulateInstructionMIPS64.cpp */,<br>+ E7FA0A8B1AB9EF1000626A5B /* EmulateInstructionMIPS64.h */,<br>+ );<br>+ path = MIPS64;<br>+ sourceTree = "<group>";<br>+ };<br> EDC6D49114E5C15C001B75F8 /* launcherXPCService */ = {<br> isa = PBXGroup;<br> children = (<br>@@ -6143,6 +6156,7 @@<br> 2689010A13353E6F00698AC0 /* ThreadPlanTracer.cpp in Sources */,<br> AF37E10A17C861F20061E18E /* ProcessRunLock.cpp in Sources */,<br> 26474CAA18D0CB070073DEBA /* RegisterContextFreeBSD_mips64.cpp in Sources */,<br>+ E7FA0A8D1AB9EF1000626A5B /* EmulateInstructionMIPS64.cpp in Sources */,<br> 26CA97A1172B1FD5005DC71B /* RegisterContextThreadMemory.cpp in Sources */,<br> 2689010B13353E6F00698AC0 /* ThreadSpec.cpp in Sources */,<br> 2689010C13353E6F00698AC0 /* UnixSignals.cpp in Sources */,<br><br>EMAIL PREFERENCES<br> <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br></div></blockquote></div></div><div style="word-wrap:break-word"><div><blockquote type="cite"><div><span><D8420.22195.patch></span>_______________________________________________<br>lldb-commits mailing list<br><a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br></div></blockquote></div><br><div>
<div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br>Thanks,</div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><i>- Enrico</i><br>📩 egranata@<font color="#ff2600"></font>.com ☎️ 27683</div>
</div>
<br></div></blockquote></div>