<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">I’m a little confused. This patch is for a separate issue; it’s a separate commit. Should it be attached to the review for the other commit?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Zachary Turner [mailto:zturner@google.com]
<br>
<b>Sent:</b> Tuesday, March 10, 2015 4:53 PM<br>
<b>To:</b> reviews+D8238+public+d4d2ef3693b3ed2b@reviews.llvm.org; Chuck Ries; abidh.haq@gmail.com<br>
<b>Cc:</b> lldb-commits@cs.uiuc.edu<br>
<b>Subject:</b> Re: [Lldb-commits] [PATCH] expose 64 bit breakpoint addresses through MI<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Hi Chuck, can you resubmit this patch attached to the other review? The workflow isn't entirely obvious, but there's a couple of things you need to do different.<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">1) When you create the diff with the suggested changes, create the diff against origin (or whatever you created the *original* patch against), not against the first version of the patch. So if HEAD is the first version of the patch you
uploaded, create your diff against HEAD~1. You want the new patch to contain the changes _plus_ the original patch.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">2) When you attach the patch to Phabricator, you'll get a combo box and the default value is "Create new revision". Change this to "Attach to existing revision" and then choose the entry for the first patch you uploaded.<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Tue, Mar 10, 2015 at 4:49 PM Chuck Ries <<a href="mailto:chuckr@microsoft.com">chuckr@microsoft.com</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Hi abidh,<br>
<br>
<a href="http://reviews.llvm.org/D8238" target="_blank">http://reviews.llvm.org/D8238</a><br>
<br>
Files:<br>
tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp<br>
tools/lldb-mi/MICmnLLDBDebugSessionInfo.h<br>
<br>
Index: tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp<br>
===================================================================<br>
--- tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp<br>
+++ tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp<br>
@@ -1048,7 +1048,7 @@<br>
bool<br>
CMICmnLLDBDebugSessionInfo::MIResponseFormBrkPtFrameInfo(const SBrkPtInfo &vrBrkPtInfo, CMICmnMIValueTuple &vwrMiValueTuple)<br>
{<br>
- const CMIUtilString strAddr(CMIUtilString::Format("0x%08llx", vrBrkPtInfo.m_pc));<br>
+ const CMIUtilString strAddr(CMIUtilString::Format("0x%016llx", vrBrkPtInfo.m_pc));<br>
const CMICmnMIValueConst miValueConst2(strAddr);<br>
const CMICmnMIValueResult miValueResult2("addr", miValueConst2);<br>
if (!vwrMiValueTuple.Add(miValueResult2))<br>
Index: tools/lldb-mi/MICmnLLDBDebugSessionInfo.h<br>
===================================================================<br>
--- tools/lldb-mi/MICmnLLDBDebugSessionInfo.h<br>
+++ tools/lldb-mi/MICmnLLDBDebugSessionInfo.h<br>
@@ -87,7 +87,7 @@<br>
CMIUtilString m_strType; // Break point type.<br>
bool m_bDisp; // True = "del", false = "keep".<br>
bool m_bEnabled; // True = enabled, false = disabled break point.<br>
- MIuint m_pc; // Address number.<br>
+ MIuint64 m_pc; // Address number.<br>
CMIUtilString m_fnName; // Function name.<br>
CMIUtilString m_fileName; // File name text.<br>
CMIUtilString m_path; // Full file name and path text.<br>
<br>
EMAIL PREFERENCES<br>
<a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">
http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</body>
</html>