I wasn't aware that the Xcode build did that. I'll update in a bit. I think it's useful to say something about the directory structure though because it lets people know how to update their code. Also will fix the suggestions about line length <br><div class="gmail_quote">On Tue, Mar 10, 2015 at 12:20 PM Jim Ingham <<a href="mailto:jingham@apple.com">jingham@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Couple of comments.<br>
<br>
First off, if you are building with Xcode, you don't need to check out llvm & clang, the build will do that for you if they don't already exist. So for people who want to work on lldb & don't have an extant llvm/clang checkout, it is easier to just check out lldb & build.<br>
<br>
By saying "The line limit IS 120 characters"... "However you will see places" you make it sound like the exceptions are of questionable status, which is not at all the intent. Particularly for these tables, letting them run longer is IMO preferable (there are a few of the tables where the help text wraps & I find those harder to read.) You could say something like:<br>
<br>
The line limit for code statements is...<br>
<br>
Then it would be clearer that this statement does not contradict the immediately following paragraph.<br>
<br>
<br>
<a href="http://reviews.llvm.org/D8222" target="_blank">http://reviews.llvm.org/D8222</a><br>
<br>
EMAIL PREFERENCES<br>
<a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/<u></u>settings/panel/<u></u>emailpreferences/</a><br>
<br>
<br>
</blockquote></div>