<div dir="ltr">As mentioned in the other thread, I think the StreamString thing is kind of irrelevant. The goal here is to get the backtrace to the screen. I would argue the reverse, that we should only be reinventing facilities in LLDB when there's a good reason to do so. In this case, I don't think being able to use a StreamString is a compelling enough reason. On the other hand, having a consistent backtrace format which supports all platforms is definitely a compelling reason to use the LLVM facility. So I do think it makes sense here.<br></div><br><div class="gmail_quote">On Wed, Mar 4, 2015 at 5:12 PM Enrico Granata <<a href="mailto:egranata@apple.com">egranata@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><blockquote type="cite"><div>On Mar 4, 2015, at 4:39 PM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:</div><br><div><div dir="ltr">BTW, I have just uploaded <a href="http://reviews.llvm.org/D8068" target="_blank">http://reviews.llvm.org/D8068</a> to LLVM which implements backtracing of self <span style="font-size:13.1999998092651px;line-height:19.7999992370605px">on Windows </span>(previously only backtracing of other threads was supported). So once that goes through, if we switch this code to using llvm::sys::PrintBacktrace(),</div></div></blockquote><div><br></div></div></div><div style="word-wrap:break-word"><div><div>I don’t think we should make this change.</div><div>Host::Backtrace prints to an lldb_private::Stream which is our preferred API for accumulating output - the LLVM version of this seems to print to a FILE* which is much less general</div><div><br></div><div>I understand using LLVM facilities where it makes sense, but we should not be doing so blindly when the net effect is a loss of functionality for us</div><div><br></div><div>If you can implement Host::Backtrace in general on all platforms via LLVM, feel free to do so - but we should still go through lldb's Host::Backtrace for this, and Host::Backtrace should still use our Stream<i>s</i></div></div></div><div style="word-wrap:break-word"><div><br><blockquote type="cite"><div><div dir="ltr"> we should have a standard backtrace format across all platforms that LLVM supports.<br><div><br></div><div>I like this feature now that I understand the use case, thanks for introducing it.</div></div><br></div></blockquote><div><br></div></div></div><div style="word-wrap:break-word"><div><div>We had a power outage here in Cupertino, which delayed my reply</div><div>Glad to hear we all agree on this :-)</div></div></div><div style="word-wrap:break-word"><div><br><blockquote type="cite"><div><div class="gmail_quote">On Wed, Mar 4, 2015 at 3:31 PM Siva Chandra <<a href="mailto:sivachandra@google.com" target="_blank">sivachandra@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Mar 4, 2015 at 2:59 PM, Enrico Granata <<a href="mailto:egranata@apple.com" target="_blank">egranata@apple.com</a>> wrote:<br>
> +#ifdef LLDB_CONFIGURATION_DEBUG<br>
> +#define lldbassert(x) assert(x)<br>
> +#else<br>
> +#define lldbassert(x) lldb_private::lldb_assert(x, #x, __FUNCTION__, __FILE__, __LINE__)<br>
> +#endif<br>
<br>
Why should we have this ifdef? As in, why shouldn't we use lldb_assert<br>
unconditionally, always (giving us the benefit of backtraces always)?<br>
______________________________<u></u>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/lldb-commits</a><br>
</blockquote></div>
</div></blockquote></div></div><div style="word-wrap:break-word"><div>
<div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div>Thanks,</div><div><i>- Enrico</i><br>📩 egranata@<font color="#ff2600"></font>.com ☎️ 27683</div><div><br></div></div></div></div></div></div><br><br>
</div>
<br></div></blockquote></div>