<div dir="ltr">Ahh I see.  So this is for non fatal errors.  Is there any way we can rely on llvm's self-backtracing mechanism at least?  Not all platforms implement Host::Backtrace(), but llvm has a generic one that should work anywhere, so I think we should get rid of Host::Backtrace() in favor fo that.</div><br><div class="gmail_quote">On Wed, Mar 4, 2015 at 3:13 PM Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Doesn't LLVM already have this functionality built in?  How is this different than writing:<br><br><div>  llvm::sys::PrintStackTraceOnErrorSignal();</div><div>  llvm::PrettyStackTraceProgram X(argc_, argv_);</div><div><br></div><div>in main?</div></div><br><div class="gmail_quote">On Wed, Mar 4, 2015 at 3:06 PM Enrico Granata <<a href="mailto:egranata@apple.com" target="_blank">egranata@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: enrico<br>
Date: Wed Mar  4 16:59:20 2015<br>
New Revision: 231310<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=231310&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>pr<u></u>oject?rev=231310&view=rev</a><br>
Log:<br>
Introduce lldbassert(x)<br>
<br>
We would like it if LLDB never crashed, especially if we never caused LLDB to crash<br>
On the other hand, having assertions can sometimes be useful<br>
<br>
lldbassert(x) is the best of both worlds:<br>
- in debug builds, it turns into a regular assert, which is fine because we don't mind debug LLDB to crash on development machines<br>
- in non-debug builds, it emits a message formatted just like assert(x) would, but then instead of crashing, it dumps a backtrace, suggests filing a bug, and keeps running<br>
<br>
<br>
Added:<br>
    lldb/trunk/include/lldb/<u></u>Utilit<u></u>y/LLDBAssert.h<br>
    lldb/trunk/source/Utility/<u></u>LLDB<u></u>Assert.cpp<br>
Modified:<br>
    lldb/trunk/lldb.xcodeproj/<u></u>proj<u></u>ect.pbxproj<br>
<br>
Added: lldb/trunk/include/lldb/<u></u>Utilit<u></u>y/LLDBAssert.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/LLDBAssert.h?rev=231310&view=auto" target="_blank">http://llvm.org/viewvc/llvm-<u></u>pr<u></u>oject/lldb/trunk/include/<u></u>lldb/<u></u>Utility/LLDBAssert.h?rev=<u></u>23131<u></u>0&view=auto</a><br>
==============================<u></u><u></u>==============================<u></u><u></u>==================<br>
--- lldb/trunk/include/lldb/<u></u>Utilit<u></u>y/LLDBAssert.h (added)<br>
+++ lldb/trunk/include/lldb/<u></u>Utilit<u></u>y/LLDBAssert.h Wed Mar  4 16:59:20 2015<br>
@@ -0,0 +1,30 @@<br>
+//===----------------- LLDBAssert.h ------------------------------<u></u><u></u>--*- C++ -*-===//<br>
+//<br>
+//                     The LLVM Compiler Infrastructure<br>
+//<br>
+// This file is distributed under the University of Illinois Open Source<br>
+// License. See LICENSE.TXT for details.<br>
+//<br>
+//===------------------------<u></u><u></u>------------------------------<u></u><u></u>----------------===//<br>
+<br>
+#ifndef utility_LLDBAssert_h_<br>
+#define utility_LLDBAssert_h_<br>
+<br>
+#include <assert.h><br>
+<br>
+#ifdef LLDB_CONFIGURATION_DEBUG<br>
+#define lldbassert(x) assert(x)<br>
+#else<br>
+#define lldbassert(x) lldb_private::lldb_assert(x, #x, __FUNCTION__, __FILE__, __LINE__)<br>
+#endif<br>
+<br>
+namespace lldb_private {<br>
+    void<br>
+    lldb_assert (int expression,<br>
+                 const char* expr_text,<br>
+                 const char* func,<br>
+                 const char* file,<br>
+                 unsigned int line);<br>
+}<br>
+<br>
+#endif // utility_LLDBAssert_h_<br>
<br>
Modified: lldb/trunk/lldb.xcodeproj/<u></u>proj<u></u>ect.pbxproj<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=231310&r1=231309&r2=231310&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>pr<u></u>oject/lldb/trunk/lldb.<u></u>xcodepro<u></u>j/project.pbxproj?rev=<u></u>231310&<u></u>r1=231309&r2=231310&<u></u>view=diff</a><br>
==============================<u></u><u></u>==============================<u></u><u></u>==================<br>
--- lldb/trunk/lldb.xcodeproj/<u></u>proj<u></u>ect.pbxproj (original)<br>
+++ lldb/trunk/lldb.xcodeproj/<u></u>proj<u></u>ect.pbxproj Wed Mar  4 16:59:20 2015<br>
@@ -770,6 +770,7 @@<br>
                942AFF0719F84C02007B43B4 /* LibCxxInitializerList.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 942AFF0619F84C02007B43B4 /* LibCxxInitializerList.cpp */; };<br>
                94380B8219940B0A00BFE4A8 /* StringLexer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 94380B8119940B0A00BFE4A8 /* StringLexer.cpp */; };<br>
                9439FB1A19EF140C006FD6A4 /* NSIndexPath.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9439FB1919EF140C006FD6A4 /* NSIndexPath.cpp */; };<br>
+               943BDEFE1AA7B2F800789CE8 /* LLDBAssert.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 943BDEFD1AA7B2F800789CE8 /* LLDBAssert.cpp */; };<br>
                944372DC171F6B4300E57C32 /* RegisterContextDummy.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 944372DA171F6B4300E57C32 /* RegisterContextDummy.cpp */; };<br>
                944372DD171F6B4300E57C32 /* RegisterContextDummy.h in Headers */ = {isa = PBXBuildFile; fileRef = 944372DB171F6B4300E57C32 /* RegisterContextDummy.h */; };<br>
                9443B122140C18C40013457C /* SBData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9443B121140C18C10013457C /* SBData.cpp */; };<br>
@@ -2397,6 +2398,8 @@<br>
                94380B8019940B0300BFE4A8 /* StringLexer.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = StringLexer.h; path = include/lldb/Utility/<u></u>StringLex<u></u>er.h; sourceTree = "<group>"; };<br>
                94380B8119940B0A00BFE4A8 /* StringLexer.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = StringLexer.cpp; path = source/Utility/StringLexer.<u></u>cpp<u></u>; sourceTree = "<group>"; };<br>
                9439FB1919EF140C006FD6A4 /* NSIndexPath.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = NSIndexPath.cpp; path = source/DataFormatters/<u></u>NSIndexP<u></u>ath.cpp; sourceTree = "<group>"; };<br>
+               943BDEFC1AA7B2DE00789CE8 /* LLDBAssert.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = LLDBAssert.h; path = include/lldb/Utility/<u></u>LLDBAsser<u></u>t.h; sourceTree = "<group>"; };<br>
+               943BDEFD1AA7B2F800789CE8 /* LLDBAssert.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = LLDBAssert.cpp; path = source/Utility/LLDBAssert.cpp; sourceTree = "<group>"; };<br>
                944372DA171F6B4300E57C32 /* RegisterContextDummy.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = RegisterContextDummy.cpp; path = Utility/RegisterContextDummy.<u></u>c<u></u>pp; sourceTree = "<group>"; };<br>
                944372DB171F6B4300E57C32 /* RegisterContextDummy.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = RegisterContextDummy.h; path = Utility/RegisterContextDummy.<u></u>h<u></u>; sourceTree = "<group>"; };<br>
                9443B120140C18A90013457C /* SBData.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = SBData.h; path = include/lldb/API/SBData.h; sourceTree = "<group>"; };<br>
@@ -3455,6 +3458,8 @@<br>
                                4C73152119B7D71700F865A4 /* Iterable.h */,<br>
                                942829541A89614000521B30 /* JSON.h */,<br>
                                942829551A89614C00521B30 /* JSON.cpp */,<br>
+                               943BDEFC1AA7B2DE00789CE8 /* LLDBAssert.h */,<br>
+                               943BDEFD1AA7B2F800789CE8 /* LLDBAssert.cpp */,<br>
                                26D1804416CEE12500EDFB5B /* KQueue.h */,<br>
                                26D1803C16CEBFD300EDFB5B /* KQueue.cpp */,<br>
                                94031A9F13CF5B3D00DCFF3C /* PriorityPointerPair.h */,<br>
@@ -5946,6 +5951,7 @@<br>
                                2689006413353E0E00698AC0 /* ClangUserExpression.cpp in Sources */,<br>
                                4C3ADCD61810D88B00357218 /* BreakpointResolverFileRegex.<u></u>cp<u></u>p in Sources */,<br>
                                2689006513353E0E00698AC0 /* ClangUtilityFunction.cpp in Sources */,<br>
+                               943BDEFE1AA7B2F800789CE8 /* LLDBAssert.cpp in Sources */,<br>
                                26474CB418D0CB180073DEBA /* RegisterContextLinux_x86_64.<u></u>cp<u></u>p in Sources */,<br>
                                2689006613353E0E00698AC0 /* DWARFExpression.cpp in Sources */,<br>
                                2689006713353E0E00698AC0 /* ASTDumper.cpp in Sources */,<br>
<br>
Added: lldb/trunk/source/Utility/<u></u>LLDB<u></u>Assert.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/LLDBAssert.cpp?rev=231310&view=auto" target="_blank">http://llvm.org/viewvc/llvm-<u></u>pr<u></u>oject/lldb/trunk/source/<u></u>Utilit<u></u>y/LLDBAssert.cpp?rev=<u></u>231310&<u></u>view=auto</a><br>
==============================<u></u><u></u>==============================<u></u><u></u>==================<br>
--- lldb/trunk/source/Utility/<u></u>LLDB<u></u>Assert.cpp (added)<br>
+++ lldb/trunk/source/Utility/<u></u>LLDB<u></u>Assert.cpp Wed Mar  4 16:59:20 2015<br>
@@ -0,0 +1,38 @@<br>
+//===--------------------- LLDBAssert.cpp --------------------------*- C++ -*-===//<br>
+//<br>
+//                     The LLVM Compiler Infrastructure<br>
+//<br>
+// This file is distributed under the University of Illinois Open Source<br>
+// License. See LICENSE.TXT for details.<br>
+//<br>
+//===------------------------<u></u><u></u>------------------------------<u></u><u></u>----------------===//<br>
+<br>
+#include "lldb/Utility/LLDBAssert.h"<br>
+#include "lldb/Core/StreamString.h"<br>
+#include "lldb/Host/Host.h"<br>
+<br>
+using namespace lldb_private;<br>
+<br>
+void<br>
+lldb_private::lldb_assert (int expression,<br>
+                           const char* expr_text,<br>
+                           const char* func,<br>
+                           const char* file,<br>
+                           unsigned int line)<br>
+{<br>
+    if (expression)<br>
+        ;<br>
+    else<br>
+    {<br>
+        StreamString stream;<br>
+        stream.Printf("Assertion failed: (%s), function %s, file %s, line %u\n",<br>
+                      expr_text,<br>
+                      func,<br>
+                      file,<br>
+                      line);<br>
+        stream.Printf("backtrace leading to the failure:\n");<br>
+        Host::Backtrace(stream, 1000);<br>
+        stream.Printf("please file a bug report against lldb reporting this failure log, and as many details as possible\n");<br>
+        printf("%s\n", stream.GetData());<br>
+    }<br>
+}<br>
<br>
<br>
______________________________<u></u><u></u>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailm<u></u>an/listinfo/lldb-commits</a><br>
</blockquote></div></blockquote></div>