<div dir="ltr">Hi,<div>I am travelling and will not be able to review your patch this week. If there are problems in tests on Linux, please disable them on Linux before committing. I will fix/enable them when I am back in office.</div><div><br></div><div>Thanks,</div><div>Abid </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 2, 2015 at 3:22 PM, Ilia K <span dir="ltr"><<a href="mailto:ki.stfu@gmail.com" target="_blank">ki.stfu@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Skip test_lldbmi_stack_info_frame unless Darwin<br>
<span class=""><br>
<br>
<a href="http://reviews.llvm.org/D8004" target="_blank">http://reviews.llvm.org/D8004</a><br>
<br>
Files:<br>
  test/tools/lldb-mi/stack/TestMiStack.py<br>
<br>
Index: test/tools/lldb-mi/stack/TestMiStack.py<br>
===================================================================<br>
--- test/tools/lldb-mi/stack/TestMiStack.py<br>
+++ test/tools/lldb-mi/stack/TestMiStack.py<br>
</span>@@ -197,13 +197,25 @@<br>
<span class="">         self.expect("\^running")<br>
         self.expect("\*stopped,reason=\"breakpoint-hit\"")<br>
<br>
-        # Test stack depth<br>
+        # Test that -stack-info-depth works<br>
+        # (and that max-depth is optional)<br>
         self.runCmd("-stack-info-depth")<br>
         self.expect("\^done,depth=\"[1-9]\"")<br>
<br>
+        # Test that max-depth restricts check of stack depth<br>
+        #FIXME: max-depth argument is ignored<br>
+        self.runCmd("-stack-info-depth 1")<br>
+        #self.expect("\^done,depth=\"1\"")<br>
+<br>
+        # Test that invalid max-depth argument is handled<br>
+        #FIXME: max-depth argument is ignored<br>
+        self.runCmd("-stack-info-depth -1")<br>
+        #self.expect("\^error")<br>
+<br>
     @lldbmi_test<br>
     @expectedFailureWindows("<a href="http://llvm.org/pr22274" target="_blank">llvm.org/pr22274</a>: need a pexpect replacement for windows")<br>
     @skipIfFreeBSD # <a href="http://llvm.org/pr22411" target="_blank">llvm.org/pr22411</a>: Failure presumably due to known thread races<br>
</span>+    @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")<br>
     def test_lldbmi_stack_info_frame(self):<br>
         """Test that 'lldb-mi --interpreter' can show information about current frame."""<br>
<br>
@@ -224,10 +236,23 @@<br>
<div class="HOEnZb"><div class="h5">         self.expect("\^running")<br>
         self.expect("\*stopped,reason=\"breakpoint-hit\"")<br>
<br>
-        # Test that -stack-info-frame works when program is running<br>
+        # Test that -stack-info-frame works when program was stopped on BP<br>
         self.runCmd("-stack-info-frame")<br>
         self.expect("\^done,frame=\{level=\"0\",addr=\".+\",func=\"main\",file=\"main\.cpp\",fullname=\".*main\.cpp\",line=\"\d+\"\}")<br>
<br>
+        # Select frame #1<br>
+        self.runCmd("-stack-select-frame 1")<br>
+        self.expect("\^done")<br>
+<br>
+        # Test that -stack-info-frame works when specified frame was selected<br>
+        self.runCmd("-stack-info-frame")<br>
+        self.expect("\^done,frame=\{level=\"1\",addr=\".+\",func=\".+\",file=\"\?\?\",fullname=\"\?\?\",line=\"-1\"\}")<br>
+<br>
+        # Test that -stack-info-frame fails when an argument is specified<br>
+        #FIXME: unknown argument is ignored<br>
+        self.runCmd("-stack-info-frame unknown_arg")<br>
+        #self.expect("\^error")<br>
+<br>
     @lldbmi_test<br>
     @expectedFailureWindows("<a href="http://llvm.org/pr22274" target="_blank">llvm.org/pr22274</a>: need a pexpect replacement for windows")<br>
     @skipIfFreeBSD # <a href="http://llvm.org/pr22411" target="_blank">llvm.org/pr22411</a>: Failure presumably due to known thread races<br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</div></div></blockquote></div><br></div>