<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div><blockquote type="cite" class=""><div class="">On Feb 17, 2015, at 9:59 AM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I reverted the revert</div></div></blockquote><div><br class=""></div><div>Thanks!</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""> because it caused other problems which I didn't see at first. In the future please try to add new files to CMakeLists.txt. </div></div></blockquote><div><br class=""></div><div>I think we had this same conversation a couple of times and we got to the point where people who use a specific build system would fix build problems specific to that build system</div><div>Sure, if it is as easy-peasy as adding a file to a list I can probably do it (provided I remember) but given the low low penalty bar for forgetting (a random bot somewhere may fail sometime in the future), it does seem a fairly error-prone process anyway</div><div>Anyway, if we want to change the consensus from what it was to “anyone has to fix any build system” that’s fine - but it should be changed explicitly</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">We shoudln't be letting red bots linger for any significant amount of time</div></div></blockquote><div><br class=""></div><div>I really don’t think I got a failure notice for this one - with that said, your statement is a truism, so no objection there</div><div>Obviously, a non-trivial failure on Windows is going to be quite hard for me to diagnose without external help (I have access to exactly 0 Windows machines :-), so please do escalate these to my attention when they happen</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">, because it masks other failures (such as the lldb-mi failure I now have to figure out independently which was masked by the already-red bot due to this change)<br class=""></div><br class=""><div class="gmail_quote">On Tue Feb 17 2015 at 9:45:33 AM Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Hi Enrico,<br class=""><br class="">I had to revert this as it has been causing linker errors on our Windows bots since last Thursday.<br class=""><div class=""><br class=""></div><div class=""><a href="http://lab.llvm.org:8011/builders/lldb-x86-win7-msvc/builds/725" target="_blank" class="">http://lab.llvm.org:8011/builders/lldb-x86-win7-msvc/builds/725</a><br class=""></div><div class=""><br class=""></div><div class="">There was a merge conflict with the xcode workspace, I hope I resolved it correctly. Sorry about this revert. I believe the bots sent out failure messages, but please let me know if you did not receive one for whatever reason.</div></div><br class=""><div class="gmail_quote">On Thu Feb 12 2015 at 3:24:04 PM Enrico Granata <<a href="mailto:egranata@apple.com" target="_blank" class="">egranata@apple.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: enrico<br class="">
Date: Thu Feb 12 17:09:17 2015<br class="">
New Revision: 228975<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=228975&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject?rev=228975&view=rev</a><br class="">
Log:<br class="">
I had recently added a new SBFrame::GetVariables() overload with yet another bool argument<br class="">
<br class="">
We talked about it internally - and came to the conclusion that it's time to have an options class<br class="">
<br class="">
This commit adds an SBVariablesOptions class and goes through all the required dance<br class="">
<br class="">
Added:<br class="">
lldb/trunk/include/lldb/API/<u class=""></u>SB<u class=""></u>VariablesOptions.h<br class="">
lldb/trunk/scripts/Python/<u class=""></u>inte<u class=""></u>rface/SBVariablesOptions.i<br class="">
lldb/trunk/source/API/<u class=""></u>SBVariab<u class=""></u>lesOptions.cpp<br class="">
Removed:<br class="">
lldb/trunk/test/<u class=""></u>functionalitie<u class=""></u>s/data-<u class=""></u>formatter/typedef_<u class=""></u>array/<u class=""></u>Makefile<br class="">
Modified:<br class="">
lldb/trunk/include/lldb/API/<u class=""></u>LL<u class=""></u>DB.h<br class="">
lldb/trunk/include/lldb/API/<u class=""></u>SB<u class=""></u>Defines.h<br class="">
lldb/trunk/include/lldb/API/<u class=""></u>SB<u class=""></u>Frame.h<br class="">
lldb/trunk/lldb.xcodeproj/<u class=""></u>proj<u class=""></u>ect.pbxproj<br class="">
lldb/trunk/scripts/Python/<u class=""></u>buil<u class=""></u>d-swig-Python.sh<br class="">
lldb/trunk/scripts/Python/<u class=""></u>inte<u class=""></u>rface/SBFrame.i<br class="">
lldb/trunk/scripts/lldb.swig<br class="">
lldb/trunk/source/API/<u class=""></u>CMakeLis<u class=""></u>ts.txt<br class="">
lldb/trunk/source/API/SBFrame.<u class=""></u><u class=""></u>cpp<br class="">
<br class="">
Modified: lldb/trunk/include/lldb/API/<u class=""></u>LL<u class=""></u>DB.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/LLDB.h?rev=228975&r1=228974&r2=228975&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject/lldb/trunk/include/<u class=""></u>lldb/<u class=""></u>API/LLDB.h?rev=228975&r1=<u class=""></u>22897<u class=""></u>4&r2=228975&view=diff</a><br class="">
==============================<u class=""></u><u class=""></u>==============================<u class=""></u><u class=""></u>==================<br class="">
--- lldb/trunk/include/lldb/API/<u class=""></u>LL<u class=""></u>DB.h (original)<br class="">
+++ lldb/trunk/include/lldb/API/<u class=""></u>LL<u class=""></u>DB.h Thu Feb 12 17:09:17 2015<br class="">
@@ -52,5 +52,6 @@<br class="">
#include "lldb/API/SBType.h"<br class="">
#include "lldb/API/SBValue.h"<br class="">
#include "lldb/API/SBValueList.h"<br class="">
+#include "lldb/API/SBVariablesOptions.<u class=""></u>h<u class=""></u>"<br class="">
<br class="">
#endif // LLDB_LLDB_h_<br class="">
<br class="">
Modified: lldb/trunk/include/lldb/API/<u class=""></u>SB<u class=""></u>Defines.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBDefines.h?rev=228975&r1=228974&r2=228975&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject/lldb/trunk/include/<u class=""></u>lldb/<u class=""></u>API/SBDefines.h?rev=<u class=""></u>228975&r1=<u class=""></u>228974&r2=228975&<u class=""></u>view=diff</a><br class="">
==============================<u class=""></u><u class=""></u>==============================<u class=""></u><u class=""></u>==================<br class="">
--- lldb/trunk/include/lldb/API/<u class=""></u>SB<u class=""></u>Defines.h (original)<br class="">
+++ lldb/trunk/include/lldb/API/<u class=""></u>SB<u class=""></u>Defines.h Thu Feb 12 17:09:17 2015<br class="">
@@ -90,6 +90,7 @@ class LLDB_API SBTypeSynthetic;<br class="">
class LLDB_API SBTypeList;<br class="">
class LLDB_API SBValue;<br class="">
class LLDB_API SBValueList;<br class="">
+class LLDB_API SBVariablesOptions;<br class="">
class LLDB_API SBWatchpoint;<br class="">
class LLDB_API SBUnixSignals;<br class="">
<br class="">
<br class="">
Modified: lldb/trunk/include/lldb/API/<u class=""></u>SB<u class=""></u>Frame.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBFrame.h?rev=228975&r1=228974&r2=228975&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject/lldb/trunk/include/<u class=""></u>lldb/<u class=""></u>API/SBFrame.h?rev=228975&<u class=""></u>r1=<u class=""></u>228974&r2=228975&view=diff</a><br class="">
==============================<u class=""></u><u class=""></u>==============================<u class=""></u><u class=""></u>==================<br class="">
--- lldb/trunk/include/lldb/API/<u class=""></u>SB<u class=""></u>Frame.h (original)<br class="">
+++ lldb/trunk/include/lldb/API/<u class=""></u>SB<u class=""></u>Frame.h Thu Feb 12 17:09:17 2015<br class="">
@@ -157,12 +157,7 @@ public:<br class="">
lldb::DynamicValueType use_dynamic);<br class="">
<br class="">
lldb::SBValueList<br class="">
- GetVariables (bool arguments,<br class="">
- bool locals,<br class="">
- bool statics,<br class="">
- bool in_scope_only,<br class="">
- bool include_runtime_support_<u class=""></u>values<u class=""></u>,<br class="">
- lldb::DynamicValueType use_dynamic);<br class="">
+ GetVariables (const lldb::SBVariablesOptions& options);<br class="">
<br class="">
lldb::SBValueList<br class="">
GetRegisters ();<br class="">
<br class="">
Added: lldb/trunk/include/lldb/API/<u class=""></u>SB<u class=""></u>VariablesOptions.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBVariablesOptions.h?rev=228975&view=auto" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject/lldb/trunk/include/<u class=""></u>lldb/<u class=""></u>API/SBVariablesOptions.h?<u class=""></u>rev=<u class=""></u>228975&view=auto</a><br class="">
==============================<u class=""></u><u class=""></u>==============================<u class=""></u><u class=""></u>==================<br class="">
--- lldb/trunk/include/lldb/API/<u class=""></u>SB<u class=""></u>VariablesOptions.h (added)<br class="">
+++ lldb/trunk/include/lldb/API/<u class=""></u>SB<u class=""></u>VariablesOptions.h Thu Feb 12 17:09:17 2015<br class="">
@@ -0,0 +1,98 @@<br class="">
+//===-- SBVariablesOptions.h ------------------------------<u class=""></u><u class=""></u>------------*- C++ -*-===//<br class="">
+//<br class="">
+// The LLVM Compiler Infrastructure<br class="">
+//<br class="">
+// This file is distributed under the University of Illinois Open Source<br class="">
+// License. See LICENSE.TXT for details.<br class="">
+//<br class="">
+//===------------------------<u class=""></u><u class=""></u>------------------------------<u class=""></u><u class=""></u>----------------===//<br class="">
+<br class="">
+#ifndef LLDB_SBVariablesOptions_h_<br class="">
+#define LLDB_SBVariablesOptions_h_<br class="">
+<br class="">
+#include "lldb/API/SBDefines.h"<br class="">
+<br class="">
+class VariablesOptionsImpl;<br class="">
+<br class="">
+namespace lldb {<br class="">
+<br class="">
+class SBVariablesOptions<br class="">
+{<br class="">
+public:<br class="">
+ SBVariablesOptions ();<br class="">
+<br class="">
+ SBVariablesOptions (const SBVariablesOptions& options);<br class="">
+<br class="">
+ SBVariablesOptions&<br class="">
+ operator = (const SBVariablesOptions& options);<br class="">
+<br class="">
+ ~SBVariablesOptions ();<br class="">
+<br class="">
+ bool<br class="">
+ IsValid () const;<br class="">
+<br class="">
+ bool<br class="">
+ GetIncludeArguments () const;<br class="">
+<br class="">
+ void<br class="">
+ SetIncludeArguments (bool);<br class="">
+<br class="">
+ bool<br class="">
+ GetIncludeLocals () const;<br class="">
+<br class="">
+ void<br class="">
+ SetIncludeLocals (bool);<br class="">
+<br class="">
+ bool<br class="">
+ GetIncludeStatics () const;<br class="">
+<br class="">
+ void<br class="">
+ SetIncludeStatics (bool);<br class="">
+<br class="">
+ bool<br class="">
+ GetInScopeOnly () const;<br class="">
+<br class="">
+ void<br class="">
+ SetInScopeOnly (bool);<br class="">
+<br class="">
+ bool<br class="">
+ GetIncludeRuntimeSupportValues () const;<br class="">
+<br class="">
+ void<br class="">
+ SetIncludeRuntimeSupportValues (bool);<br class="">
+<br class="">
+ lldb::DynamicValueType<br class="">
+ GetUseDynamic () const;<br class="">
+<br class="">
+ void<br class="">
+ SetUseDynamic (lldb::DynamicValueType);<br class="">
+<br class="">
+protected:<br class="">
+ VariablesOptionsImpl *<br class="">
+ operator->();<br class="">
+<br class="">
+ const VariablesOptionsImpl *<br class="">
+ operator->() const;<br class="">
+<br class="">
+ VariablesOptionsImpl *<br class="">
+ get ();<br class="">
+<br class="">
+ VariablesOptionsImpl &<br class="">
+ ref();<br class="">
+<br class="">
+ const VariablesOptionsImpl &<br class="">
+ ref() const;<br class="">
+<br class="">
+ SBVariablesOptions (VariablesOptionsImpl *lldb_object_ptr);<br class="">
+<br class="">
+ void<br class="">
+ SetOptions (VariablesOptionsImpl *lldb_object_ptr);<br class="">
+<br class="">
+private:<br class="">
+<br class="">
+ std::unique_ptr<<u class=""></u>VariablesOptio<u class=""></u>nsImpl> m_opaque_ap;<br class="">
+};<br class="">
+<br class="">
+} // namespace lldb<br class="">
+<br class="">
+#endif // LLDB_SBValue_h_<br class="">
<br class="">
Modified: lldb/trunk/lldb.xcodeproj/<u class=""></u>proj<u class=""></u>ect.pbxproj<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=228975&r1=228974&r2=228975&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject/lldb/trunk/lldb.<u class=""></u>xcodepro<u class=""></u>j/project.pbxproj?rev=<u class=""></u>228975&<u class=""></u>r1=228974&r2=228975&<u class=""></u>view=diff</a><br class="">
==============================<u class=""></u><u class=""></u>==============================<u class=""></u><u class=""></u>==================<br class="">
--- lldb/trunk/lldb.xcodeproj/<u class=""></u>proj<u class=""></u>ect.pbxproj (original)<br class="">
+++ lldb/trunk/lldb.xcodeproj/<u class=""></u>proj<u class=""></u>ect.pbxproj Thu Feb 12 17:09:17 2015<br class="">
@@ -765,6 +765,8 @@<br class="">
941BCC8014E48C4000BB969C /* SBTypeFormat.h in Headers */ = {isa = PBXBuildFile; fileRef = 9461568714E355F2003A195C /* SBTypeFormat.h */; settings = {ATTRIBUTES = (Public, ); }; };<br class="">
941BCC8114E48C4000BB969C /* SBTypeSummary.h in Headers */ = {isa = PBXBuildFile; fileRef = 9461568814E355F2003A195C /* SBTypeSummary.h */; settings = {ATTRIBUTES = (Public, ); }; };<br class="">
941BCC8214E48C4000BB969C /* SBTypeSynthetic.h in Headers */ = {isa = PBXBuildFile; fileRef = 9461568914E355F2003A195C /* SBTypeSynthetic.h */; settings = {ATTRIBUTES = (Public, ); }; };<br class="">
+ 94235B9E1A8D667400EB2EED /* SBVariablesOptions.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 94235B9B1A8D5FF300EB2EED /* SBVariablesOptions.cpp */; };<br class="">
+ 94235B9F1A8D66D600EB2EED /* SBVariablesOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 94235B9A1A8D5FD800EB2EED /* SBVariablesOptions.h */; settings = {ATTRIBUTES = (Public, ); }; };<br class="">
942829561A89614C00521B30 /* JSON.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 942829551A89614C00521B30 /* JSON.cpp */; };<br class="">
942829CC1A89839300521B30 /* liblldb-core.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 2689FFCA13353D7A00698AC0 /* liblldb-core.a */; };<br class="">
942AFF0519F84ABF007B43B4 /* LibCxxVector.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 942AFF0419F84ABF007B43B4 /* LibCxxVector.cpp */; };<br class="">
@@ -2400,6 +2402,9 @@<br class="">
940B04DE1A8986070045D5F7 /* libncurses.dylib */ = {isa = PBXFileReference; lastKnownFileType = "compiled.mach-o.dylib"; name = libncurses.dylib; path = Platforms/MacOSX.platform/<u class=""></u>Deve<u class=""></u>loper/SDKs/MacOSX10.10.<u class=""></u>sdk/<u class=""></u>usr/lib/libncurses.dylib; sourceTree = DEVELOPER_DIR; };<br class="">
940B04E01A89860E0045D5F7 /* libedit.dylib */ = {isa = PBXFileReference; lastKnownFileType = "compiled.mach-o.dylib"; name = libedit.dylib; path = Platforms/MacOSX.platform/<u class=""></u>Deve<u class=""></u>loper/SDKs/MacOSX10.10.<u class=""></u>sdk/<u class=""></u>usr/lib/libedit.dylib; sourceTree = DEVELOPER_DIR; };<br class="">
94145430175D7FDE00284436 /* lldb-versioning.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = "lldb-versioning.h"; path = "include/lldb/lldb-versioning.<u class=""></u><u class=""></u>h"; sourceTree = "<group>"; };<br class="">
+ 94235B9A1A8D5FD800EB2EED /* SBVariablesOptions.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = SBVariablesOptions.h; path = include/lldb/API/<u class=""></u>SBVariablesOp<u class=""></u>tions.h; sourceTree = "<group>"; };<br class="">
+ 94235B9B1A8D5FF300EB2EED /* SBVariablesOptions.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = SBVariablesOptions.cpp; path = source/API/SBVariablesOptions.<u class=""></u><u class=""></u>cpp; sourceTree = "<group>"; };<br class="">
+ 94235B9D1A8D601A00EB2EED /* SBVariablesOptions.i */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.c.preprocessed; path = SBVariablesOptions.i; sourceTree = "<group>"; };<br class="">
942829541A89614000521B30 /* JSON.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = JSON.h; path = include/lldb/Utility/JSON.h; sourceTree = "<group>"; };<br class="">
942829551A89614C00521B30 /* JSON.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSON.cpp; path = source/Utility/JSON.cpp; sourceTree = "<group>"; };<br class="">
942829C01A89835300521B30 /* argdumper */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; path = argdumper; sourceTree = BUILT_PRODUCTS_DIR; };<br class="">
@@ -3176,6 +3181,7 @@<br class="">
9461569514E3567F003A195C /* SBTypeSynthetic.i */,<br class="">
2611FF12142D83060017FEA3 /* SBValue.i */,<br class="">
2611FF13142D83060017FEA3 /* SBValueList.i */,<br class="">
+ 94235B9D1A8D601A00EB2EED /* SBVariablesOptions.i */,<br class="">
B2A5872514313B480092BFBA /* SBWatchpoint.i */,<br class="">
);<br class="">
name = interface;<br class="">
@@ -3194,8 +3200,6 @@<br class="">
262D3190111B4341004E6F88 /* API */ = {<br class="">
isa = PBXGroup;<br class="">
children = (<br class="">
- 254FBB961A81B03100BD6378 /* SBLaunchInfo.h */,<br class="">
- 254FBB941A81AA7F00BD6378 /* SBLaunchInfo.cpp */,<br class="">
2611FEEE142D83060017FEA3 /* interface */,<br class="">
26BC7C2510F1B3BC00F91463 /* lldb-defines.h */,<br class="">
26BC7C2610F1B3BC00F91463 /* lldb-enumerations.h */,<br class="">
@@ -3251,6 +3255,8 @@<br class="">
9AC703AE117675410086C050 /* SBInstruction.cpp */,<br class="">
9AC7038F117675270086C050 /* SBInstructionList.h */,<br class="">
9AC703B0117675490086C050 /* SBInstructionList.cpp */,<br class="">
+ 254FBB961A81B03100BD6378 /* SBLaunchInfo.h */,<br class="">
+ 254FBB941A81AA7F00BD6378 /* SBLaunchInfo.cpp */,<br class="">
26DE205811618FE700A093E2 /* SBLineEntry.h */,<br class="">
26DE20621161904200A093E2 /* SBLineEntry.cpp */,<br class="">
9A9831021125FC5800A56CB0 /* SBListener.h */,<br class="">
@@ -3311,6 +3317,8 @@<br class="">
9A19A6AD1163BB9800E0D453 /* SBValue.cpp */,<br class="">
9A357582116CFDEE00E8ED2F /* SBValueList.h */,<br class="">
9A35758D116CFE0F00E8ED2F /* SBValueList.cpp */,<br class="">
+ 94235B9A1A8D5FD800EB2EED /* SBVariablesOptions.h */,<br class="">
+ 94235B9B1A8D5FF300EB2EED /* SBVariablesOptions.cpp */,<br class="">
B2A58721143119810092BFBA /* SBWatchpoint.h */,<br class="">
B2A58723143119D50092BFBA /* SBWatchpoint.cpp */,<br class="">
);<br class="">
@@ -5214,6 +5222,7 @@<br class="">
26D265A2136B40EE002EEE45 /* SharingPtr.h in Headers */,<br class="">
26D265BC136B4269002EEE45 /* lldb-public.h in Headers */,<br class="">
4CE4F673162C971A00F75CB3 /* SBExpressionOptions.h in Headers */,<br class="">
+ 94235B9F1A8D66D600EB2EED /* SBVariablesOptions.h in Headers */,<br class="">
23EFE389193D1ABC00E54E54 /* SBTypeEnumMember.h in Headers */,<br class="">
);<br class="">
runOnlyForDeploymentPostproces<u class=""></u><u class=""></u>sing = 0;<br class="">
@@ -5813,6 +5822,7 @@<br class="">
9AC703AF117675410086C050 /* SBInstruction.cpp in Sources */,<br class="">
9AC703B1117675490086C050 /* SBInstructionList.cpp in Sources */,<br class="">
268F9D55123AA16600B91E9B /* SBSymbolContextList.cpp in Sources */,<br class="">
+ 94235B9E1A8D667400EB2EED /* SBVariablesOptions.cpp in Sources */,<br class="">
26C72C961243229A0068DC16 /* SBStream.cpp in Sources */,<br class="">
9443B122140C18C40013457C /* SBData.cpp in Sources */,<br class="">
4CF52AF8142829390051E832 /* SBFileSpecList.cpp in Sources */,<br class="">
<br class="">
Modified: lldb/trunk/scripts/Python/<u class=""></u>buil<u class=""></u>d-swig-Python.sh<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/Python/build-swig-Python.sh?rev=228975&r1=228974&r2=228975&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject/lldb/trunk/scripts/<u class=""></u>Pytho<u class=""></u>n/build-swig-Python.sh?<u class=""></u>rev=<u class=""></u>228975&r1=228974&r2=<u class=""></u>228975&<u class=""></u>view=diff</a><br class="">
==============================<u class=""></u><u class=""></u>==============================<u class=""></u><u class=""></u>==================<br class="">
--- lldb/trunk/scripts/Python/<u class=""></u>buil<u class=""></u>d-swig-Python.sh (original)<br class="">
+++ lldb/trunk/scripts/Python/<u class=""></u>buil<u class=""></u>d-swig-Python.sh Thu Feb 12 17:09:17 2015<br class="">
@@ -126,6 +126,7 @@ HEADER_FILES="${SRC_ROOT}/<u class=""></u>incl<u class=""></u>ude/lldb/l<br class="">
" ${SRC_ROOT}/include/lldb/API/<u class=""></u>S<u class=""></u>BTypeSynthetic.h"\<br class="">
" ${SRC_ROOT}/include/lldb/API/<u class=""></u>S<u class=""></u>BValue.h"\<br class="">
" ${SRC_ROOT}/include/lldb/API/<u class=""></u>S<u class=""></u>BValueList.h"\<br class="">
+" ${SRC_ROOT}/include/lldb/API/<u class=""></u>S<u class=""></u>BVariablesOptions.h"\<br class="">
" ${SRC_ROOT}/include/lldb/API/<u class=""></u>S<u class=""></u>BWatchpoint.h"\<br class="">
" ${SRC_ROOT}/include/lldb/API/<u class=""></u>S<u class=""></u>BUnixSignals.h"<br class="">
<br class="">
@@ -178,6 +179,7 @@ INTERFACE_FILES="${SRC_ROOT}/<u class=""></u>s<u class=""></u>cripts/Pyt<br class="">
" ${SRC_ROOT}/scripts/Python/<u class=""></u>int<u class=""></u>erface/SBTypeSynthetic.i"\<br class="">
" ${SRC_ROOT}/scripts/Python/<u class=""></u>int<u class=""></u>erface/SBValue.i"\<br class="">
" ${SRC_ROOT}/scripts/Python/<u class=""></u>int<u class=""></u>erface/SBValueList.i"\<br class="">
+" ${SRC_ROOT}/scripts/Python/<u class=""></u>int<u class=""></u>erface/SBVariablesOptions.<u class=""></u>i"\<br class="">
" ${SRC_ROOT}/scripts/Python/<u class=""></u>int<u class=""></u>erface/SBWatchpoint.i"\<br class="">
" ${SRC_ROOT}/scripts/Python/<u class=""></u>int<u class=""></u>erface/SBUnixSignals.i"<br class="">
<br class="">
<br class="">
Modified: lldb/trunk/scripts/Python/<u class=""></u>inte<u class=""></u>rface/SBFrame.i<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/Python/interface/SBFrame.i?rev=228975&r1=228974&r2=228975&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject/lldb/trunk/scripts/<u class=""></u>Pytho<u class=""></u>n/interface/SBFrame.i?<u class=""></u>rev=<u class=""></u>228975&r1=228974&r2=<u class=""></u>228975&<u class=""></u>view=diff</a><br class="">
==============================<u class=""></u><u class=""></u>==============================<u class=""></u><u class=""></u>==================<br class="">
--- lldb/trunk/scripts/Python/<u class=""></u>inte<u class=""></u>rface/SBFrame.i (original)<br class="">
+++ lldb/trunk/scripts/Python/<u class=""></u>inte<u class=""></u>rface/SBFrame.i Thu Feb 12 17:09:17 2015<br class="">
@@ -199,12 +199,7 @@ public:<br class="">
lldb::DynamicValueType use_dynamic);<br class="">
<br class="">
lldb::SBValueList<br class="">
- GetVariables (bool arguments,<br class="">
- bool locals,<br class="">
- bool statics,<br class="">
- bool in_scope_only,<br class="">
- bool include_runtime_support_<u class=""></u>values<u class=""></u>,<br class="">
- lldb::DynamicValueType use_dynamic);<br class="">
+ GetVariables (const lldb::SBVariablesOptions& options);<br class="">
<br class="">
lldb::SBValueList<br class="">
GetRegisters ();<br class="">
<br class="">
Added: lldb/trunk/scripts/Python/<u class=""></u>inte<u class=""></u>rface/SBVariablesOptions.i<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/Python/interface/SBVariablesOptions.i?rev=228975&view=auto" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject/lldb/trunk/scripts/<u class=""></u>Pytho<u class=""></u>n/interface/<u class=""></u>SBVariablesOptions<u class=""></u>.i?rev=<u class=""></u>228975&view=auto</a><br class="">
==============================<u class=""></u><u class=""></u>==============================<u class=""></u><u class=""></u>==================<br class="">
--- lldb/trunk/scripts/Python/<u class=""></u>inte<u class=""></u>rface/SBVariablesOptions.i (added)<br class="">
+++ lldb/trunk/scripts/Python/<u class=""></u>inte<u class=""></u>rface/SBVariablesOptions.i Thu Feb 12 17:09:17 2015<br class="">
@@ -0,0 +1,61 @@<br class="">
+//===-- SWIG Interface for SBVariablesOptions ----------------------*- C++ -*-===//<br class="">
+//<br class="">
+// The LLVM Compiler Infrastructure<br class="">
+//<br class="">
+// This file is distributed under the University of Illinois Open Source<br class="">
+// License. See LICENSE.TXT for details.<br class="">
+//<br class="">
+//===------------------------<u class=""></u><u class=""></u>------------------------------<u class=""></u><u class=""></u>----------------===//<br class="">
+<br class="">
+namespace lldb {<br class="">
+<br class="">
+class SBVariablesOptions<br class="">
+{<br class="">
+public:<br class="">
+ SBVariablesOptions ();<br class="">
+<br class="">
+ SBVariablesOptions (const SBVariablesOptions& options);<br class="">
+<br class="">
+ ~SBVariablesOptions ();<br class="">
+<br class="">
+ bool<br class="">
+ IsValid () const;<br class="">
+<br class="">
+ bool<br class="">
+ GetIncludeArguments () const;<br class="">
+<br class="">
+ void<br class="">
+ SetIncludeArguments (bool);<br class="">
+<br class="">
+ bool<br class="">
+ GetIncludeLocals () const;<br class="">
+<br class="">
+ void<br class="">
+ SetIncludeLocals (bool);<br class="">
+<br class="">
+ bool<br class="">
+ GetIncludeStatics () const;<br class="">
+<br class="">
+ void<br class="">
+ SetIncludeStatics (bool);<br class="">
+<br class="">
+ bool<br class="">
+ GetInScopeOnly () const;<br class="">
+<br class="">
+ void<br class="">
+ SetInScopeOnly (bool);<br class="">
+<br class="">
+ bool<br class="">
+ GetIncludeRuntimeSupportValues () const;<br class="">
+<br class="">
+ void<br class="">
+ SetIncludeRuntimeSupportValues (bool);<br class="">
+<br class="">
+ lldb::DynamicValueType<br class="">
+ GetUseDynamic () const;<br class="">
+<br class="">
+ void<br class="">
+ SetUseDynamic (lldb::DynamicValueType);<br class="">
+};<br class="">
+<br class="">
+} // namespace lldb<br class="">
<br class="">
Modified: lldb/trunk/scripts/lldb.swig<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/lldb.swig?rev=228975&r1=228974&r2=228975&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject/lldb/trunk/scripts/<u class=""></u>lldb.<u class=""></u>swig?rev=228975&r1=<u class=""></u>228974&r2=<u class=""></u>228975&view=diff</a><br class="">
==============================<u class=""></u><u class=""></u>==============================<u class=""></u><u class=""></u>==================<br class="">
--- lldb/trunk/scripts/lldb.swig (original)<br class="">
+++ lldb/trunk/scripts/lldb.swig Thu Feb 12 17:09:17 2015<br class="">
@@ -105,6 +105,7 @@ import os<br class="">
#include "lldb/API/SBTypeSynthetic.h"<br class="">
#include "lldb/API/SBValue.h"<br class="">
#include "lldb/API/SBValueList.h"<br class="">
+#include "lldb/API/SBVariablesOptions.<u class=""></u>h<u class=""></u>"<br class="">
#include "lldb/API/SBWatchpoint.h"<br class="">
#include "lldb/API/SBUnixSignals.h"<br class="">
<br class="">
@@ -180,6 +181,7 @@ import os<br class="">
%include "./Python/interface/<u class=""></u>SBTypeSynt<u class=""></u>hetic.i"<br class="">
%include "./Python/interface/SBValue.i"<br class="">
%include "./Python/interface/<u class=""></u>SBValueLis<u class=""></u>t.i"<br class="">
+%include "./Python/interface/<u class=""></u>SBVariable<u class=""></u>sOptions.i"<br class="">
%include "./Python/interface/<u class=""></u>SBWatchpoi<u class=""></u>nt.i"<br class="">
%include "./Python/interface/<u class=""></u>SBUnixSign<u class=""></u>als.i"<br class="">
<br class="">
<br class="">
Modified: lldb/trunk/source/API/<u class=""></u>CMakeLis<u class=""></u>ts.txt<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/CMakeLists.txt?rev=228975&r1=228974&r2=228975&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject/lldb/trunk/source/API/<u class=""></u>CM<u class=""></u>akeLists.txt?rev=228975&r1=<u class=""></u>228<u class=""></u>974&r2=228975&view=diff</a><br class="">
==============================<u class=""></u><u class=""></u>==============================<u class=""></u><u class=""></u>==================<br class="">
--- lldb/trunk/source/API/<u class=""></u>CMakeLis<u class=""></u>ts.txt (original)<br class="">
+++ lldb/trunk/source/API/<u class=""></u>CMakeLis<u class=""></u>ts.txt Thu Feb 12 17:09:17 2015<br class="">
@@ -57,6 +57,7 @@ add_lldb_library(lldbAPI<br class="">
SBTypeSynthetic.cpp<br class="">
SBValue.cpp<br class="">
SBValueList.cpp<br class="">
+ SBVariablesOptions.cpp<br class="">
SBWatchpoint.cpp<br class="">
SBUnixSignals.cpp<br class="">
)<br class="">
<br class="">
Modified: lldb/trunk/source/API/SBFrame.<u class=""></u><u class=""></u>cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBFrame.cpp?rev=228975&r1=228974&r2=228975&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject/lldb/trunk/source/API/<u class=""></u>SB<u class=""></u>Frame.cpp?rev=228975&r1=<u class=""></u>228974<u class=""></u>&r2=228975&view=diff</a><br class="">
==============================<u class=""></u><u class=""></u>==============================<u class=""></u><u class=""></u>==================<br class="">
--- lldb/trunk/source/API/SBFrame.<u class=""></u><u class=""></u>cpp (original)<br class="">
+++ lldb/trunk/source/API/SBFrame.<u class=""></u><u class=""></u>cpp Thu Feb 12 17:09:17 2015<br class="">
@@ -44,6 +44,7 @@<br class="">
#include "lldb/API/SBStream.h"<br class="">
#include "lldb/API/SBSymbolContext.h"<br class="">
#include "lldb/API/SBThread.h"<br class="">
+#include "lldb/API/SBVariablesOptions.<u class=""></u>h<u class=""></u>"<br class="">
<br class="">
using namespace lldb;<br class="">
using namespace lldb_private;<br class="">
@@ -1075,7 +1076,17 @@ SBFrame::GetVariables (bool arguments,<br class="">
if (frame && target)<br class="">
{<br class="">
lldb::DynamicValueType use_dynamic = frame->CalculateTarget()-><u class=""></u>GetP<u class=""></u>referDynamicValue();<br class="">
- value_list = GetVariables (arguments, locals, statics, in_scope_only, use_dynamic);<br class="">
+ const bool include_runtime_support_values = target ? target-><u class=""></u>GetDisplayRuntimeSuppo<u class=""></u>rtValues<u class=""></u>() : false;<br class="">
+<br class="">
+ SBVariablesOptions options;<br class="">
+ options.SetIncludeArguments(<u class=""></u>ar<u class=""></u>guments);<br class="">
+ options.SetIncludeLocals(<u class=""></u>local<u class=""></u>s);<br class="">
+ options.SetIncludeStatics(<u class=""></u>stat<u class=""></u>ics);<br class="">
+ options.SetInScopeOnly(in_<u class=""></u>scop<u class=""></u>e_only);<br class="">
+ options.<u class=""></u>SetIncludeRuntimeSuppo<u class=""></u>rtValues<u class=""></u>(include_runtime_<u class=""></u>support_<u class=""></u>values);<br class="">
+ options.SetUseDynamic(use_<u class=""></u>dyna<u class=""></u>mic);<br class="">
+<br class="">
+ value_list = GetVariables (options);<br class="">
}<br class="">
return value_list;<br class="">
}<br class="">
@@ -1089,22 +1100,19 @@ SBFrame::GetVariables (bool arguments,<br class="">
{<br class="">
ExecutionContext exe_ctx(m_opaque_sp.get());<br class="">
Target *target = exe_ctx.GetTargetPtr();<br class="">
- bool include_runtime_support_values = target ? target-><u class=""></u>GetDisplayRuntimeSuppo<u class=""></u>rtValues<u class=""></u>() : false;<br class="">
- return GetVariables(arguments,<br class="">
- locals,<br class="">
- statics,<br class="">
- in_scope_only,<br class="">
- include_runtime_support_<u class=""></u>values<u class=""></u>,<br class="">
- use_dynamic);<br class="">
+ const bool include_runtime_support_values = target ? target-><u class=""></u>GetDisplayRuntimeSuppo<u class=""></u>rtValues<u class=""></u>() : false;<br class="">
+ SBVariablesOptions options;<br class="">
+ options.SetIncludeArguments(<u class=""></u>ar<u class=""></u>guments);<br class="">
+ options.SetIncludeLocals(<u class=""></u>local<u class=""></u>s);<br class="">
+ options.SetIncludeStatics(<u class=""></u>stat<u class=""></u>ics);<br class="">
+ options.SetInScopeOnly(in_<u class=""></u>scop<u class=""></u>e_only);<br class="">
+ options.<u class=""></u>SetIncludeRuntimeSuppo<u class=""></u>rtValues<u class=""></u>(include_runtime_<u class=""></u>support_<u class=""></u>values);<br class="">
+ options.SetUseDynamic(use_<u class=""></u>dyna<u class=""></u>mic);<br class="">
+ return GetVariables(options);<br class="">
}<br class="">
<br class="">
SBValueList<br class="">
-SBFrame::GetVariables (bool arguments,<br class="">
- bool locals,<br class="">
- bool statics,<br class="">
- bool in_scope_only,<br class="">
- bool include_runtime_support_<u class=""></u>values<u class=""></u>,<br class="">
- lldb::DynamicValueType use_dynamic)<br class="">
+SBFrame::GetVariables (const lldb::SBVariablesOptions& options)<br class="">
{<br class="">
Log *log(GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));<br class="">
<br class="">
@@ -1115,10 +1123,19 @@ SBFrame::GetVariables (bool arguments,<br class="">
StackFrame *frame = NULL;<br class="">
Target *target = exe_ctx.GetTargetPtr();<br class="">
<br class="">
+ const bool statics = options.GetIncludeStatics();<br class="">
+ const bool arguments = options.GetIncludeArguments();<br class="">
+ const bool locals = options.GetIncludeLocals();<br class="">
+ const bool in_scope_only = options.GetInScopeOnly();<br class="">
+ const bool include_runtime_support_values = options.<u class=""></u>GetIncludeRuntimeSuppo<u class=""></u>rtValues<u class=""></u>();<br class="">
+ const lldb::DynamicValueType use_dynamic = options.GetUseDynamic();<br class="">
+<br class="">
if (log)<br class="">
- log->Printf ("SBFrame::GetVariables (arguments=%i, locals=%i, statics=%i, in_scope_only=%i)",<br class="">
- arguments, locals, statics, in_scope_only);<br class="">
-<br class="">
+ log->Printf ("SBFrame::GetVariables (arguments=%i, locals=%i, statics=%i, in_scope_only=%i runtime=%i dynamic=%i)",<br class="">
+ arguments, locals,<br class="">
+ statics, in_scope_only,<br class="">
+ include_runtime_support_<u class=""></u>value<u class=""></u>s, use_dynamic);<br class="">
+<br class="">
Process *process = exe_ctx.GetProcessPtr();<br class="">
if (target && process)<br class="">
{<br class="">
<br class="">
Added: lldb/trunk/source/API/<u class=""></u>SBVariab<u class=""></u>lesOptions.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBVariablesOptions.cpp?rev=228975&view=auto" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject/lldb/trunk/source/API/<u class=""></u>SB<u class=""></u>VariablesOptions.cpp?rev=<u class=""></u>22897<u class=""></u>5&view=auto</a><br class="">
==============================<u class=""></u><u class=""></u>==============================<u class=""></u><u class=""></u>==================<br class="">
--- lldb/trunk/source/API/<u class=""></u>SBVariab<u class=""></u>lesOptions.cpp (added)<br class="">
+++ lldb/trunk/source/API/<u class=""></u>SBVariab<u class=""></u>lesOptions.cpp Thu Feb 12 17:09:17 2015<br class="">
@@ -0,0 +1,254 @@<br class="">
+//===-- SBVariablesOptions.cpp ------------------------------<u class=""></u><u class=""></u>--------*- C++ -*-===//<br class="">
+//<br class="">
+// The LLVM Compiler Infrastructure<br class="">
+//<br class="">
+// This file is distributed under the University of Illinois Open Source<br class="">
+// License. See LICENSE.TXT for details.<br class="">
+//<br class="">
+//===------------------------<u class=""></u><u class=""></u>------------------------------<u class=""></u><u class=""></u>----------------===//<br class="">
+<br class="">
+<br class="">
+#include "lldb/API/SBVariablesOptions.<u class=""></u>h<u class=""></u>"<br class="">
+<br class="">
+using namespace lldb;<br class="">
+using namespace lldb_private;<br class="">
+<br class="">
+class VariablesOptionsImpl<br class="">
+{<br class="">
+public:<br class="">
+ VariablesOptionsImpl () :<br class="">
+ m_include_arguments(false),<br class="">
+ m_include_locals(false),<br class="">
+ m_include_statics(false),<br class="">
+ m_in_scope_only(false),<br class="">
+ m_include_runtime_support_<u class=""></u>valu<u class=""></u>es(false),<br class="">
+ m_use_dynamic(lldb::<u class=""></u>eNoDynamic<u class=""></u>Values)<br class="">
+ {}<br class="">
+<br class="">
+ VariablesOptionsImpl (const VariablesOptionsImpl&) = default;<br class="">
+<br class="">
+ ~VariablesOptionsImpl () = default;<br class="">
+<br class="">
+ VariablesOptionsImpl&<br class="">
+ operator = (const VariablesOptionsImpl&) = default;<br class="">
+<br class="">
+ bool<br class="">
+ GetIncludeArguments () const<br class="">
+ {<br class="">
+ return m_include_arguments;<br class="">
+ }<br class="">
+<br class="">
+ void<br class="">
+ SetIncludeArguments (bool b)<br class="">
+ {<br class="">
+ m_include_arguments = b;<br class="">
+ }<br class="">
+<br class="">
+ bool<br class="">
+ GetIncludeLocals () const<br class="">
+ {<br class="">
+ return m_include_locals;<br class="">
+ }<br class="">
+<br class="">
+ void<br class="">
+ SetIncludeLocals (bool b)<br class="">
+ {<br class="">
+ m_include_locals = b;<br class="">
+ }<br class="">
+<br class="">
+ bool<br class="">
+ GetIncludeStatics () const<br class="">
+ {<br class="">
+ return m_include_statics;<br class="">
+ }<br class="">
+<br class="">
+ void<br class="">
+ SetIncludeStatics (bool b)<br class="">
+ {<br class="">
+ m_include_statics = b;<br class="">
+ }<br class="">
+<br class="">
+ bool<br class="">
+ GetInScopeOnly () const<br class="">
+ {<br class="">
+ return m_in_scope_only;<br class="">
+ }<br class="">
+<br class="">
+ void<br class="">
+ SetInScopeOnly (bool b)<br class="">
+ {<br class="">
+ m_in_scope_only = b;<br class="">
+ }<br class="">
+<br class="">
+ bool<br class="">
+ GetIncludeRuntimeSupportValues () const<br class="">
+ {<br class="">
+ return m_include_runtime_support_<u class=""></u>valu<u class=""></u>es;<br class="">
+ }<br class="">
+<br class="">
+ void<br class="">
+ SetIncludeRuntimeSupportValues (bool b)<br class="">
+ {<br class="">
+ m_include_runtime_support_<u class=""></u>valu<u class=""></u>es = b;<br class="">
+ }<br class="">
+<br class="">
+ lldb::DynamicValueType<br class="">
+ GetUseDynamic () const<br class="">
+ {<br class="">
+ return m_use_dynamic;<br class="">
+ }<br class="">
+<br class="">
+ void<br class="">
+ SetUseDynamic (lldb::DynamicValueType d)<br class="">
+ {<br class="">
+ m_use_dynamic = d;<br class="">
+ }<br class="">
+<br class="">
+<br class="">
+private:<br class="">
+ bool m_include_arguments : 1;<br class="">
+ bool m_include_locals : 1;<br class="">
+ bool m_include_statics : 1;<br class="">
+ bool m_in_scope_only : 1;<br class="">
+ bool m_include_runtime_support_<u class=""></u>valu<u class=""></u>es : 1;<br class="">
+ lldb::DynamicValueType m_use_dynamic;<br class="">
+};<br class="">
+<br class="">
+SBVariablesOptions::<u class=""></u>SBVariabl<u class=""></u>esOptions () :<br class="">
+m_opaque_ap(new VariablesOptionsImpl())<br class="">
+{<br class="">
+}<br class="">
+<br class="">
+SBVariablesOptions::<u class=""></u>SBVariabl<u class=""></u>esOptions (const SBVariablesOptions& options) :<br class="">
+m_opaque_ap(new VariablesOptionsImpl(options.<u class=""></u>r<u class=""></u>ef()))<br class="">
+{<br class="">
+}<br class="">
+<br class="">
+SBVariablesOptions&<br class="">
+SBVariablesOptions::operator = (const SBVariablesOptions& options)<br class="">
+{<br class="">
+ m_opaque_ap.reset(new VariablesOptionsImpl(options.<u class=""></u>r<u class=""></u>ef()));<br class="">
+ return *this;<br class="">
+}<br class="">
+<br class="">
+SBVariablesOptions::~<u class=""></u>SBVariab<u class=""></u>lesOptions () = default;<br class="">
+<br class="">
+bool<br class="">
+SBVariablesOptions::IsValid () const<br class="">
+{<br class="">
+ return m_opaque_ap.get() != nullptr;<br class="">
+}<br class="">
+<br class="">
+bool<br class="">
+SBVariablesOptions::<u class=""></u>GetInclud<u class=""></u>eArguments () const<br class="">
+{<br class="">
+ return m_opaque_ap-><u class=""></u>GetIncludeArgumen<u class=""></u>ts();<br class="">
+}<br class="">
+<br class="">
+void<br class="">
+SBVariablesOptions::<u class=""></u>SetInclud<u class=""></u>eArguments (bool arguments)<br class="">
+{<br class="">
+ m_opaque_ap-><u class=""></u>SetIncludeArgumen<u class=""></u>ts(arguments)<u class=""></u>;<br class="">
+}<br class="">
+<br class="">
+bool<br class="">
+SBVariablesOptions::<u class=""></u>GetInclud<u class=""></u>eLocals () const<br class="">
+{<br class="">
+ return m_opaque_ap->GetIncludeLocals(<u class=""></u><u class=""></u>);<br class="">
+}<br class="">
+<br class="">
+void<br class="">
+SBVariablesOptions::<u class=""></u>SetInclud<u class=""></u>eLocals (bool locals)<br class="">
+{<br class="">
+ m_opaque_ap->SetIncludeLocals(<u class=""></u><u class=""></u>locals);<br class="">
+}<br class="">
+<br class="">
+bool<br class="">
+SBVariablesOptions::<u class=""></u>GetInclud<u class=""></u>eStatics () const<br class="">
+{<br class="">
+ return m_opaque_ap-><u class=""></u>GetIncludeStatics<u class=""></u>();<br class="">
+}<br class="">
+<br class="">
+void<br class="">
+SBVariablesOptions::<u class=""></u>SetInclud<u class=""></u>eStatics (bool statics)<br class="">
+{<br class="">
+ m_opaque_ap-><u class=""></u>SetIncludeStatics<u class=""></u>(statics);<br class="">
+}<br class="">
+<br class="">
+bool<br class="">
+SBVariablesOptions::<u class=""></u>GetInScop<u class=""></u>eOnly () const<br class="">
+{<br class="">
+ return m_opaque_ap->GetInScopeOnly();<br class="">
+}<br class="">
+<br class="">
+void<br class="">
+SBVariablesOptions::<u class=""></u>SetInScop<u class=""></u>eOnly (bool in_scope_only)<br class="">
+{<br class="">
+ m_opaque_ap->SetInScopeOnly(<u class=""></u>in<u class=""></u>_scope_only);<br class="">
+}<br class="">
+<br class="">
+bool<br class="">
+SBVariablesOptions::<u class=""></u>GetInclud<u class=""></u>eRuntimeSupportValues () const<br class="">
+{<br class="">
+ return m_opaque_ap-><u class=""></u>GetIncludeRuntime<u class=""></u>SupportValues<u class=""></u>();<br class="">
+}<br class="">
+<br class="">
+void<br class="">
+SBVariablesOptions::<u class=""></u>SetInclud<u class=""></u>eRuntimeSupportValues (bool runtime_support_values)<br class="">
+{<br class="">
+ m_opaque_ap-><u class=""></u>SetIncludeRuntime<u class=""></u>SupportValues<u class=""></u>(runtime_support_<u class=""></u>values);<br class="">
+}<br class="">
+<br class="">
+lldb::DynamicValueType<br class="">
+SBVariablesOptions::<u class=""></u>GetUseDyn<u class=""></u>amic () const<br class="">
+{<br class="">
+ return m_opaque_ap->GetUseDynamic();<br class="">
+}<br class="">
+<br class="">
+void<br class="">
+SBVariablesOptions::<u class=""></u>SetUseDyn<u class=""></u>amic (lldb::DynamicValueType dynamic)<br class="">
+{<br class="">
+ m_opaque_ap->SetUseDynamic(<u class=""></u>dyn<u class=""></u>amic);<br class="">
+}<br class="">
+<br class="">
+VariablesOptionsImpl *<br class="">
+SBVariablesOptions::operator-<u class=""></u><u class=""></u>>()<br class="">
+{<br class="">
+ return m_opaque_ap.operator->();<br class="">
+}<br class="">
+<br class="">
+const VariablesOptionsImpl *<br class="">
+SBVariablesOptions::operator-<u class=""></u><u class=""></u>>() const<br class="">
+{<br class="">
+ return m_opaque_ap.operator->();<br class="">
+}<br class="">
+<br class="">
+VariablesOptionsImpl *<br class="">
+SBVariablesOptions::get ()<br class="">
+{<br class="">
+ return m_opaque_ap.get();<br class="">
+}<br class="">
+<br class="">
+VariablesOptionsImpl &<br class="">
+SBVariablesOptions::ref()<br class="">
+{<br class="">
+ return *m_opaque_ap;<br class="">
+}<br class="">
+<br class="">
+const VariablesOptionsImpl &<br class="">
+SBVariablesOptions::ref() const<br class="">
+{<br class="">
+ return *m_opaque_ap;<br class="">
+}<br class="">
+<br class="">
+SBVariablesOptions::<u class=""></u>SBVariabl<u class=""></u>esOptions (VariablesOptionsImpl *lldb_object_ptr) :<br class="">
+m_opaque_ap(std::move(lldb_<u class=""></u>ob<u class=""></u>ject_ptr))<br class="">
+{<br class="">
+}<br class="">
+<br class="">
+void<br class="">
+SBVariablesOptions::<u class=""></u>SetOption<u class=""></u>s (VariablesOptionsImpl *lldb_object_ptr)<br class="">
+{<br class="">
+ m_opaque_ap.reset(std::move(<u class=""></u>ll<u class=""></u>db_object_ptr));<br class="">
+}<br class="">
+<br class="">
<br class="">
Removed: lldb/trunk/test/<u class=""></u>functionalitie<u class=""></u>s/data-<u class=""></u>formatter/typedef_<u class=""></u>array/<u class=""></u>Makefile<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/data-formatter/typedef_array/Makefile?rev=228974&view=auto" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>pr<u class=""></u>oject/lldb/trunk/test/<u class=""></u>function<u class=""></u>alities/data-<u class=""></u>formatter/<u class=""></u>typedef_array/<u class=""></u>Makefile?rev=<u class=""></u>228974&view=auto</a><br class="">
==============================<u class=""></u><u class=""></u>==============================<u class=""></u><u class=""></u>==================<br class="">
--- lldb/trunk/test/<u class=""></u>functionalitie<u class=""></u>s/data-<u class=""></u>formatter/typedef_<u class=""></u>array/<u class=""></u>Makefile (original)<br class="">
+++ lldb/trunk/test/<u class=""></u>functionalitie<u class=""></u>s/data-<u class=""></u>formatter/typedef_<u class=""></u>array/<u class=""></u>Makefile (removed)<br class="">
@@ -1,4 +0,0 @@<br class="">
-LEVEL = ../../../make<br class="">
-CXX_SOURCES := main.cpp<br class="">
-CXXFLAGS += -std=c++11<br class="">
-include $(LEVEL)/Makefile.rules<br class="">
<br class="">
<br class="">
______________________________<u class=""></u><u class=""></u>_________________<br class="">
lldb-commits mailing list<br class="">
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank" class="">lldb-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank" class="">http://lists.cs.uiuc.edu/<u class=""></u>mailm<u class=""></u>an/listinfo/lldb-commits</a><br class="">
</blockquote></div></blockquote></div>
</div></blockquote></div><br class=""><div class="">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Thanks,</div><div class=""><i class="">- Enrico</i><br class="">📩 egranata@<font color="#ff2600" class=""></font>.com ☎️ 27683</div><div class=""><br class=""></div></div></div></div></div></div><br class="Apple-interchange-newline"><br class="Apple-interchange-newline">
</div>
<br class=""></body></html>