<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Lgtm<br><br><div style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); "><i>- Enrico</i></div><span style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); ">Sent from my iPhone</span></div><div><br>On Feb 11, 2015, at 6:40 AM, Tamas Berghammer <<a href="mailto:tberghammer@google.com">tberghammer@google.com</a>> wrote:<br><br></div><blockquote type="cite"><div><span>Hi granata.enrico,</span><br><span></span><br><span>Add missing check for LLDB_DISABLE_PYTHON in FormatManager</span><br><span></span><br><span>Without the check the build fails if LLDB_DISABLE_PYTHON is defined because AddCXXSummary not exist.</span><br><span>I don't know what is this code doing, so please check if this patch make sense.</span><br><span></span><br><span><a href="http://reviews.llvm.org/D7558">http://reviews.llvm.org/D7558</a></span><br><span></span><br><span>Files:</span><br><span> source/DataFormatters/FormatManager.cpp</span><br><span></span><br><span>Index: source/DataFormatters/FormatManager.cpp</span><br><span>===================================================================</span><br><span>--- source/DataFormatters/FormatManager.cpp</span><br><span>+++ source/DataFormatters/FormatManager.cpp</span><br><span>@@ -1579,7 +1579,9 @@</span><br><span></span><br><span> TypeCategoryImpl::SharedPointer cm_category_sp = GetCategory(m_coremedia_category_name);</span><br><span></span><br><span>+#ifndef LLDB_DISABLE_PYTHON</span><br><span> AddCXXSummary(cm_category_sp, lldb_private::formatters::CMTimeSummaryProvider, "CMTime summary provider", ConstString("CMTime"), cm_flags);</span><br><span>+#endif // LLDB_DISABLE_PYTHON</span><br><span> }</span><br><span></span><br><span> void</span><br><span></span><br><span>EMAIL PREFERENCES</span><br><span> <a href="http://reviews.llvm.org/settings/panel/emailpreferences/">http://reviews.llvm.org/settings/panel/emailpreferences/</a></span><br></div></blockquote><blockquote type="cite"><div><D7558.19750.patch></div></blockquote></body></html>