<div dir="ltr">lgtm<br></div><br><div class="gmail_quote">On Wed Feb 04 2015 at 2:50:00 PM Robert Flack <<a href="mailto:flackr@gmail.com">flackr@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">REPOSITORY<br>
  rL LLVM<br>
<br>
================<br>
Comment at: source/Host/posix/PipePosix.<u></u>cpp:196<br>
@@ +195,3 @@<br>
+    llvm::SmallString<PATH_MAX> named_pipe_path;<br>
+    llvm::SmallString<PATH_MAX> pipe_spec;<br>
+    pipe_spec = prefix;<br>
----------------<br>
ovyalov wrote:<br>
> Is it possible to combine all 3 statements of pipe_spec initialization? I mean, sth like this - const llvm::SmallString<PATH_MAX> pipe_spec (prefix + ".%%%%%%") ;<br>
Ish:<br>
llvm::SmallString<PATH_MAX> pipe_spec((prefix + ".%%%%%%").str());<br>
Done.<br>
<br>
================<br>
Comment at: source/Host/posix/PipePosix.<u></u>cpp:236<br>
@@ -198,1 +235,3 @@<br>
+    {<br>
+        m_name = name;<br>
         m_fds[READ] = fd;<br>
----------------<br>
ovyalov wrote:<br>
> For the sake of consistency, please set the name within PipePosix::<u></u>OpenAsWriterWithTimeout as well - before m_fds[WRITE] = fd;<br>
No longer relevant, name is now returned as out param in CreateWithUniqueName.<br>
<br>
<a href="http://reviews.llvm.org/D7348" target="_blank">http://reviews.llvm.org/D7348</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/<u></u>settings/panel/<u></u>emailpreferences/</a><br>
<br>
<br>
</blockquote></div>