<p dir="ltr">Looks like I got my diff backwards *blush*<br>
</p>
<div class="gmail_quote">On Jan 28, 2015 9:44 AM, "Oleksiy Vyalov" <<a href="mailto:ovyalov@google.com">ovyalov@google.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Please see my comments.<br>
<br>
<br>
REPOSITORY<br>
  rL LLVM<br>
<br>
================<br>
Comment at: source/Commands/CommandObjectPlatform.cpp:2284<br>
@@ -2283,2 +2283,3 @@<br>
     LoadSubCommand ("settings", CommandObjectSP (new CommandObjectPlatformSettings (interpreter)));<br>
+#ifdef LLDB_CONFIGURATION_DEBUG<br>
     LoadSubCommand ("mkdir", CommandObjectSP (new CommandObjectPlatformMkDir (interpreter)));<br>
----------------<br>
Why we don't need mkdir.. put-file commands in non-debug configurations?<br>
<br>
================<br>
Comment at: test/types/AbstractBase.py:53<br>
@@ -52,3 +52,3 @@<br>
     # bc -> blockCaptured (defaulted to False)                                 #<br>
-    #         True: testing vars of various basic types from inside a block    #<br>
+    #         True: testing vars of various basic types from isnide a block    #<br>
     #         False: testing vars of various basic types from a function       #<br>
----------------<br>
inside?<br>
<br>
================<br>
Comment at: test/types/AbstractBase.py:91<br>
@@ -90,7 +90,3 @@<br>
         # series of printf statements.<br>
-<br>
-        # process launch command output redirect always goes to host the process is running on<br>
-        self.runCmd('process launch -o /tmp/golden-output.txt')<br>
-        # if this is a remote test, get-file will copy it back over, else it will just copy<br>
-        self.runCmd('platform get-file /tmp/golden-output.txt "%s"'%(self.golden_filename))<br>
+        self.runCmd('process launch -o "%s"'%(self.golden_filename))<br>
         with open(self.golden_filename) as f:<br>
----------------<br>
You may use "platform process launch" here in order to make it work either locally or remotely.<br>
<br>
<a href="http://reviews.llvm.org/D7221" target="_blank">http://reviews.llvm.org/D7221</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</blockquote></div>