I reverted this because it was breaking other stuff <br><div class="gmail_quote">On Wed, Jan 21, 2015 at 12:09 PM Rick Foos <<a href="mailto:rfoos@codeaurora.org">rfoos@codeaurora.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">fyi, For some reason, this makes the python library path case sensitive on Windows.<br>
<br>
My system had C:\src\Python. The source dir was C:\src\python, causing the failure below.<br>
<br>
No big deal, just an fyi, I renamed the directory on the buildslave and happiness.<br>
<br>
-rick<br>
<br>
Copying PYTHON_DEBUG_LIBRARY-NOTFOUND to C:/buildbots/hexagon-build-01-<u></u>exp/builddir/lldb-x86-win7-<u></u>msvc/build/bin<br>
CMake Error at tools/lldb/scripts/CMakeLists.<u></u>txt:8 (file):<br>
   file COPY cannot find<br>
   "C:/buildbots/hexagon-build-<u></u>01-exp/builddir/lldb-x86-win7-<u></u>msvc/llvm/tools/lldb/scripts/<u></u>PYTHON_DEBUG_LIBRARY-NOTFOUND"<u></u>.<br>
<br>
On 01/21/2015 11:53 AM, Zachary Turner wrote:<br>
> Author: zturner<br>
> Date: Wed Jan 21 11:53:10 2015<br>
> New Revision: 226679<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=226679&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=226679&view=rev</a><br>
> Log:<br>
> Some fixes for linking Python on Windows.<br>
><br>
> CMake FindPythonLibs will look for multiple versions of Python<br>
> including both debug and release, and build up a list such as<br>
> (debug <debugpath> optimized <optimizedpath>).  This confuses<br>
> the logic we have in CMake to copy the correct python dll to<br>
> the output directory so that it need not be in your system's PATH.<br>
><br>
> To alleviate this, we manually split this list and extract out<br>
> the debug and release versions of the python library, and copy<br>
> only the correct one to the output directory.<br>
><br>
> Modified:<br>
>      lldb/trunk/CMakeLists.txt<br>
>      lldb/trunk/scripts/CMakeLists.<u></u>txt<br>
><br>
> Modified: lldb/trunk/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=226679&r1=226678&r2=226679&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lldb/trunk/CMakeLists.<u></u>txt?rev=226679&r1=226678&r2=<u></u>226679&view=diff</a><br>
> ==============================<u></u>==============================<u></u>==================<br>
> --- lldb/trunk/CMakeLists.txt (original)<br>
> +++ lldb/trunk/CMakeLists.txt Wed Jan 21 11:53:10 2015<br>
> @@ -137,6 +137,23 @@ if (NOT LLDB_DISABLE_PYTHON)<br>
>       endif()<br>
>     endif()<br>
>     find_package(PythonLibs REQUIRED)<br>
> +  # PYTHON_LIBRARIES is now a list in the form (debug DebugPath optimized OptimizedPath)<br>
> +  # So we need to parse it to get the path to the respective installations.<br>
> +  list(FIND PYTHON_LIBRARIES optimized PYTHON_OPTIMIZED_INDEX)<br>
> +  list(FIND PYTHON_LIBRARIES debug PYTHON_DEBUG_INDEX)<br>
> +  if (NOT ${PYTHON_OPTIMIZED_INDEX} EQUAL -1)<br>
> +    MATH(EXPR PYTHON_OPTIMIZED_INDEX "${PYTHON_OPTIMIZED_INDEX}+1")<br>
> +    list(GET PYTHON_LIBRARIES ${PYTHON_OPTIMIZED_INDEX} PYTHON_RELEASE_LIBRARY)<br>
> +  endif()<br>
> +  if (NOT ${PYTHON_DEBUG_INDEX} EQUAL -1)<br>
> +    MATH(EXPR PYTHON_DEBUG_INDEX "${PYTHON_DEBUG_INDEX}+1")<br>
> +    list(GET PYTHON_LIBRARIES ${PYTHON_DEBUG_INDEX} PYTHON_DEBUG_LIBRARY)<br>
> +  endif()<br>
> +  if (CMAKE_BUILD_TYPE STREQUAL "Debug")<br>
> +    set(PYTHON_LIBRARY ${PYTHON_DEBUG_LIBRARY})<br>
> +  else()<br>
> +    set(PYTHON_LIBRARY ${PYTHON_RELEASE_LIBRARY})<br>
> +  endif()<br>
>     include_directories(${PYTHON_<u></u>INCLUDE_DIRS})<br>
>   endif()<br>
><br>
><br>
> Modified: lldb/trunk/scripts/CMakeLists.<u></u>txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/CMakeLists.txt?rev=226679&r1=226678&r2=226679&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lldb/trunk/scripts/<u></u>CMakeLists.txt?rev=226679&r1=<u></u>226678&r2=226679&view=diff</a><br>
> ==============================<u></u>==============================<u></u>==================<br>
> --- lldb/trunk/scripts/CMakeLists.<u></u>txt (original)<br>
> +++ lldb/trunk/scripts/CMakeLists.<u></u>txt Wed Jan 21 11:53:10 2015<br>
> @@ -3,7 +3,8 @@ set(LLVM_NO_RTTI 1)<br>
>   file(GLOB SWIG_INPUTS Python/interface/*.i)<br>
><br>
>   if (CMAKE_SYSTEM_NAME MATCHES "Windows")<br>
> -    STRING(REGEX REPLACE ".lib" ".dll" PYTHON_DLL ${PYTHON_LIBRARY})<br>
> +    STRING(REGEX REPLACE "[.]lib" ".dll" PYTHON_DLL ${PYTHON_LIBRARY})<br>
> +    message("Copying ${PYTHON_DLL} to ${CMAKE_BINARY_DIR}/bin")<br>
>       file(COPY ${PYTHON_DLL} DESTINATION ${CMAKE_BINARY_DIR}/bin)<br>
>   endif ()<br>
><br>
><br>
><br>
> ______________________________<u></u>_________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/lldb-commits</a><br>
<br>
--<br>
Rick Foos<br>
Qualcomm Innovation Center, Inc.<br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project<br>
<br>
</blockquote></div>