BTW, I'm not sure if it helps you reproduce this issue at all, but I debugged into why it was failing to update, and it looks like a pointer value that doesn't map to any section. Obviously there's another bug causing that which I have yet to understand the cause of, but thought you might be curious.<br><br><div class="gmail_quote">On Thu Jan 08 2015 at 10:56:12 AM Enrico Granata <<a href="mailto:egranata@apple.com">egranata@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>On second thought, yes, that patch is a total think-o (right idea, wrong fix)..</div><div><br></div><div>It should probably just say</div><div><br></div><div>if (success)</div><div> assert(what you said)</div><div><br></div><div>Better patch incoming.. and I wonder if we can in any way force ourselves into this scenario to test the sanity of any change in this area. Let me think about that</div></div><div style="word-wrap:break-word"><br><div><blockquote type="cite"><div>On Jan 8, 2015, at 10:45 AM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:</div><br><div>Ok so it looks like your patch doesn't fix the assert for me, but now looking more closely at your patch, I wonder if it's correct. As per the description, the purpose of your patch is to fix the case where success == false (which is what's happening to me), but you are adding a requirement to the assert that success be true. Shouldn't this be something like the following:<br><div><br></div><div><span style="line-height:19.7999992370605px">assert (!need_compare_checksums || (!old_checksum.empty() && !m_value_checksum.empty()));</span><br></div><div><span style="line-height:19.7999992370605px"><br></span></div><div><span style="line-height:19.7999992370605px"><br></span></div><br><div class="gmail_quote">On Wed Jan 07 2015 at 5:50:44 PM Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It just happens every time i run one of the tests on windows. It might be triggered because something earlier is broken, but I'll send you a stack trace or something tomorrow. Won't it be nice if/when we can debug windows core dumps from Mac? :P<br><div class="gmail_quote">On Wed, Jan 7, 2015 at 5:21 PM Enrico Granata <<a href="mailto:egranata@apple.com" target="_blank">egranata@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>If you end up with a reproducible case of the assertion firing, totally let me know - bugzilla or just an email</div><div>Hopefully it’s not so Windows-specific that I can’t get it to happen on Mac</div></div><div style="word-wrap:break-word"><br><div><blockquote type="cite"><div>On Jan 7, 2015, at 4:33 PM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:</div><br><div>Cool, i think this assertion was actually firing on windows, making it very annoying to run the test suite. I hope this fixes that<br><div class="gmail_quote">On Wed, Jan 7, 2015 at 4:30 PM Enrico Granata <<a href="mailto:egranata@apple.com" target="_blank">egranata@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: enrico<br>
Date: Wed Jan 7 18:29:12 2015<br>
New Revision: 225418<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=225418&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>pr<u></u>oject?rev=225418&view=rev</a><br>
Log:<br>
Fix a problem where a ValueObject could fail to update itself, but since it was previously valid, we'd have an old checksum to compare aginst no new checksum (because failure to update), and assert() and die. Fix the problem by only caring about this assertion logic if updates succeed<br>
<br>
Modified:<br>
lldb/trunk/source/Core/<u></u>ValueOb<u></u>ject.cpp<br>
<br>
Modified: lldb/trunk/source/Core/<u></u>ValueOb<u></u>ject.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObject.cpp?rev=225418&r1=225417&r2=225418&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>pr<u></u>oject/lldb/trunk/source/<u></u>Core/<u></u>ValueObject.cpp?rev=<u></u>225418&r1=<u></u>225417&r2=225418&<u></u>view=diff</a><br>
==============================<u></u><u></u>==============================<u></u><u></u>==================<br>
--- lldb/trunk/source/Core/<u></u>ValueOb<u></u>ject.cpp (original)<br>
+++ lldb/trunk/source/Core/<u></u>ValueOb<u></u>ject.cpp Wed Jan 7 18:29:12 2015<br>
@@ -250,7 +250,7 @@ ValueObject::<u></u>UpdateValueIfNeed<u></u>ed (bool u<br>
m_value_checksum.clear();<br>
}<br>
<br>
- assert (old_checksum.empty() == !need_compare_checksums);<br>
+ assert (success && (old_checksum.empty() == !need_compare_checksums));<br>
<br>
if (first_update)<br>
SetValueDidChange (false);<br>
<br>
<br>
______________________________<u></u><u></u>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailm<u></u>an/listinfo/lldb-commits</a><br>
</blockquote></div>
</div></blockquote></div><br></div><div style="word-wrap:break-word"><div>
<div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div>Thanks,</div><div><i>- Enrico</i><br>📩 egranata@<font color="#ff2600"></font>.com ☎️ 27683</div><div><br></div></div></div></div></div></div><br><br>
</div>
<br></div></blockquote></div></blockquote></div>
</div></blockquote></div><br><div>
<div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div>Thanks,</div><div><i>- Enrico</i><br>📩 egranata@<font color="#ff2600"></font>.com ☎️ 27683</div><div><br></div></div></div></div></div></div><br><br>
</div>
<br></div></blockquote></div>