Cool, i think this assertion was actually firing on windows, making it very annoying to run the test suite.  I hope this fixes that<br><div class="gmail_quote">On Wed, Jan 7, 2015 at 4:30 PM Enrico Granata <<a href="mailto:egranata@apple.com">egranata@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: enrico<br>
Date: Wed Jan  7 18:29:12 2015<br>
New Revision: 225418<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=225418&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=225418&view=rev</a><br>
Log:<br>
Fix a problem where a ValueObject could fail to update itself, but since it was previously valid, we'd have an old checksum to compare aginst no new checksum (because failure to update), and assert() and die. Fix the problem by only caring about this assertion logic if updates succeed<br>
<br>
Modified:<br>
    lldb/trunk/source/Core/<u></u>ValueObject.cpp<br>
<br>
Modified: lldb/trunk/source/Core/<u></u>ValueObject.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObject.cpp?rev=225418&r1=225417&r2=225418&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lldb/trunk/source/<u></u>Core/ValueObject.cpp?rev=<u></u>225418&r1=225417&r2=225418&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lldb/trunk/source/Core/<u></u>ValueObject.cpp (original)<br>
+++ lldb/trunk/source/Core/<u></u>ValueObject.cpp Wed Jan  7 18:29:12 2015<br>
@@ -250,7 +250,7 @@ ValueObject::<u></u>UpdateValueIfNeeded (bool u<br>
                 m_value_checksum.clear();<br>
             }<br>
<br>
-            assert (old_checksum.empty() == !need_compare_checksums);<br>
+            assert (success && (old_checksum.empty() == !need_compare_checksums));<br>
<br>
             if (first_update)<br>
                 SetValueDidChange (false);<br>
<br>
<br>
______________________________<u></u>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/lldb-commits</a><br>
</blockquote></div>