<div dir="ltr">Sorry Zach, looking now.</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 7, 2015 at 1:46 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">REPOSITORY<br>
  rL LLVM<br>
<br>
================<br>
Comment at: cmake/LLDBDependencies.cmake:148-150<br>
@@ -147,1 +147,5 @@<br>
<span class=""><br>
+if (LLVM_BUILD_STATIC)<br>
+  list(APPEND LLDB_SYSTEM_LIBS python2.7 z util termcap gpm ssl crypto bsd)<br>
+endif()<br>
+<br>
</span>----------------<br>
Looks like this won't work on Windows.  Is there a cross-platform way to ask for all the system libraries?   Also should you be using ${PYTHON_LIBRARIES} instead of python2.7?<br>
<br>
Also, where is this set?  I don't see it being set in the CMakeLists.txt file for building lldb-platform, so how does this fit in with the lldb-platform changes?<br>
<div class="HOEnZb"><div class="h5"><br>
<a href="http://reviews.llvm.org/D6797" target="_blank">http://reviews.llvm.org/D6797</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><br><table cellspacing="0" cellpadding="0" style="font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Vince Harron |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Technical Lead Manager |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:vharron@google.com" target="_blank">vharron@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 858-442-0868</td></tr></tbody></table><br></div></div>
</div>