<div dir="ltr"><div><span style="font-family:arial,sans-serif;font-size:13px">Currently when the tests lock up on the build server, the build script kills the tests and gets *no* test results. That means that if a bug goes in that causes a test to hang, we don't get results for *any* tests.</span></div><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">Killing the individual test causes it to show up as a FAIL (Chaoren might change this to show result as "TIMEOUT")</span></div><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div>It's not really about what tests are hanging today, it's that some day a test will hang. When that happens, do we want to lose all test results as a result? Look at the Linux buildbot history. Many runs have no test results at all. Which test caused the lockup? I have no idea.</div><div><br></div><div><span style="font-family:arial,sans-serif;font-size:13px">> Both of those options are really undesirable in my opinion.</span><br></div><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">We can make the test timeout be an OSX/Linux thing only for now...</span></div><div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">> Regardless, I kind of don't like the idea of making it easier to ignore broken tests. If it's that painful, I think the test should be either fixed or disabled. <br></div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">If a timeout test shows up as a failure, I don't think you're ignoring it.</div><div style="font-family:arial,sans-serif;font-size:13px"><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 1, 2014 at 2:48 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>Note: At some point lldb-commits got lost from the Reply list. I'm putting it back just so that other interested parties aren't kept out of the loop.</div><div><br></div><div>--</div><div><br></div>I'm kind of against this unless we know why the tests are failing, and maybe even then. Is this really a common enough thing that we need to either increase the maintenance burden of the test suite by adding features to it (any features, much less ones that are implemented differently on each platform), or have to add a dependency on a 3rd party python module? Both of those options are really undesirable in my opinion.<br><div><br></div><div>As far as I can tell, this is just for running the test suite locally -- the bots already have a global timeout. If a test hangs locally, you can just kill it with a shell command in less time than it would take for this 5 minute timeout to expire. </div><div><br></div><div>Regardless, I kind of don't like the idea of making it easier to ignore broken tests. If it's that painful, I think the test should be either fixed or disabled. </div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote">On Mon Dec 01 2014 at 2:27:40 PM Chaoren Lin <<a href="mailto:chaorenl@google.com" target="_blank">chaorenl@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style="font-family:arial,sans-serif;font-size:13px">Why are the tests hanging?</span></blockquote><div><br></div></div><div dir="ltr"><div>No clue.<br></div></div><div dir="ltr"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style="font-family:arial,sans-serif;font-size:13px">Can we just disable the hanging tests? </span></blockquote><div><br></div></div><div dir="ltr"><div>We still want them to run, they should just be equivalent to failing tests.</div><div> </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 1, 2014 at 10:06 AM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If it does go in, i think i would actually prefer psutil over platform specific implementations of it.<div><div><br><div class="gmail_quote">On Mon, Dec 1, 2014 at 10:00 AM Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Why are the tests hanging? Can we just disable the hanging tests? I'm a little leary of sinking more platform specific logic into the test runner. <br><br><div class="gmail_quote">On Mon Dec 01 2014 at 9:56:52 AM Chaoren Lin <<a href="mailto:chaorenl@google.com" target="_blank">chaorenl@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for the link Zachary, but unfortunately, we need to kill the entire process tree, and I don't think there's a way to do that portably in python itself. There's psutil, but we probably shouldn't add another dependency just for this convenience.<div><br></div><div>I think timeout works really well for linux, would it be a terrible idea to use that only for linux, TASKKILL /T for windows, and then something else for OS X?</div><div><br><br><div class="gmail_quote">On Fri Nov 21 2014 at 4:20:59 PM Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Maybe this is a good starting point:<br>
<br>
<a href="http://stackoverflow.com/questions/1191374/subprocess-with-timeout" target="_blank">http://stackoverflow.com/<u></u>quest<u></u>ions/1191374/subprocess-<u></u>with-<u></u>timeout</a><br>
<br>
<a href="http://reviews.llvm.org/D6364" target="_blank">http://reviews.llvm.org/D6364</a><br>
<br>
<br>
</blockquote></div></div></blockquote></div></blockquote></div>
</div></div></blockquote></div><br></div>
</blockquote></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><br><table cellspacing="0" cellpadding="0" style="font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Vince Harron |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Technical Lead Manager |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:vharron@google.com" target="_blank">vharron@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 858-442-0868</td></tr></tbody></table><br></div></div>
</div>