<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Thanks for all of this. It's great folk are using lldb-mi more! <br>
<br>
Sorry for not replying to your original mail about the tests, Dawn.
Have been OOO/afk. Abid brought up the same points I would have
anyway :)<br>
<br>
Cheers,<br>
Colin<br>
<br>
<div class="moz-cite-prefix">On 25/11/2014 10:44, Abid, Hafiz wrote:<br>
</div>
<blockquote
cite="mid:EB3B29AD43CA924DA27099BC85192376E115C2E5@EU-MBX-03.mgc.mentorg.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 14 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I
have enabled the tests for all hosts apart from
‘test_lldbmi_interrupt’ which was giving error to me on
Linux. I will see if I can figure out why it is failing
there. The patch is committed.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Abid<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm
0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""
lang="EN-US">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""
lang="EN-US"> Vince Harron [<a class="moz-txt-link-freetext" href="mailto:vharron@google.com">mailto:vharron@google.com</a>]
<br>
<b>Sent:</b> 25 November 2014 08:08<br>
<b>To:</b> Zachary Turner<br>
<b>Cc:</b> <a class="moz-txt-link-abbreviated" href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a>; <a class="moz-txt-link-abbreviated" href="mailto:dawn@burble.org">dawn@burble.org</a>;
Abid, Hafiz<br>
<b>Subject:</b> Re: [Lldb-commits] [PATCH] add tests
for lldb-mi<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Yes, please enable tests if they _should_ work on other
platforms.<o:p></o:p></p>
<div>
<p class="MsoNormal">On Nov 24, 2014 11:27 PM, "Zachary
Turner" <<a moz-do-not-send="true"
href="mailto:zturner@google.com">zturner@google.com</a>>
wrote:<o:p></o:p></p>
<div>
<p class="MsoNormal">On Mon Nov 24 2014 at 11:03:58 PM
<<a moz-do-not-send="true"
href="mailto:dawn@burble.org" target="_blank">dawn@burble.org</a>>
wrote:<o:p></o:p></p>
<p class="MsoNormal">Thank you for your review!<br>
<br>
On Mon, Nov 24, 2014 at 11:18:40AM +0000, Abid, Hafiz
wrote:<br>
> Hi Dawn,<br>
> I had a quick look at the tests and I think those
will be useful addition. I have<br>
> the following questions though.<br>
><br>
> 1. I am wondering why have you restricted tests to
darwin only?<br>
<br>
because I only tested on OSX and didn't want to break
any builds.<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"> This is an understandable
mentality, but I think for the greater good we should
have a policy of having all tests enabled for all
platforms, unless it exercises a specific feature of a
platform which is known to not exist or not work the
same way on other platforms.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">A debugger has the unfortunate
property that it is OS-specific by nature, and
generally someone working on a particular platform
either doesn't have access to or doesn't know anything
about other platforms. As a result, it's easy to get
into a situation where everyone only writes tests for
their own platform, or writes a feature in a way that
is specific to their platform. <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">But I think it's important to
remain vigilant against this. We have build bots for
most platforms, the notable exception being Windows,
which I'm actively working on fixing, although it's a
lot of work for one person to do so it will take some
more time.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">In the mean time, you should not
restrict tests unless you have a specific reason, and
if it breaks something you should either <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">a) revert your change and attempt
to fix the broken tests before resubmitting (sometimes
you can do this by yourself, just by looking at the
failure and guessing why this might be broken on other
platforms)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">b) run the test on other platforms
yourself (wherever possible) and fix the errors<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">c) ask for help.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><o:p></o:p></p>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
lldb-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
- Colin Riley
Games Technology Director
Codeplay Software Ltd
45 York Place, Edinburgh, EH1 3HP
Tel: 0131 466 0503
Fax: 0131 557 6600
Website: <a class="moz-txt-link-freetext" href="http://www.codeplay.com">http://www.codeplay.com</a>
Twitter: <a class="moz-txt-link-freetext" href="https://twitter.com/codeplaysoft">https://twitter.com/codeplaysoft</a>
This email and any attachments may contain confidential and /or privileged information and is for use by the addressee only. If you are not the intended recipient, please notify Codeplay Software Ltd immediately and delete the message from your computer. You may not copy or forward it,or use or disclose its contents to any other person. Any views or other information in this message which do not relate to our business are not authorized by Codeplay software Ltd, nor does this message form part of any contract unless so stated.
As internet communications are capable of data corruption Codeplay Software Ltd does not accept any responsibility for any changes made to this message after it was sent. Please note that Codeplay Software Ltd does not accept any liability or responsibility for viruses and it is your responsibility to scan any attachments.
Company registered in England and Wales, number: 04567874
Registered office: 81 Linkfield Street, Redhill RH1 6BY </pre>
<br /><br />
<hr style='border:none; color:#909090; background-color:#B0B0B0; height: 1px; width: 99%;' />
<table style='border-collapse:collapse;border:none;'>
<tr>
<td style='border:none;padding:0px 15px 0px 8px'>
<a href="http://www.avast.com/">
<img border=0 src="http://static.avast.com/emails/avast-mail-stamp.png" />
</a>
</td>
<td>
<p style='color:#3d4d5a; font-family:"Calibri","Verdana","Arial","Helvetica"; font-size:12pt;'>
This email is free from viruses and malware because <a href="http://www.avast.com/">avast! Antivirus</a> protection is active.
</p>
</td>
</tr>
</table>
<br />
</body>
</html>