<div dir="ltr">kuba,<div><br><div class="gmail_quote">i'm not sure if my previous send was sent to the correct recipients, so i'm resending it.  if it's a duplicate - sorry</div><div class="gmail_quote"><br></div><div class="gmail_quote"><br><br>i was able to try your new patch, using ubuntu14.04<br>
<br>
the patch behaves well for both clang3.5 and clang3.6, but only if i use a<br>
custom test rig called runtest.py.<br>
the patch behaves poorly for both clang3.5 and clang3.6 if i use the<br>
standard test method "ninja check-lldb"<br>
<br>
generally, runtest.py and "ninja check-lld" produce the same results, so<br>
the problem is probably something subtle<br>
<br>
<br>
<br>
with runtest.py, i get the following message for both compilers:<br>
Test: TestMemoryHistory.py found in functionalities/asan<br>
UNSUPPORTED: LLDB (/usr/bin/clang-x86_64) :: test_with_dsym<br>
(TestMemoryHistory.AsanTestCase) (requires Darwin)<br>
UNSUPPORTED: LLDB (/usr/bin/clang-x86_64) :: test_with_dwarf<br>
(TestMemoryHistory.AsanTestCase) (skipping because compiler doesn't support<br>
AddressSanitizer)<br>
----------------------------------------------------------------------<br>
Ran 2 tests in 0.071s<br>
<br>
OK (skipped=2)<br>
<br>
<br>
<br>
with "ninja check-lldb", i get the following messages for both compilers:<br>
[1/1] Testing LLDB (with a separate subprocess per test)<br>
FAILED: cd /media/psf/Raid0/projects/tot/build/tools/lldb/test &&<br>
/usr/bin/python /media/psf/Raid0/projects/tot/llvm/tools/lldb/test/dosep.py<br>
-o "-q --arch=x86_64 --executable<br>
/media/psf/Raid0/projects/tot/build/bin/lldb -s<br>
/media/psf/Raid0/projects/tot/build/lldb-test-traces -u CXXFLAGS -u CFLAGS<br>
-C clang\ -Qunused-arguments\ -fcolor-diagnostics"<br>
UNSUPPORTED: LLDB (clang -Qunused-arguments -fcolor-diagnostics-x86_64) ::<br>
test_with_dsym (TestMemoryHistory.AsanTestCase) (requires Darwin)<br>
FAIL: LLDB (clang -Qunused-arguments -fcolor-diagnostics-x86_64) ::<br>
test_with_dwarf (TestMemoryHistory.AsanTestCase)<br>
======================================================================<br>
ERROR: test_with_dwarf (TestMemoryHistory.AsanTestCase)<br>
----------------------------------------------------------------------<br>
Traceback (most recent call last):<br>
  File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 524, in<br>
wrapper<br>
    func(*args, **kwargs)<br>
  File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 506, in<br>
wrapper<br>
    if skip_fn(self):<br>
  File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 689, in<br>
fn<br>
    return not self.compilerSupportsAddressSanitizer()<br>
  File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 1462, in<br>
compilerSupportsAddressSanitizer<br>
    if self.expectedCompilerVersion(["<", "3.6.0"]):<br>
  File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 1257, in<br>
expectedCompilerVersion<br>
    return self.getCompilerVersion() < version<br>
  File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 1228, in<br>
getCompilerVersion<br>
    version_output = system([[which(compiler), "-v"]])[1]<br>
  File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 265, in<br>
system<br>
    commandList = [' '.join(x) for x in commands]<br>
TypeError: sequence item 0: expected string, NoneType found<br>
Config=x86_64-clang -Qunused-arguments -fcolor-diagnostics<br>
----------------------------------------------------------------------<br>
Ran 2 tests in 0.061s<br>
<br>
FAILED (errors=1, skipped=1)<br>
Ran 1 tests.<br>
Failing Tests (1)<br>
FAIL: LLDB (suite) :: TestMemoryHistory.py (Linux ubuntu 3.13.0-29-generic<br>
#53-Ubuntu SMP Wed Jun 4 21:00:20 UTC 2014 x86_64 x86_64)<br>
ninja: build stopped: subcommand failed.<br>
<br>
<br>
<br>
in case someone wants to try running runtest.py on ubuntu, i have attached<br>
runtest.py<br>
<br>
to run the test with runtest.py:<br>
    copy runtest.py to the folder that contains lldb<br>
    type: ./runtest.py -c -p functionalities/asan/TestMemoryHistory.py<br>
<br>
<br>
doug<br>
<br>
- {F251103, layout=link}<br>
<br>
<a href="http://reviews.llvm.org/D6272" target="_blank">http://reviews.llvm.org/D6272</a><br>
<br>
<br>
</div><div class="gmail_quote"><br></div><br></div></div>