<div dir="ltr">i was able to try your new patch, using ubuntu14.04<div><br></div><div>the patch behaves well for both clang3.5 and clang3.6, but only if i use a custom test rig called runtest.py.</div><div>the patch behaves poorly for both clang3.5 and clang3.6 if i use the standard test method "ninja check-lldb"</div><div><br></div><div>generally, runtest.py and "ninja check-lld" produce the same results, so the problem is probably something subtle</div><div><br></div><div><br></div><div><br></div><div>with runtest.py, i get the following message for both compilers:</div><div><div>Test: TestMemoryHistory.py found in functionalities/asan</div><div>UNSUPPORTED: LLDB (/usr/bin/clang-x86_64) :: test_with_dsym (TestMemoryHistory.AsanTestCase) (requires Darwin) </div><div>UNSUPPORTED: LLDB (/usr/bin/clang-x86_64) :: test_with_dwarf (TestMemoryHistory.AsanTestCase) (skipping because compiler doesn't support AddressSanitizer) </div><div>----------------------------------------------------------------------</div><div>Ran 2 tests in 0.071s</div><div><br></div><div>OK (skipped=2)</div><div><br></div></div><div><br></div><div><br></div><div>with "ninja check-lldb", i get the following messages for both compilers:</div><div><div>[1/1] Testing LLDB (with a separate subprocess per test)</div><div>FAILED: cd /media/psf/Raid0/projects/tot/build/tools/lldb/test && /usr/bin/python /media/psf/Raid0/projects/tot/llvm/tools/lldb/test/dosep.py -o "-q --arch=x86_64 --executable /media/psf/Raid0/projects/tot/build/bin/lldb -s /media/psf/Raid0/projects/tot/build/lldb-test-traces -u CXXFLAGS -u CFLAGS -C clang\ -Qunused-arguments\ -fcolor-diagnostics"</div><div>UNSUPPORTED: LLDB (clang -Qunused-arguments -fcolor-diagnostics-x86_64) :: test_with_dsym (TestMemoryHistory.AsanTestCase) (requires Darwin) </div><div>FAIL: LLDB (clang -Qunused-arguments -fcolor-diagnostics-x86_64) :: test_with_dwarf (TestMemoryHistory.AsanTestCase)</div><div>======================================================================</div><div>ERROR: test_with_dwarf (TestMemoryHistory.AsanTestCase)</div><div>----------------------------------------------------------------------</div><div>Traceback (most recent call last):</div><div> File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 524, in wrapper</div><div> func(*args, **kwargs)</div><div> File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 506, in wrapper</div><div> if skip_fn(self):</div><div> File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 689, in fn</div><div> return not self.compilerSupportsAddressSanitizer()</div><div> File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 1462, in compilerSupportsAddressSanitizer</div><div> if self.expectedCompilerVersion(["<", "3.6.0"]):</div><div> File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 1257, in expectedCompilerVersion</div><div> return self.getCompilerVersion() < version</div><div> File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 1228, in getCompilerVersion</div><div> version_output = system([[which(compiler), "-v"]])[1]</div><div> File "/media/psf/Raid0/projects/tot/lldb/test/lldbtest.py", line 265, in system</div><div> commandList = [' '.join(x) for x in commands]</div><div>TypeError: sequence item 0: expected string, NoneType found</div><div>Config=x86_64-clang -Qunused-arguments -fcolor-diagnostics</div><div>----------------------------------------------------------------------</div><div>Ran 2 tests in 0.061s</div><div><br></div><div>FAILED (errors=1, skipped=1)</div><div>Ran 1 tests.</div><div>Failing Tests (1)</div><div>FAIL: LLDB (suite) :: TestMemoryHistory.py (Linux ubuntu 3.13.0-29-generic #53-Ubuntu SMP Wed Jun 4 21:00:20 UTC 2014 x86_64 x86_64)</div><div>ninja: build stopped: subcommand failed.</div></div><div><br></div><div><br></div><div><br></div><div>in case someone wants to try running runtest.py on ubuntu, i have attached runtest.py</div><div><br></div><div>to run the test with runtest.py:</div><div> copy runtest.py to the folder that contains lldb</div><div> type: ./runtest.py -c -p functionalities/asan/TestMemoryHistory.py</div><div><br></div><div><br></div><div>doug</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Nov 15, 2014 at 2:19 PM, Kuba Brecka <span dir="ltr"><<a href="mailto:kuba.brecka@gmail.com" target="_blank">kuba.brecka@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Updating the patch to only perform the ASan tests for clang version >= 3.6.0. The older versions do not have the new ASan debugging API. Doug, could you try the patch now?<br>
<br>
<a href="http://reviews.llvm.org/D6272" target="_blank">http://reviews.llvm.org/D6272</a><br>
<br>
Files:<br>
test/functionalities/asan/Makefile<br>
test/functionalities/asan/TestMemoryHistory.py<br>
test/functionalities/asan/TestReportData.py<br>
test/lldbtest.py<br>
</blockquote></div><br></div>