I see what the issue is. Next time can you add lldb-commits as a subscriber? I'm not on this review, and neither is the public list.<br><br><div class="gmail_quote">On Mon Nov 17 2014 at 2:30:32 PM Kate Stone <<a href="mailto:katherine_stone@apple.com">katherine_stone@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">The review was tracked as <a href="http://reviews.llvm.org/D5835" target="_blank">D5835</a>.<div></div></div><div style="word-wrap:break-word"><div><br><div>
<div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="font-family:LucidaGrande;word-wrap:break-word"><font color="#424242" style="font-family:'Lucida Grande';font-size:x-small">Kate Stone</font><span style="font-family:'Lucida Grande';font-size:x-small"> </span><font color="#009193" style="font-family:'Lucida Grande';font-size:x-small"><a href="mailto:k8stone@apple.com" target="_blank">k8stone@apple.com</a></font></div><div style="font-family:Times;word-wrap:break-word"><font face="Lucida Grande" size="1"><font color="#009193"></font> Xcode <font color="#424242">Runtime Analysis Tools</font></font></div></div></div>
</div>
<br></div></div><div style="word-wrap:break-word"><div><div><blockquote type="cite"><div>On Nov 17, 2014, at 2:27 PM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:</div><br><div>Can you link me to the Phabricator issue? I vaguely recall commenting on it once, but it must not have been CC'ed to the list or something, because I've never seen it come across in a public email to the list?<br><br><div class="gmail_quote">On Mon Nov 17 2014 at 2:22:41 PM Kate Stone <<a href="mailto:katherine_stone@apple.com" target="_blank">katherine_stone@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">That seems like a perfectly reasonable solution for now. There was indeed a review sent out for this change, and there was quite a bit of community involvement in making sure everything was in fine shape for Linux as well as some speculative support for Windows editline implementations that don’t support the wide character variants. I’m glad the fix on your end was relatively straightforward.<div><br><div>
<div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="font-family:LucidaGrande;word-wrap:break-word"><font color="#424242" style="font-family:'Lucida Grande';font-size:x-small">Kate Stone</font><span style="font-family:'Lucida Grande';font-size:x-small"> </span><font color="#009193" style="font-family:'Lucida Grande';font-size:x-small"><a href="mailto:k8stone@apple.com" target="_blank">k8stone@apple.com</a></font></div><div style="font-family:Times;word-wrap:break-word"><font face="Lucida Grande" size="1"><font color="#009193"></font> Xcode <font color="#424242">Runtime Analysis Tools</font></font></div></div></div>
</div></div></div><div style="word-wrap:break-word"><div>
<br><div><blockquote type="cite"><div>On Nov 17, 2014, at 1:54 PM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:</div><br><div>Fixed this by disabling compiltion of Editline on Windows in r222177. Editline was already being disabled on Windows anyway due to existing issues, it was just being disabled at runtime instead of compile time. I looked into fixing the actual issue, and it was non-trivial. I would have pushed for a revert if this was an actual regression (i.e. Editline used to work on Windows, and now didn't), but since it was already disabled to begin with, I just turned it off.<br><br><div class="gmail_quote">On Mon Nov 17 2014 at 11:58:24 AM Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This also doesn't compile on Windows due to the use of select() on a file descriptor. Was a review ever sent out to lldb-commits for this? I follow lldb-commits somewhat closely and I don't recall ever seeing a public review go out for this. I do recall some discussion about this patch some time ago, and it was state that a review would go out so we would have time to work through any issues before submitting the patch, but then a review never happened.<br><div><br></div><div>I will spend some time looking into how this affects Windows later and how it can be fixed, but if it looks like this is not going to be trivial to fix, then maybe we need to revert until the issues can be worked out?</div><br><div class="gmail_quote">On Mon Nov 17 2014 at 11:48:58 AM Ed Maste <<a href="mailto:emaste@freebsd.org" target="_blank">emaste@freebsd.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 17 November 2014 14:07, Kate Stone <<a href="mailto:katherine.stone@apple.com" target="_blank">katherine.stone@apple.com</a>> wrote:<br>
> Author: kate<br>
> Date: Mon Nov 17 13:06:59 2014<br>
> New Revision: 222163<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=222163&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>pr<u></u><u></u>oject?rev=222163&view=rev</a><br>
> Log:<br>
> Complete rewrite of interactive editing support for single- and multi-line input.<br>
<br>
FYI, two new test failures appeared on FreeBSD after this change. I'm<br>
curious if the Linux guys see similar behaviour.<br>
<br>
<br>
FAIL: LLDB (/usr/bin/clang-x86_64) :: test_with_dwarf<br>
(TestGlobalVariables.<u></u>GlobalVar<u></u><u></u>iablesTestCase)<br>
==============================<u></u><u></u><u></u>==============================<u></u><u></u><u></u>==========<br>
FAIL: test_with_dwarf (TestGlobalVariables.<u></u>GlobalVar<u></u><u></u>iablesTestCase)<br>
Test 'frame variable --scope --no-args' which omits args and shows scopes.<br>
------------------------------<u></u><u></u><u></u>------------------------------<u></u><u></u><u></u>----------<br>
Traceback (most recent call last):<br>
File "/tank/emaste/src/llvm/tools/<u></u>l<u></u><u></u>ldb/test/lldbtest.py", line 382, in wrapper<br>
return func(self, *args, **kwargs)<br>
File "/tank/emaste/src/llvm/tools/<u></u>l<u></u><u></u>ldb/test/lang/c/global_<u></u>variabl<u></u><u></u>es/TestGlobalVariables.<u></u>py",<br>
line 24, in test_with_dwarf<br>
self.global_variables()<br>
File "/tank/emaste/src/llvm/tools/<u></u>l<u></u><u></u>ldb/test/lang/c/global_<u></u>variabl<u></u><u></u>es/TestGlobalVariables.<u></u>py",<br>
line 60, in global_variables<br>
'stop reason = breakpoint'])<br>
File "/tank/emaste/src/llvm/tools/<u></u>l<u></u><u></u>ldb/test/lldbtest.py", line 1886, in expect<br>
self.runCmd(str, msg=msg, trace = (True if trace else False),<br>
check = not error, inHistory=inHistory)<br>
File "/tank/emaste/src/llvm/tools/<u></u>l<u></u><u></u>ldb/test/lldbtest.py", line 1812, in runCmd<br>
msg if msg else CMD_MSG(cmd))<br>
AssertionError: False is not True : Process should be stopped due to breakpoint<br>
Config=x86_64-/usr/bin/clang<br>
------------------------------<u></u><u></u><u></u>------------------------------<u></u><u></u><u></u>----------<br>
Ran 2 tests in 0.200s<br>
<br>
FAILED (failures=1, skipped=1)<br>
<br>
<br>
FAIL: LLDB (/usr/bin/clang-x86_64) :: test_command_regex<br>
(TestCommandRegex.<u></u>CommandRegex<u></u><u></u>TestCase)<br>
==============================<u></u><u></u><u></u>==============================<u></u><u></u><u></u>==========<br>
ERROR: test_command_regex (TestCommandRegex.<u></u>CommandRegex<u></u><u></u>TestCase)<br>
Test a simple scenario of 'command regex' invocation and subsequent use.<br>
------------------------------<u></u><u></u><u></u>------------------------------<u></u><u></u><u></u>----------<br>
Traceback (most recent call last):<br>
File "/tank/emaste/src/llvm/tools/<u></u>l<u></u><u></u>ldb/test/functionalities/<u></u>comma<u></u><u></u>nd_regex/<u></u>TestCommandRegex.py",<br>
line 38, in test_command_regex<br>
child.expect('The following is a list of built-in, permanent<br>
debugger commands:')<br>
File "/tank/emaste/src/llvm/tools/<u></u>l<u></u><u></u>ldb/test/pexpect-2.4/pexpect.<u></u>p<u></u><u></u>y",<br>
line 1316, in expect<br>
return self.expect_list(compiled_<u></u>patt<u></u><u></u>ern_list, timeout, searchwindowsize)<br>
File "/tank/emaste/src/llvm/tools/<u></u>l<u></u><u></u>ldb/test/pexpect-2.4/pexpect.<u></u>p<u></u><u></u>y",<br>
line 1330, in expect_list<br>
return self.expect_loop(searcher_re(<u></u>p<u></u><u></u>attern_list), timeout,<br>
searchwindowsize)<br>
File "/tank/emaste/src/llvm/tools/<u></u>l<u></u><u></u>ldb/test/pexpect-2.4/pexpect.<u></u>p<u></u><u></u>y",<br>
line 1414, in expect_loop<br>
raise TIMEOUT (str(e) + '\n' + str(self))<br>
TIMEOUT: Timeout exceeded in read_nonblocking().<br>
______________________________<u></u><u></u><u></u>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailm<u></u><u></u>an/listinfo/lldb-commits</a><br>
</blockquote></div></blockquote></div>
</div></blockquote></div><br></div></div></blockquote></div>
</div></blockquote></div><br></div></div></blockquote></div>