<div dir="ltr">i couldn't figure out where to sign up for review status at <a href="http://llvm.org">llvm.org</a>, so i just took the 2 code snippets from D5846/Diff15089 and applied them to my copy of test/tools/lldb-gdbserver/main.cpp<div><br></div><div>i tested the changes with runtest.py with ubuntu14.04, clang3.5 (/usr/bin/clang) and no ccache. 5 of the 9 previously seen unit test failures remain, but the following 4 unit tests are fixed</div><div> <span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap">TestGdbRemoteAttach.py</span></div><div><font color="#000000" face="arial, sans, sans-serif"><span style="white-space:pre-wrap"> </span></font><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap">TestGdbRemoteKill.py</span></div><div><font color="#000000" face="arial, sans, sans-serif"><span style="white-space:pre-wrap"> </span></font><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap">TestGdbRemoteProcessInfo.py</span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap"> </span><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap">TestLldbGdbServer.py</span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap"><br></span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap">i got similar results when i ran ninja check-lldb </span>with ubuntu14.04, clang3.5 (/usr/bin/clang) and no ccache</div><div><br></div><div>the patch seems to fix these 4 unit tests without breaking anything else</div><div><br></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap">there is a related unit test called </span><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap">TestGdbRemoteThreadsInStopReply.py that has intermittently failed in the past, but it did not fail after your patch using either of the test methods. your patch may have fixed this failure, but i can't tell for certain.</span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap"><br></span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap">notes:</span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap"> i have since figured out how to sign up for review status (and done so)</span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap"> when i first made the patch to main.cpp, ninja didn't seem to recognize that there had been a change that needed recompiling, so i had to do a new configure</span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap"><br></span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap">doug</span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap"><br></span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap"><br></span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap"><br></span></div><div><span style="color:rgb(0,0,0);font-family:arial,sans,sans-serif;font-size:13px;white-space:pre-wrap"><br></span></div><div><font color="#000000" face="arial, sans, sans-serif"><span style="white-space:pre-wrap"><br></span></font><div><h1 class="" style="margin:0px;padding:2px 0px 12px 12px;border:0px;font-size:15px;line-height:18px;color:rgb(0,0,0);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif">test/tools/lldb-gdbserver/main.cpp</h1> </div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 17, 2014 at 11:39 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hey Doug,<div><br></div><div>Can you create yourself an account on <a href="http://reviews.llvm.org" target="_blank">reviews.llvm.org</a>, add yourself as a reviewer, and check if this patch fixes the attach failures we diagnosed at your desk the other day?</div><div><br></div><div>Thanks!</div><div><br></div><div>-Todd</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 17, 2014 at 11:38 AM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Some Linux kernels have a ptrace security feature that prevents a ptracer from attaching to the inferior if the ptracer is not an ancestor in the process hierarchy. In the gdb-remote attach tests, the llgs is not a parent of the inferior, so kernels that protect against this are failing on the attach tests.<br>
<br>
This change to the inferior test program checks if the inferior is running on Linux and has the relevant ptrace flags, and if so, first thing enables a ptracer that is not part of the parent hierarchy.<br>
<br>
<a href="http://reviews.llvm.org/D5846" target="_blank">http://reviews.llvm.org/D5846</a><br>
<br>
Files:<br>
test/tools/lldb-gdbserver/main.cpp<br>
<br>_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
<br></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a></td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><br></td></tr></tbody></table><br></div>
</font></span></div>
</blockquote></div><br></div>