<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Nope it just worked around the test failure</div><div>I didn't want the noise of the failing test, but I was making changes in that area so I cared enough that I wouldn't regress functionality.</div><div>So that's the rationale for my workaround. The bug is still there. It's a minor bug but it's there. <br><br>Sent from my iPhone</div><div><br>On Oct 8, 2014, at 9:10 AM, Todd Fiala <<a href="mailto:tfiala@google.com">tfiala@google.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">Drats.<div><br></div><div>Enrico, did your recent commit fix that?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 7, 2014 at 3:59 PM, Enrico Granata <span dir="ltr"><<a href="mailto:egranata@apple.com" target="_blank">egranata@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>Heads up. This patch seems to be the cause of <a href="http://llvm.org/bugs/show_bug.cgi?id=21190" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=21190</a></div><div><br></div><div>Essentially, the command parser gets confused with commands like:</div><div><div style="margin:0px;font-size:16px;font-family:'Perfect DOS VGA 437';color:rgb(41,249,20);background-color:rgb(0,0,0)">type summary add Rectangle --summary-string "Category1" -w Category1</div></div><div><br></div><div>and the value for the -w option ends up being ategory1 with the leading C chopped away</div><br><div><blockquote type="cite"><div><div class="h5"><div>On Oct 6, 2014, at 4:23 PM, Todd Fiala <<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>> wrote:</div><br></div></div><div><div><div class="h5">svn commit<br>Sending include/lldb/Expression/ClangExpressionParser.h<br>Sending include/lldb/Target/Target.h<br>Sending source/Expression/ClangExpressionParser.cpp<br>Sending source/Expression/ClangFunction.cpp<br>Sending source/Expression/ClangUserExpression.cpp<br>Sending source/Expression/ClangUtilityFunction.cpp<br>Sending source/Interpreter/Args.cpp<br>Sending source/Target/Target.cpp<br>Transmitting file data ........<br>Committed revision 219169.<br><br><a href="http://reviews.llvm.org/D5472" target="_blank">http://reviews.llvm.org/D5472</a><br><br><br><br></div></div>_______________________________________________<br>lldb-commits mailing list<br><a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br></div></blockquote></div><br><div>
<div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div>Thanks,</div><div><i>- Enrico</i><br>📩 egranata@<font color="#ff2600"></font>.com ☎️ 27683</div><div><br></div></div></div></div></div></div><br><br>
</div>
<br></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap="" style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap="" style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap="" style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a></td><td nowrap="" style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><br></td></tr></tbody></table><br></div>
</div>
</div></blockquote></body></html>