<div dir="ltr"><div>const char *</div><div>HostInfoLinux::LookupGroupName(uint32_t gid, std::string &group_name)</div><div>{</div><div>#if defined(__ANDROID__)</div><div>    assert(false && "getgrgid_r() not supported on Android");</div><div>#else</div><div>    return HostInfoPosix::LookupGroupName(gid, group_name);</div><div>#endif</div><div>}</div><div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 26, 2014 at 1:03 PM, Tong Shen <span dir="ltr"><<a href="mailto:endlessroad@google.com" target="_blank">endlessroad@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">HostThreadLinux can overwrite Cancel() so ifdef only happens in<br>
HostThreadLinux::Cancel().<br>
I've done that and will upload later.<br>
<br>
Do you have any suggestion on HostInfoPosix, though? How can we move<br>
the ifdef to HostInfoLinux without duplicating<br>
HostInfoPosix::LookupGroupName() ?<br>
<div class="HOEnZb"><div class="h5"><br>
On Fri, Sep 26, 2014 at 12:35 PM, Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>> wrote:<br>
> I'm not seeing the changes to HostInfoPosix and HostThreadPosix that I<br>
> suggested.  Are those still coming in a followup?<br>
><br>
> On Fri, Sep 26, 2014 at 11:59 AM, Tong Shen <<a href="mailto:endlessroad@google.com">endlessroad@google.com</a>> wrote:<br>
>><br>
>> <a href="http://reviews.llvm.org/D5495" target="_blank">http://reviews.llvm.org/D5495</a><br>
>><br>
>> Files:<br>
>>   include/lldb/Core/IOHandler.h<br>
>>   include/lldb/Host/linux/Config.h<br>
>>   source/Core/IOHandler.cpp<br>
>>   source/Host/common/Host.cpp<br>
>>   source/Host/common/Socket.cpp<br>
>>   source/Host/linux/Host.cpp<br>
>>   source/Host/posix/HostInfoPosix.cpp<br>
>>   source/Host/posix/HostThreadPosix.cpp<br>
>>   source/Interpreter/CommandInterpreter.cpp<br>
>>   source/Plugins/Process/Linux/LinuxThread.h<br>
>>   source/Plugins/Process/Linux/NativeProcessLinux.cpp<br>
>>   source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.h<br>
>>   source/Plugins/Process/Linux/ProcessLinux.cpp<br>
>>   source/Plugins/Process/Linux/ProcessLinux.h<br>
>>   source/Plugins/Process/Linux/ProcessMonitor.cpp<br>
>>   source/Plugins/Process/POSIX/POSIXThread.cpp<br>
>>   source/Plugins/Process/POSIX/POSIXThread.h<br>
>>   source/Plugins/Process/POSIX/ProcessPOSIX.cpp<br>
>><br>
>> source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_arm64.cpp<br>
>><br>
>> source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_mips64.cpp<br>
>>   source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86.cpp<br>
>>   source/Plugins/Process/Utility/RegisterInfos_arm64.h<br>
>>   source/Plugins/Process/elf-core/RegisterContextPOSIXCore_mips64.cpp<br>
>>   source/Plugins/Process/elf-core/RegisterContextPOSIXCore_x86_64.cpp<br>
>>   source/Plugins/Process/elf-core/ThreadElfCore.cpp<br>
>>   source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp<br>
>>   source/Target/ProcessLaunchInfo.cpp<br>
>>   source/Target/Thread.cpp<br>
>>   tools/lldb-gdbserver/lldb-gdbserver.cpp<br>
><br>
><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Best Regards, Tong Shen<br>
</font></span></blockquote></div><br></div>