<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 16, 2014, at 1:28 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><br class=""><br class=""><div class="gmail_quote">On Tue Sep 16 2014 at 1:24:20 PM Enrico Granata <<a href="mailto:egranata@apple.com" class="">egranata@apple.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class=""><blockquote type="cite" class=""><div class="">On Sep 16, 2014, at 12:32 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank" class="">echristo@gmail.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class="">This is unused by anything in lldb. Any reason to put it in explicitly? (It's triggering on a Werror build of llvm+lldb).</div></div></blockquote><div class=""><br class=""></div></div></div><div style="word-wrap:break-word" class=""><div class=""><div class="">I plan to use this facility on an internal Apple branch, but it is itself general enough to warrant being in trunk</div><div class=""><br class=""></div><div class="">With that said, the solution seems to fix whatever is causing the breakage, rather than removing the code.</div></div></div><div style="word-wrap:break-word" class=""><div class=""><br class=""></div></div></blockquote><div class=""><br class=""></div><div class="">The breakage is that it's an unused function :)</div><div class=""><br class=""></div><div class=""><div class="">/usr/local/google/home/echristo/sources/llvm/tools/lldb/source/DataFormatters/FormatManager.cpp:961:13: error: unused</div><div class=""> function 'AddEmptyFilter' [-Werror,-Wunused-function]</div><div class="">static void AddEmptyFilter (TypeCategoryImpl::SharedPointer category_sp,</div><div class=""> ^</div><div class="">1 error generated.</div></div><div class=""><br class=""></div><div class="">So if you wouldn't mind reverting it (since your commit only added this function) until you have some external use of it in lldb?</div><div class=""><br class=""></div></div></div></blockquote><div><br class=""></div><div><div style="margin: 0px; font-size: 16px; font-family: 'Perfect DOS VGA 437'; color: rgb(41, 249, 20); background-color: rgb(0, 0, 0);" class="">Sending source/DataFormatters/FormatManager.cpp</div><div style="margin: 0px; font-size: 16px; font-family: 'Perfect DOS VGA 437'; color: rgb(41, 249, 20); background-color: rgb(0, 0, 0);" class="">Transmitting file data .</div><div style="margin: 0px; font-size: 16px; font-family: 'Perfect DOS VGA 437'; color: rgb(41, 249, 20); background-color: rgb(0, 0, 0);" class="">Committed revision 217900.</div><div class=""><br class=""></div></div><div>I am not sure what this warning is buying us, but who am I to argue with the almighty compiler? :)</div><div>Reverted.</div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote"><div class="">Thanks!</div><div class=""><br class=""></div><div class="">-eric</div><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">-eric</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Sep 16, 2014 at 10:41 AM, Enrico Granata <span dir="ltr" class=""><<a href="mailto:egranata@apple.com" target="_blank" class="">egranata@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: enrico<br class="">
Date: Tue Sep 16 12:41:54 2014<br class="">
New Revision: 217891<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=217891&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=217891&view=rev</a><br class="">
Log:<br class="">
Add a convenience function to FormatManager to setup an empty filter (one that suppresses all children, that is)<br class="">
<br class="">
Modified:<br class="">
lldb/trunk/source/DataFormatters/FormatManager.cpp<br class="">
<br class="">
Modified: lldb/trunk/source/DataFormatters/FormatManager.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/DataFormatters/FormatManager.cpp?rev=217891&r1=217890&r2=217891&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/DataFormatters/FormatManager.cpp?rev=217891&r1=217890&r2=217891&view=diff</a><br class="">
==============================================================================<br class="">
--- lldb/trunk/source/DataFormatters/FormatManager.cpp (original)<br class="">
+++ lldb/trunk/source/DataFormatters/FormatManager.cpp Tue Sep 16 12:41:54 2014<br class="">
@@ -957,6 +957,15 @@ static void AddFilter (TypeCategoryImpl<br class="">
else<br class="">
category_sp->GetTypeFiltersContainer()->Add(type_name,filter_sp);<br class="">
}<br class="">
+<br class="">
+static void AddEmptyFilter (TypeCategoryImpl::SharedPointer category_sp,<br class="">
+ const char* description,<br class="">
+ ConstString type_name,<br class="">
+ ScriptedSyntheticChildren::Flags flags,<br class="">
+ bool regex = false)<br class="">
+{<br class="">
+ AddFilter(category_sp, {}, description, type_name, flags, regex);<br class="">
+}<br class="">
#endif<br class="">
<br class="">
void<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
lldb-commits mailing list<br class="">
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank" class="">lldb-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div></div><div style="word-wrap:break-word" class=""><div class=""></div><br class=""><div class="">
<div style="letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; word-wrap: break-word;" class=""><div style="letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; word-wrap: break-word;" class=""><div style="letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; word-wrap: break-word;" class=""><div style="letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; word-wrap: break-word;" class=""><div style="letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; word-wrap: break-word;" class=""><div class="">Thanks,</div><div class=""><i class="">- Enrico</i><br class="">📩 egranata@<font color="#ff2600" class=""></font>.com ☎️ 27683</div><div class=""><br class=""></div></div></div></div></div></div><br class=""><br class="">
</div>
<br class=""></div></blockquote></div>
</div></blockquote></div><br class=""><div class="">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Thanks,</div><div class=""><i class="">- Enrico</i><br class="">📩 egranata@<font color="#ff2600" class=""></font>.com ☎️ 27683</div><div class=""><br class=""></div></div></div></div></div></div><br class="Apple-interchange-newline"><br class="Apple-interchange-newline">
</div>
<br class=""></body></html>