<div dir="ltr">That looks pretty reasonable. It'd be good to have Greg review it, though, since that's his baby.<div><br></div><div>Greg, pushing on your stack. Thanks!</div><div><br></div><div>-Todd</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 15, 2014 at 1:22 PM, Stephane Sezer <span dir="ltr"><<a href="mailto:sas@fb.com" target="_blank">sas@fb.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div><font><span style="font-size:10pt">
<div>This should be slightly better.<br>
<br>
</div>
</span></font></div><div><div class="h5">
<div><font><span style="font-size:10pt">
<div><br>
<br>
On Sep 15, 2014, at 9:52 AM, Todd Fiala <<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>> wrote:<br>
<br>
> That'd be great, thanks!<br>
> <br>
> On Mon, Sep 15, 2014 at 9:48 AM, Stephane Sezer <<a href="mailto:sas@fb.com" target="_blank">sas@fb.com</a>> wrote:<br>
> Hey Todd,<br>
> <br>
> I see what you are talking about. If someone exits the debugger by typing `exit` then there is an empty new-line being printed. The reason why I wrote this patch in the first place is because I’m used to exit the debugger with ^D instead, which results in
the shell prompt being printed right after the debugger prompt (lldb).<br>
> <br>
> I think I could rework this patch to print the newline only on ^D instead of printing it all the time when we exit.<br>
> <br>
> On Sep 15, 2014, at 9:21 AM, Todd Fiala <<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>> wrote:<br>
> <br>
> > Hey Stephane,<br>
> ><br>
> > For typical debugger usage, this is generally adding an extra blank line, which feels a little awkward. Could you consider reworking this perhaps to only add the extra \n if we're ending mid-line? Or fix the systems that are ending mid-line and have them
add the \n when shutting down (e.g. inferior process stdout/stderr)?<br>
> ><br>
> > I found when I played with it a while, the extra line made me feel like my program was outputting something I wasn't expecting, or that I'm somehow missing something from the debugger.<br>
> ><br>
> > -Todd<br>
> ><br>
> > On Wed, Sep 10, 2014 at 1:45 PM, Stephane Sezer <<a href="mailto:sas@fb.com" target="_blank">sas@fb.com</a>> wrote:<br>
> > This prevents messing up the shell's prompt.<br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > lldb-commits mailing list<br>
> > <a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
> ><br>
> ><br>
> ><br>
> ><br>
> > --<br>
> > Todd Fiala | Software Engineer | <a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a> | <a href="tel:650-943-3180" value="+16509433180" target="_blank">650-943-3180</a><br>
> ><br>
> <br>
> <br>
> <br>
> <br>
> -- <br>
> Todd Fiala | Software Engineer | <a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a> | <a href="tel:650-943-3180" value="+16509433180" target="_blank">650-943-3180</a><br>
<br>
</div>
</span></font></div>
</div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>