<div dir="ltr">Hi Jim,<div><br></div><div>I don't expect you to read this patch line by line, but do you have any remaining high level concerns?</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 5, 2014 at 3:28 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Fixed issues suggested by Jim Ingham.  HostThread is now a standalone class that uses a facade pattern to hide the platform-specific details of the different thread implementations.  Various other style and naming issues have also been addressed.<br>
<span class=""><br>
<a href="http://reviews.llvm.org/D5198" target="_blank">http://reviews.llvm.org/D5198</a><br>
<br>
Files:<br>
  include/lldb/Core/Communication.h<br>
  include/lldb/Core/DataBuffer.h<br>
  include/lldb/Core/Debugger.h<br>
  include/lldb/Host/Host.h<br>
  include/lldb/Host/HostInfoBase.h<br>
</span>  include/lldb/Host/HostNativeThread.h<br>
  include/lldb/Host/HostNativeThreadBase.h<br>
  include/lldb/Host/HostThread.h<br>
  include/lldb/Host/ThisThread.h<br>
  include/lldb/Host/ThreadLauncher.h<br>
<span class="">  include/lldb/Host/freebsd/HostInfoFreeBSD.h<br>
  include/lldb/Host/freebsd/HostThreadFreeBSD.h<br>
  include/lldb/Host/linux/HostInfoLinux.h<br>
  include/lldb/Host/linux/HostThreadLinux.h<br>
  include/lldb/Host/macosx/HostThreadMacOSX.h<br>
  include/lldb/Host/posix/HostThreadPosix.h<br>
  include/lldb/Host/windows/HostThreadWindows.h<br>
  include/lldb/Target/Process.h<br>
  include/lldb/lldb-private-enumerations.h<br>
  include/lldb/lldb-types.h<br>
  lldb.xcodeproj/project.pbxproj<br>
  source/API/SBHostOS.cpp<br>
  source/Core/Communication.cpp<br>
  source/Core/Debugger.cpp<br>
  source/Core/Log.cpp<br>
  source/Host/CMakeLists.txt<br>
  source/Host/common/Host.cpp<br>
  source/Host/common/HostInfoBase.cpp<br>
</span>  source/Host/common/HostNativeThreadBase.cpp<br>
  source/Host/common/HostThread.cpp<br>
  source/Host/common/ThisThread.cpp<br>
  source/Host/common/ThreadLauncher.cpp<br>
<div class="HOEnZb"><div class="h5">  source/Host/freebsd/Host.cpp<br>
  source/Host/freebsd/HostInfoFreeBSD.cpp<br>
  source/Host/freebsd/HostThreadFreeBSD.cpp<br>
  source/Host/freebsd/ThisThread.cpp<br>
  source/Host/linux/Host.cpp<br>
  source/Host/linux/HostInfoLinux.cpp<br>
  source/Host/linux/HostThreadLinux.cpp<br>
  source/Host/linux/ThisThread.cpp<br>
  source/Host/macosx/Host.mm<br>
  source/Host/macosx/HostThreadMacOSX.mm<br>
  source/Host/macosx/ThisThread.cpp<br>
  source/Host/posix/HostThreadPosix.cpp<br>
  source/Host/windows/Host.cpp<br>
  source/Host/windows/HostThreadWindows.cpp<br>
  source/Host/windows/ThisThread.cpp<br>
  source/Plugins/Process/CMakeLists.txt<br>
  source/Plugins/Process/FreeBSD/ProcessMonitor.cpp<br>
  source/Plugins/Process/FreeBSD/ProcessMonitor.h<br>
  source/Plugins/Process/Linux/NativeProcessLinux.cpp<br>
  source/Plugins/Process/Linux/NativeProcessLinux.h<br>
  source/Plugins/Process/Linux/NativeThreadLinux.cpp<br>
  source/Plugins/Process/Linux/ProcessMonitor.cpp<br>
  source/Plugins/Process/Linux/ProcessMonitor.h<br>
  source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
  source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h<br>
  source/Plugins/Process/POSIX/POSIXThread.cpp<br>
  source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp<br>
  source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h<br>
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp<br>
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.h<br>
  source/Target/Process.cpp<br>
  tools/lldb-gdbserver/lldb-gdbserver.cpp<br>
</div></div></blockquote></div><br></div>