<div dir="ltr"><div class="markdown-here-wrapper" style><p style="margin:1.2em 0px!important">LGTM. I ran through with this last night and it looks fine.</p>
<p style="margin:1.2em 0px!important">The issue I called out earlier with the dyld resolver maybe needing one more check was unnecessary - in the case I was testing it I was skipping one too few exec calls and so caught two inferior exec handlers in a row. The second one was obscuring what was happening with the first (correct) path.</p>
<pre style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;font-size:1em;line-height:1.2em;margin:1.2em 0px"><code style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;margin:0px 0.15em;padding:0px 0.3em;white-space:pre-wrap;border:1px solid rgb(234,234,234);border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;display:inline;background-color:rgb(248,248,248);white-space:pre;overflow:auto;border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;border:1px solid rgb(204,204,204);padding:0.5em 0.7em;display:block!important">svn commit
Sending source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
Transmitting file data .
Committed revision 217253.
</code></pre><div title="MDH:TEdUTS4gwqBJIHJhbiB0aHJvdWdoIHdpdGggdGhpcyBsYXN0IG5pZ2h0IGFuZCBpdCBsb29rcyBm
aW5lLjxkaXY+PGJyPjwvZGl2PjxkaXY+VGhlIGlzc3VlIEkgY2FsbGVkIG91dCBlYXJsaWVyIHdp
dGggdGhlIGR5bGQgcmVzb2x2ZXIgbWF5YmUgbmVlZGluZyBvbmUgbW9yZSBjaGVjayB3YXMgdW5u
ZWNlc3NhcnkgLSBpbiB0aGUgY2FzZSBJIHdhcyB0ZXN0aW5nIGl0IEkgd2FzIHNraXBwaW5nIG9u
ZSB0b28gZmV3IGV4ZWMgY2FsbHMgYW5kIHNvIGNhdWdodCB0d28gaW5mZXJpb3IgZXhlYyBoYW5k
bGVycyBpbiBhIHJvdy4gJm5ic3A7VGhlIHNlY29uZCBvbmUgd2FzIG9ic2N1cmluZyB3aGF0IHdh
cyBoYXBwZW5pbmcgd2l0aCB0aGUgZmlyc3QgKGNvcnJlY3QpIHBhdGguPC9kaXY+PGRpdj48YnI+
PC9kaXY+PGRpdj5gYGA8L2Rpdj48ZGl2PjxkaXY+c3ZuIGNvbW1pdDwvZGl2PjxkaXY+U2VuZGlu
ZyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDtzb3VyY2UvUGx1Z2lucy9EeW5hbWljTG9hZGVy
L1BPU0lYLURZTEQvRHluYW1pY0xvYWRlclBPU0lYRFlMRC5jcHA8L2Rpdj48ZGl2PlRyYW5zbWl0
dGluZyBmaWxlIGRhdGEgLjwvZGl2PjxkaXY+Q29tbWl0dGVkIHJldmlzaW9uIDIxNzI1My48L2Rp
dj48L2Rpdj48ZGl2PmBgYDwvZGl2PjxkaXY+PGJyPjwvZGl2Pg==" style="height:0;font-size:0em;padding:0;margin:0"></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 4, 2014 at 3:24 PM, Stephane Sezer <span dir="ltr"><<a href="mailto:sas@fb.com" target="_blank">sas@fb.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br>_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>