<div dir="ltr">LGTM.  Are you able to check that in?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Sep 2, 2014 at 2:05 PM, Stephane Sezer <span dir="ltr"><<a href="mailto:sas@fb.com" target="_blank">sas@fb.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">    Without this, we get the following link errors:<br>
<br>
    Undefined symbols for architecture x86_64:<br>
      "lldb_private::HostInfoMacOSX::GetOSKernelDescription(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&)", referenced from:<br>
          lldb_private::Platform::GetOSKernelDescription(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&) in liblldbTarget.a(Platform.cpp.o)<br>
      "lldb_private::HostInfoMacOSX::GetOSBuildString(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&)", referenced from:<br>
          PlatformMacOSX::GetFileWithUUID(lldb_private::FileSpec const&, lldb_private::UUID const*, lldb_private::FileSpec&) in liblldbPluginPlatformMacOSX.a(PlatformMacOSX.cpp.o)<br>
          lldb_private::Platform::GetOSBuildString(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&) in liblldbTarget.a(Platform.cpp.o)<br>
      "lldb_private::HostInfoMacOSX::GetOSVersion(unsigned int&, unsigned int&, unsigned int&)", referenced from:<br>
          lldb_private::Host::GetPosixspawnFlags(lldb_private::ProcessLaunchInfo&) in liblldbHost.a(Host.cpp.o)<br>
          lldb_private::Platform::GetOSVersion(unsigned int&, unsigned int&, unsigned int&) in liblldbTarget.a(Platform.cpp.o)<br>
      "lldb_private::HostInfoMacOSX::ComputeHeaderDirectory(lldb_private::FileSpec&)", referenced from:<br>
          lldb_private::HostInfoBase::GetLLDBPath(lldb::PathType, lldb_private::FileSpec&) in liblldbHost.a(HostInfoBase.cpp.o)<br>
      "lldb_private::HostInfoMacOSX::ComputeSupportExeDirectory(lldb_private::FileSpec&)", referenced from:<br>
          lldb_private::HostInfoBase::GetLLDBPath(lldb::PathType, lldb_private::FileSpec&) in liblldbHost.a(HostInfoBase.cpp.o)<br>
      "lldb_private::HostInfoMacOSX::ComputePythonDirectory(lldb_private::FileSpec&)", referenced from:<br>
          lldb_private::HostInfoBase::GetLLDBPath(lldb::PathType, lldb_private::FileSpec&) in liblldbHost.a(HostInfoBase.cpp.o)<br>
      "lldb_private::HostInfoMacOSX::GetProgramFileSpec()", referenced from:<br>
          lldb::SBHostOS::GetProgramFileSpec() in liblldbAPI.a(SBHostOS.cpp.o)<br>
          lldb_private::CommandInterpreter::SourceInitFile(bool, lldb_private::CommandReturnObject&) in liblldbInterpreter.a(CommandInterpreter.cpp.o)<br>
      "lldb_private::HostInfoMacOSX::ComputeSystemPluginsDirectory(lldb_private::FileSpec&)", referenced from:<br>
          lldb_private::HostInfoBase::GetLLDBPath(lldb::PathType, lldb_private::FileSpec&) in liblldbHost.a(HostInfoBase.cpp.o)<br>
      "lldb_private::HostInfoMacOSX::ComputeUserPluginsDirectory(lldb_private::FileSpec&)", referenced from:<br>
          lldb_private::HostInfoBase::GetLLDBPath(lldb::PathType, lldb_private::FileSpec&) in liblldbHost.a(HostInfoBase.cpp.o)<br>
      "lldb_private::HostInfoMacOSX::ComputeHostArchitectureSupport(lldb_private::ArchSpec&, lldb_private::ArchSpec&)", referenced from:<br>
          lldb_private::HostInfoBase::GetArchitecture(lldb_private::HostInfoBase::ArchitectureKind) in liblldbHost.a(HostInfoBase.cpp.o)<br>
    ld: symbol(s) not found for architecture x86_64<br>
<br>
<br>_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>