<div dir="ltr">This change went in here:<div><div>svn commit</div><div>Sending source/Plugins/Process/Linux/NativeThreadLinux.cpp</div><div>Sending source/Plugins/Process/POSIX/POSIXThread.cpp</div><div>Sending source/Plugins/Process/Utility/CMakeLists.txt</div>
<div>Sending source/Plugins/Process/Utility/RegisterContextDarwin_arm64.cpp</div><div>Adding source/Plugins/Process/Utility/RegisterContextLinux_arm64.cpp</div><div>Adding source/Plugins/Process/Utility/RegisterContextLinux_arm64.h</div>
<div>Adding source/Plugins/Process/Utility/RegisterInfos_arm64.h</div><div>Sending source/Utility/ARM64_GCC_Registers.h</div><div>Transmitting file data ........</div><div>Committed revision 216737.</div></div>
<div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 29, 2014 at 7:46 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">(And thanks for checking it out!)</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br>
<br><div class="gmail_quote">On Fri, Aug 29, 2014 at 7:46 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>> <span style="font-family:arial,sans-serif;font-size:12.7272720336914px">Is this necessary in RegisterInfos_arm64.h?</span><br style="font-family:arial,sans-serif;font-size:12.7272720336914px">
<span style="font-family:arial,sans-serif;font-size:12.7272720336914px">> +#include "../../../Utility/ARM64_GCC_</span><span style="font-family:arial,sans-serif;font-size:12.7272720336914px">Registers.h"</span><br style="font-family:arial,sans-serif;font-size:12.7272720336914px">
<span style="font-family:arial,sans-serif;font-size:12.7272720336914px">>+#include "../../../Utility/ARM64_DWARF_</span><span style="font-family:arial,sans-serif;font-size:12.7272720336914px">Registers.h"</span><br style="font-family:arial,sans-serif;font-size:12.7272720336914px">
<div><span style="font-family:arial,sans-serif;font-size:12.7272720336914px"><br></span></div></div><div><span style="font-family:arial,sans-serif;font-size:12.7272720336914px">I'll have a look at that before submitting. If nothing else, the ../../.. doesn't need to be there. (He may have been copying some of my early code before I grok'd how all the paths were set up --- I'll fix those too if I find them.).</span></div>
<div><span style="font-family:arial,sans-serif;font-size:12.7272720336914px"><br></span></div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 29, 2014 at 12:37 AM, Jason Molenda <span dir="ltr"><<a href="mailto:jason@molenda.com" target="_blank">jason@molenda.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Looks good to me, please commit. I'll be the one who has to fix it if our arm64 back end is broken :) but I don't anticipate any problems.<br>
<br>
Is this necessary in RegisterInfos_arm64.h?<br>
<br>
+#include "../../../Utility/ARM64_GCC_Registers.h"<br>
+#include "../../../Utility/ARM64_DWARF_Registers.h"<br>
<br>
The previous RegisterContext_arm64 just included these as "ARM64_GCC_Registers.h" without any directory paths - the cmake/xcode configurations must have put the source/Utility directory in the list of include directories?<br>
<br>
J<br>
<div><div><br>
<br>
On Aug 28, 2014, at 7:57 AM, Todd Fiala <<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>> wrote:<br>
<br>
> Attaching the final diff I'm using over here (needed minor rebasing against TOT, r216668).<br>
><br>
><br>
> On Thu, Aug 28, 2014 at 7:40 AM, Todd Fiala <<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>> wrote:<br>
> Hey Greg and Jim,<br>
><br>
> Can I get somebody on the Apple side to review the Darwin side of this change?<br>
><br>
> <a href="http://reviews.llvm.org/D4580" target="_blank">http://reviews.llvm.org/D4580</a><br>
><br>
> He's refactored some of the arm64 code in the Darwin register context to use a common header that he's also referencing on the Linux register context work. Since I recall hearing darwin and Linux handle some arm registers slightly differently (at least in the Thumb case), I want to make sure the sharing doesn't introduce bugs in that area.<br>
><br>
> I'll be testing the D4580 change in a minute here when I'm done with D4381. If I have to do heavy rebasing, I'll post the updated patch here. (It's from a while back now).<br>
><br>
> Thanks!<br>
><br>
> --<br>
> Todd Fiala | Software Engineer | <a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a> | <a href="tel:650-943-3180" value="+16509433180" target="_blank">650-943-3180</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Todd Fiala | Software Engineer | <a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a> | <a href="tel:650-943-3180" value="+16509433180" target="_blank">650-943-3180</a><br>
><br>
</div></div>> <pawelo_reg_context_arm64_rebase_r216668.diff>_______________________________________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>