<div dir="ltr">Submitted:<div><br><div><div>svn commit</div><div>Sending        include/lldb/Symbol/FuncUnwinders.h</div><div>Sending        include/lldb/Symbol/UnwindPlan.h</div><div>Sending        include/lldb/Target/UnwindAssembly.h</div>
<div>Sending        source/Commands/CommandObjectTarget.cpp</div><div>Sending        source/Plugins/Process/Utility/RegisterContextLLDB.cpp</div><div>Sending        source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp</div>
<div>Sending        source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.h</div><div>Sending        source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp</div><div>Sending        source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.h</div>
<div>Sending        source/Symbol/FuncUnwinders.cpp</div><div>Sending        source/Symbol/UnwindPlan.cpp</div><div>Transmitting file data ...........</div><div>Committed revision 216406.</div></div><div><br></div></div></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Aug 25, 2014 at 1:21 PM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">LGTM.  Jason - I'm going to check this in based on your previous comments and Tong's adjustments.<div><br></div><div>All tests passed on Ubuntu 14.04 x86_64, llvm-3.5-build lldb, cmake.</div><div>No new tests broken on MacOSX 10.9.4 x86_64 with Xcode6-Beta6-built lldb.</div>

<div><br></div><div>The two MacOSX failures I see here (and on clean TOT) are:</div><div>







<p>FAIL: LLDB (suite) :: TestCallStopAndContinue.py (Darwin <a href="http://tfiala-macpro2.mtv.corp.google.com" target="_blank">tfiala-macpro2.mtv.corp.google.com</a> 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun  3 21:27:35 PDT 2014; root:xnu-2422.110.17~1/RELEASE_X86_64 x86_64 i386)</p>


<p>This one seems to seg fault but not consistently.  In any event, it appears to be unrelated to Tong's change.</p></div></div><div class="gmail_extra"><div class=""><br><br><div class="gmail_quote">On Mon, Aug 25, 2014 at 10:55 AM, Tong Shen <span dir="ltr"><<a href="mailto:endlessroad@google.com" target="_blank">endlessroad@google.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sorry, wrong version of patch...<div class="gmail_extra">
</div></div>
</blockquote></div><br><br clear="all"><div><br></div></div><div class="">-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">

<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>

<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>

<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>